Commit d2b8e36a authored by sergeyu's avatar sergeyu Committed by Commit bot

Remove first_message argument from AuthenticatorFactory::Create().

The first_message parameter in AuthenticatorFactory::Create() is no
longer used anywhere, so it can be removed.

Review URL: https://codereview.chromium.org/1769603005

Cr-Commit-Position: refs/heads/master@{#379592}
parent 0bd0dc5e
......@@ -167,12 +167,10 @@ PamAuthorizationFactory::PamAuthorizationFactory(
PamAuthorizationFactory::~PamAuthorizationFactory() {}
scoped_ptr<protocol::Authenticator>
PamAuthorizationFactory::CreateAuthenticator(
const std::string& local_jid,
const std::string& remote_jid,
const buzz::XmlElement* first_message) {
PamAuthorizationFactory::CreateAuthenticator(const std::string& local_jid,
const std::string& remote_jid) {
scoped_ptr<protocol::Authenticator> authenticator(
underlying_->CreateAuthenticator(local_jid, remote_jid, first_message));
underlying_->CreateAuthenticator(local_jid, remote_jid));
return make_scoped_ptr(new PamAuthorizer(std::move(authenticator)));
}
......
......@@ -22,8 +22,7 @@ class PamAuthorizationFactory : public protocol::AuthenticatorFactory {
scoped_ptr<protocol::Authenticator> CreateAuthenticator(
const std::string& local_jid,
const std::string& remote_jid,
const buzz::XmlElement* first_message) override;
const std::string& remote_jid) override;
private:
scoped_ptr<protocol::AuthenticatorFactory> underlying_;
......
......@@ -232,8 +232,7 @@ class NoopAuthenticatorFactory : public protocol::AuthenticatorFactory {
scoped_ptr<protocol::Authenticator> CreateAuthenticator(
const std::string& local_jid,
const std::string& remote_jid,
const buzz::XmlElement* first_message) override {
const std::string& remote_jid) override {
return make_scoped_ptr(new NoopAuthenticator());
}
};
......
......@@ -134,8 +134,7 @@ class AuthenticatorFactory {
// for the result of this method.
virtual scoped_ptr<Authenticator> CreateAuthenticator(
const std::string& local_jid,
const std::string& remote_jid,
const buzz::XmlElement* first_message) = 0;
const std::string& remote_jid) = 0;
};
} // namespace protocol
......
......@@ -210,13 +210,11 @@ FakeHostAuthenticatorFactory::FakeHostAuthenticatorFactory(
action_(action), async_(async) {
}
FakeHostAuthenticatorFactory::~FakeHostAuthenticatorFactory() {
}
FakeHostAuthenticatorFactory::~FakeHostAuthenticatorFactory() {}
scoped_ptr<Authenticator> FakeHostAuthenticatorFactory::CreateAuthenticator(
const std::string& local_jid,
const std::string& remote_jid,
const buzz::XmlElement* first_message) {
const std::string& remote_jid) {
scoped_ptr<FakeAuthenticator> authenticator(new FakeAuthenticator(
FakeAuthenticator::HOST, round_trips_, action_, async_));
authenticator->set_messages_till_started(messages_till_started_);
......
......@@ -101,8 +101,7 @@ class FakeHostAuthenticatorFactory : public AuthenticatorFactory {
// AuthenticatorFactory interface.
scoped_ptr<Authenticator> CreateAuthenticator(
const std::string& local_jid,
const std::string& remote_jid,
const buzz::XmlElement* first_message) override;
const std::string& remote_jid) override;
private:
int round_trips_;
......
......@@ -27,8 +27,7 @@ It2MeHostAuthenticatorFactory::~It2MeHostAuthenticatorFactory() {}
scoped_ptr<Authenticator> It2MeHostAuthenticatorFactory::CreateAuthenticator(
const std::string& local_jid,
const std::string& remote_jid,
const buzz::XmlElement* first_message) {
const std::string& remote_jid) {
// Check the client domain policy.
if (!required_client_domain_.empty()) {
std::string client_username = remote_jid;
......
......@@ -32,8 +32,7 @@ class It2MeHostAuthenticatorFactory : public AuthenticatorFactory {
// AuthenticatorFactory interface.
scoped_ptr<Authenticator> CreateAuthenticator(
const std::string& local_jid,
const std::string& remote_jid,
const buzz::XmlElement* first_message) override;
const std::string& remote_jid) override;
private:
std::string local_cert_;
......
......@@ -82,8 +82,7 @@ bool JingleSessionManager::OnSignalStrategyIncomingStanza(
scoped_ptr<Authenticator> authenticator =
authenticator_factory_->CreateAuthenticator(
signal_strategy_->GetLocalJid(), message.from,
message.description->authenticator_message());
signal_strategy_->GetLocalJid(), message.from);
JingleSession* session = new JingleSession(this);
session->InitializeIncomingConnection(message, std::move(authenticator));
......
......@@ -62,16 +62,13 @@ Me2MeHostAuthenticatorFactory::CreateWithThirdPartyAuth(
return std::move(result);
}
Me2MeHostAuthenticatorFactory::Me2MeHostAuthenticatorFactory() {
}
Me2MeHostAuthenticatorFactory::Me2MeHostAuthenticatorFactory() {}
Me2MeHostAuthenticatorFactory::~Me2MeHostAuthenticatorFactory() {
}
Me2MeHostAuthenticatorFactory::~Me2MeHostAuthenticatorFactory() {}
scoped_ptr<Authenticator> Me2MeHostAuthenticatorFactory::CreateAuthenticator(
const std::string& local_jid,
const std::string& remote_jid,
const buzz::XmlElement* first_message) {
const std::string& remote_jid) {
std::string remote_jid_prefix;
......
......@@ -51,8 +51,7 @@ class Me2MeHostAuthenticatorFactory : public AuthenticatorFactory {
// AuthenticatorFactory interface.
scoped_ptr<Authenticator> CreateAuthenticator(
const std::string& local_jid,
const std::string& remote_jid,
const buzz::XmlElement* first_message) override;
const std::string& remote_jid) override;
private:
// Used for all host authenticators.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment