1. 10 Mar, 2015 13 commits
    • danakj's avatar
      base: Fix/add header #ifndef guards. · 0a44860e
      danakj authored
      Header guards should be defined based on the path and file name of the
      header file. Some headers have it wrong, some are missing the guards,
      and some just have the matching comment wrong.
      
      R=Nico
      BUG=464816
      
      Committed: https://crrev.com/301b392761fd8f66f3a701ab1dd011c6e7a55e19
      Cr-Commit-Position: refs/heads/master@{#319722}
      
      Review URL: https://codereview.chromium.org/985003004
      
      Cr-Commit-Position: refs/heads/master@{#319793}
      0a44860e
    • estade's avatar
      Android Autofill card unmasking prompt - Add tooltip · a0258781
      estade authored
      for store locally checkbox
      
      BUG=464640
      
      Review URL: https://codereview.chromium.org/990543002
      
      Cr-Commit-Position: refs/heads/master@{#319792}
      a0258781
    • ananta's avatar
      Second attempt at fixing pointer lock issues with Windows HiDPI. · ef5361d9
      ananta authored
      The earlier attempt https://codereview.chromium.org/973123003/ was incorrect. Reverted parts that patch
      which changed the WebMouseEventBuilder::Build function to convert from DIP to pixels and back. The initial
      conversion from DIP to pixels was not needed as the values are picked up from the Windows message which gives
      us these coordinates in pixels.
      
      Changes in this patch are as below:-
      1. The WebMouseEventBuilder::Build function has been changed to convert the WebMouseEvent::globalX and globalY values
         to DIP. The other changes in the earlier patch as mentioned above have been reverted.
      
      2. The RenderWidgetHostViewAura::UpdateMouseLockRegion function which executes on Windows was clipping the windows cursor
         to a rectangle in DIPs. We need to convert this rectangle to pixels before calling the ClipCursor API. This was the
         main reason for the lock operation not working correctly.
      
      3. I was seeing a DCHECK in the renderer process in the WebViewImpl::pointerLockMouseEvent function as we were sending
         the mouse leave message. Added code in the CanRendererHandleEvent function in the render_widget_host_view_aura.cc file
         to not send this message if we are in the mouse locked state.
      
      BUG=411634
      TEST= The main test case in bug 411634
      
      Review URL: https://codereview.chromium.org/981393002
      
      Cr-Commit-Position: refs/heads/master@{#319791}
      ef5361d9
    • hichris123's avatar
      Only enable the Low Box token on Windows 8 and 8.1 · b5c098bb
      hichris123 authored
      r319208 added the Low Box token to PreSpawnTarget. For some reason, this doesn't play well with Windows 10 preview builds, so this CL selectively enables the feature on Windows 8 & 8.1
      
      BUG=464779,455496
      
      Review URL: https://codereview.chromium.org/986933002
      
      Cr-Commit-Position: refs/heads/master@{#319790}
      b5c098bb
    • vollick's avatar
      Combine clips in content target space. · 67394b4d
      vollick authored
      We currently combine clips in the target space of the clip's transform
      node. This is incorrect. We want to combine clips in the space of the
      transform node's _content_ target space.
      
      BUG=386810
      
      Review URL: https://codereview.chromium.org/991013002
      
      Cr-Commit-Position: refs/heads/master@{#319789}
      67394b4d
    • dcastagna's avatar
      gpu: Run texture upload perf test with different texture formats. · ac138e5c
      dcastagna authored
      The two formats GL_LUMINANCE and GL_RED_EXT are now been tested in addition to GL_RGBA.
      GL_LUMINANCE and GL_RED_EXT are used for yuv resources that are uploaded by VideoLayerImpl.
      
      BUG=423481
      
      Review URL: https://codereview.chromium.org/974913003
      
      Cr-Commit-Position: refs/heads/master@{#319788}
      ac138e5c
    • orenb's avatar
      Add an initial implementation of the downloads MD settings page. · 61f61374
      orenb authored
      Note that the "Change" button for selecting the downloads path doesn't do
      anything meaningful yet. We still need to figure out how to call into the
      C++ layer to display the appropriate picker.
      
      BUG=464785
      
      Review URL: https://codereview.chromium.org/988783002
      
      Cr-Commit-Position: refs/heads/master@{#319787}
      61f61374
    • pkotwicz's avatar
      ash: Add missing xdisplaycheck dependency for tests · ceeb7432
      pkotwicz authored
      BUG=465344
      TEST=linux_chromium_clobber_rel_ng does not block new ash_unittests from landing
      
      Review URL: https://codereview.chromium.org/985853004
      
      Cr-Commit-Position: refs/heads/master@{#319786}
      ceeb7432
    • dgrogan's avatar
      Revert of Roll PDFium to 1e580a10fad09833552deb797128e00c50d74bce (patchset #1... · bcbfc458
      dgrogan authored
      Revert of Roll PDFium to 1e580a10fad09833552deb797128e00c50d74bce (patchset #1 id:1 of https://codereview.chromium.org/989213003/)
      
      Reason for revert:
      Broke at least Win8 GN
      
      http://build.chromium.org/p/chromium.win/builders/Win8%20GN/builds/5379/steps/compile/logs/stdio
      
      FAILED: ninja -t msvc -e environment.x86 -- E:\b\build\goma/gomacc.exe "E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86/cl.exe" /nologo /showIncludes /FC @obj/third_party/pdfium/samples/pdfium_diff.image_diff_png.obj.rsp /c ../../third_party/pdfium/samples/image_diff_png.cc /Foobj/third_party/pdfium/samples/pdfium_diff.image_diff_png.obj /Fdobj/third_party/pdfium/samples/pdfium_diff_cc.pdb
      e:\b\build\slave\win8_gn\build\src\third_party\pdfium\samples\image_diff_png.cc(246) :error C2220: warning treated as error - no 'object' file generated
      e:\b\build\slave\win8_gn\build\src\third_party\pdfium\samples\image_diff_png.cc(246) : warning C4702: unreachable code
      e:\b\build\slave\win8_gn\build\src\third_party\pdfium\samples\image_diff_png.cc(574) : warning C4702: unreachable code
      FAILED: ninja -t msvc -e environment.x86 -- E:\b\build\goma/gomacc.exe "E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86/cl.exe" /nologo /showIncludes /FC @obj/third_party/pdfium/samples/pdfium_test.image_diff_png.obj.rsp /c ../../third_party/pdfium/samples/image_diff_png.cc /Foobj/third_party/pdfium/samples/pdfium_test.image_diff_png.obj /Fdobj/third_party/pdfium/samples/pdfium_test_cc.pdb
      e:\b\build\slave\win8_gn\build\src\third_party\pdfium\samples\image_diff_png.cc(246) :error C2220: warning treated as error - no 'object' file generated
      e:\b\build\slave\win8_gn\build\src\third_party\pdfium\samples\image_diff_png.cc(246) : warning C4702: unreachable code
      e:\b\build\slave\win8_gn\build\src\third_party\pdfium\samples\image_diff_png.cc(574) : warning C4702: unreachable code
      ninja: build stopped: subcommand failed.
      
      Original issue's description:
      > Roll PDFium to 1e580a10fad09833552deb797128e00c50d74bce
      >
      > This brings in:
      > 1e580a1 Fix multiply defined macro in zlib.h on linux_chromium_clobber_rel_ng builder.
      > 0700106 Make conversions for CPDF_Link explicit.
      > 8842c62 Fix the pdfium component build.
      > 5a370d7 Make conversion between CPDF_Dest and its object explicit.
      > 7348fae Add gmock to .gitignore
      > 624b6c1 Make conversion between CPDF_Action and its dictionary explicit.
      > 61c25ee Merge to Master: Fix a compiling error in fxjs_v8.h
      > e1671bd Kill off JS_ErrorString type.
      > b720d0a Return error information from pdfium to JS.
      > 944ccad Do hit tests against Annots in reverse order.
      > 5b47dbf Remove unused IDS_ constants from pdfium.
      > 3d25502 Pull in gmock for standalone pdfium builds.
      > ec61a85 Upgrade openjpeg to revision 2997.
      > 42a8ada Implement a delegate for EmbedderTests.
      > 57e4c86 Kill off unused IFXJS interface methods.
      > 4351ac2 Fix compilation error on Windows.
      > f9cfdda Add small flate decode unit test.
      > e796478 Kill multi-byte comments in fxet_list.h
      > 23f9288 Convert pdfium expected test results to PNG format.
      > 0fd53cf Fix GN build after PNG support backport
      > ef1e85c Backport PNG output format to origin/master branch.
      >
      > BUG=445408,457493,PDFIUM:123
      >
      > Committed: https://crrev.com/608e59f9ceecd5b60ae5e50c4f0da4bc6a7f405e
      > Cr-Commit-Position: refs/heads/master@{#319781}
      
      TBR=brettw@chromium.org,thestig@chromium.org,tsepez@chromium.org
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      BUG=445408,457493,PDFIUM:123
      
      Review URL: https://codereview.chromium.org/996523002
      
      Cr-Commit-Position: refs/heads/master@{#319785}
      bcbfc458
    • bnc's avatar
      Improve code with early returns. · f5a07dab
      bnc authored
      Improve SpdyHttpUtils::GetUrlFromHeaderBlock() implementation with early
      returns.  Get rid of a number of temporary variables that were declared too far
      from where they were first used.
      
      Also remove SPDY2-specific code, as SPDY2 is no longer supported in Chromium.
      
      Acknowledgements to Daniel Bratell for suggesting to use append instead of
      inline operator+ that would create unnecessary temporary strings, see
      https://crrev.com/965773002.
      
      BUG=
      
      Review URL: https://codereview.chromium.org/996483002
      
      Cr-Commit-Position: refs/heads/master@{#319784}
      f5a07dab
    • halton.huo's avatar
      Support of specify local prebuilt network service file. · 176dd4a9
      halton.huo authored
      This change is chromium part of
      https://codereview.chromium.org/921053003/
      
      And out-of-date TODO is removed as well.
      
      TEST=
      BUG=458409
      
      Review URL: https://codereview.chromium.org/983143003
      
      Cr-Commit-Position: refs/heads/master@{#319783}
      176dd4a9
    • estade's avatar
      Autofill - more translated strings in card unmasking prompt · 0d995e6a
      estade authored
      BUG=none
      
      Review URL: https://codereview.chromium.org/983413005
      
      Cr-Commit-Position: refs/heads/master@{#319782}
      0d995e6a
    • tsepez's avatar
      Roll PDFium to 1e580a10fad09833552deb797128e00c50d74bce · 608e59f9
      tsepez authored
      This brings in:
      1e580a1 Fix multiply defined macro in zlib.h on linux_chromium_clobber_rel_ng builder.
      0700106 Make conversions for CPDF_Link explicit.
      8842c62 Fix the pdfium component build.
      5a370d7 Make conversion between CPDF_Dest and its object explicit.
      7348fae Add gmock to .gitignore
      624b6c1 Make conversion between CPDF_Action and its dictionary explicit.
      61c25ee Merge to Master: Fix a compiling error in fxjs_v8.h
      e1671bd Kill off JS_ErrorString type.
      b720d0a Return error information from pdfium to JS.
      944ccad Do hit tests against Annots in reverse order.
      5b47dbf Remove unused IDS_ constants from pdfium.
      3d25502 Pull in gmock for standalone pdfium builds.
      ec61a85 Upgrade openjpeg to revision 2997.
      42a8ada Implement a delegate for EmbedderTests.
      57e4c86 Kill off unused IFXJS interface methods.
      4351ac2 Fix compilation error on Windows.
      f9cfdda Add small flate decode unit test.
      e796478 Kill multi-byte comments in fxet_list.h
      23f9288 Convert pdfium expected test results to PNG format.
      0fd53cf Fix GN build after PNG support backport
      ef1e85c Backport PNG output format to origin/master branch.
      
      BUG=445408,457493,PDFIUM:123
      
      Review URL: https://codereview.chromium.org/989213003
      
      Cr-Commit-Position: refs/heads/master@{#319781}
      608e59f9
  2. 09 Mar, 2015 27 commits