1. 15 Sep, 2016 1 commit
  2. 19 Aug, 2016 1 commit
    • ricea's avatar
      Re-write many calls to WrapUnique() with MakeUnique() · c4bfd81c
      ricea authored
      A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
      MakeUnique<Foo>(...). See the thread at
      https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
      for background.
      
      To avoid requiring too many manual fixups, the change skips some cases that are
      frequently problematic. In particular, in methods named Foo::Method() it will
      not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
      Foo::Method() may be accessing an internal constructor of Foo.
      
      Cases where MakeUnique<NestedClass>(...) is called within a method of
      OuterClass are common but hard to detect automatically, so have been fixed-up
      manually.
      
      The only types of manual fix ups applied are:
      1) Revert MakeUnique back to WrapUnique
      2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
         correctly)
      3) Add base:: namespace qualifier where missing.
      
      WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
      change behaviour if Foo does not have a user-defined constructor. For example,
      WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
      creates an integer initialised to 0.
      
      git cl format has been been run over the CL. Spot-checking has uncovered no
      cases of mis-formatting.
      
        BUG=637812
      
      Review-Url: https://codereview.chromium.org/2255133002
      Cr-Commit-Position: refs/heads/master@{#413112}
      c4bfd81c
  3. 04 Aug, 2016 2 commits
    • altimin's avatar
      [headless] Incognito mode support. · 1ab63101
      altimin authored
      Public API:
      - Added incognito_mode flags to HeadlessBrowser::Options and
        HeadlessBrowserContext::Builder.
      
      Headless Shell:
      - Uses incognito browser context by default, switches to normal one
        when --user-data-dir flag is present.
      
      BUG=546953
      
      Review-Url: https://codereview.chromium.org/2211993002
      Cr-Commit-Position: refs/heads/master@{#409847}
      1ab63101
    • altimin's avatar
      [headless] Do not give ownership of HeadlessBrowserContext to user. · bf875c9c
      altimin authored
      Public API changes:
      - HeadlessBrowserContext::Builder::Build now returns raw pointer instead of unique_ptr. Lifetime of HeadlessBrowserContexts is managed by the browser now.
      - Added HeadlessBrowserContext::Close method to give used the option to delete HeadlessBrowserContext.
      - Added HeadlessBrowserContext::Id and HeadlessBrowser::GetBrowserContextForId methods for BrowserContext identification.
      
      Internal changes:
      - HeadlessWebContents are owned by HeadlessBrowserContext.
      - HeadlessBrowserContexts are now owned by HeadlessBrowser.
      - Instead of browser having a weak pointer to HeadlessDevToolsManagerDelegate opposite happens: HeadlessDevToolsManagerDelegate weakly references HeadlessBrowser.
      
      BUG=546953
      
      Review-Url: https://codereview.chromium.org/2210323002
      Cr-Commit-Position: refs/heads/master@{#409816}
      bf875c9c
  4. 03 Aug, 2016 1 commit
    • altimin's avatar
      [headless] · 93a0240a
      altimin authored
      Public API changes:
      
      - [incompatible] Removed default browser context from HeadlessBrowser and HeadlessBrowser::CreateWebContents methods. Now BrowserContext should be created explicitly.
      - [incompatible] ProtocolHandlers cannot be set in HeadlessBrowser::Options due to being move-only and not reusable across different BrowserContexts.
      - Added more configurable options to HeadlessBrowserContext.
      - Now user data directory can be set.
      - HeadlessBrowser::Shutdown now closes all WebContents.
      - All WebContents associated with a HeadlessBrowserContext are now deleted when user deletes a BrowserContext.
      
      Internal library changes:
      - Added HeadlessBrowserContextOptions class, allowing for more customization for BrowserContext and for fallback to default browser-wide settings from HeadlessBrowser::Options.
      - Removed SetOptionsForTesting. Now BrowserContext should be created for this purposes.
      
      Misc:
      - Made linter happy.
      
      BUG=546953,624837
      
      Review-Url: https://codereview.chromium.org/2181413002
      Cr-Commit-Position: refs/heads/master@{#409527}
      93a0240a
  5. 23 Jun, 2016 1 commit
  6. 09 Jun, 2016 1 commit
  7. 01 Jun, 2016 2 commits
  8. 31 May, 2016 1 commit
  9. 25 Apr, 2016 1 commit
  10. 22 Apr, 2016 1 commit
  11. 21 Apr, 2016 1 commit
  12. 06 Apr, 2016 1 commit
  13. 04 Apr, 2016 1 commit
  14. 15 Mar, 2016 1 commit
  15. 26 Feb, 2016 1 commit
    • skyostil's avatar
      headless: Initial headless embedder API implementation · fe116168
      skyostil authored
      This patch introduces the initial headless embedder API implementation.
      It allows the embedder to initialize a headless browsing environment and
      to navigate to a URL.
      
      We also add a headless shell application to demonstrate the use of the
      embedder API.
      
      Adapted from a patch by Alexander Timin <altimin@chromium.org>
      
      BUG=546953
      
      Review URL: https://codereview.chromium.org/1674263002
      
      Cr-Commit-Position: refs/heads/master@{#377973}
      fe116168