- 14 Nov, 2017 21 commits
-
-
Dmitry Gozman authored
This reverts commit c7497956. Reason for revert: suspected to consistently break Linux Tests (dbg). Example: https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/45886 Original change's description: > Message center cleanup: rename some classes to better reflect roles. > All mentions of "tray" should now be confined to ash. > > - MessageCenterTray => UiController > - MessageCenterTrayDelegate => UiDelegate > - (Chrome's) WebNotificationTray => MessageCenterUiDelegate > > Also remove some unnecessary includes. > > TBR=atwilson@chromium.org > > Bug: 755413 > Change-Id: Ic7774387ad313ed3ce356e5122a97dd9427699a9 > Reviewed-on: https://chromium-review.googlesource.com/758931 > Commit-Queue: Evan Stade <estade@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Drew Wilson <atwilson@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#516028} TBR=stevenjb@chromium.org,atwilson@chromium.org,dewittj@chromium.org,estade@chromium.org,rsesek@chromium.org Change-Id: Iaf1fe86a8a5e06e47dd35e3ed32ad1fa114bb260 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 755413 Reviewed-on: https://chromium-review.googlesource.com/767828Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#516121}
-
Paul Miller authored
According to https://developer.android.com/about/dashboards/index.html today, L/M have 58.1% share while N/O have 20.9% share, so adding L/M would increase log volume by ~4x. To compensate, also reduce sampling from 10% to 2%. Removing the platform check from AwFieldTrialCreator will have no effect because that's currently disabled by a flag. BUG=763551 Change-Id: I6bf28b7b73686879bec7b1c85dc8369524623d8a Reviewed-on: https://chromium-review.googlesource.com/767019Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Paul Miller <paulmiller@chromium.org> Cr-Commit-Position: refs/heads/master@{#516120}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/7af63727f058..c2eb32bad8de $ git log 7af63727f..c2eb32bad --date=short --no-merges --format='%ad %ae %s' 2017-11-13 jmadill Revert "Export angle::PlatformMethods." 2017-11-13 jmadill Use more gl::Error in IndexDataManager. 2017-11-13 jmadill Export angle::PlatformMethods. 2017-11-13 cwallez Avoid redundant BindingPointer::set in setBufferBinding Created with: roll-dep src/third_party/angle BUG=778918,778918 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I2fcabd0e3fe5a80a46f79445732bf0f47ddb6f0f Reviewed-on: https://chromium-review.googlesource.com/767034Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#516119}
-
yusukes authored
to work around b/68953603. BUG=b:68953603 TEST=try Change-Id: I631493c78bf7ce69638661591203b02aa4402bf9 Reviewed-on: https://chromium-review.googlesource.com/766653 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Cr-Commit-Position: refs/heads/master@{#516118}
-
Jun Choi authored
Fixed bug introduced from r513104 by removing report ID from serialization buffer both when reading from and writing to hid devices. Also,removed use of net::IOBuffer since U2f Hid devices are now servicified. Bug: 782825 Change-Id: I084337af2e2355a74f2a888b5164ecb9c16cc9a0 Reviewed-on: https://chromium-review.googlesource.com/765058 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#516117}
-
Philip Jägenstedt authored
Also remove orphaned selectors/OWNERS (directory moved) Change-Id: I519ae83ef049a92ada59a2c4ca458d5c8e31a850 Reviewed-on: https://chromium-review.googlesource.com/765493Reviewed-by:
Vincent Scheib <scheib@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#516116}
-
Qiang Xu authored
changes: Test failure is because chrome side doesn't do bind and set client to ash. This should go with crrev.com/c/761337, however that cl was merged before I uploaded the fix. TBR=jamescook@chromium.org Bug: 618070 Test: interactive_ui_tests saw it fixed Change-Id: I497442e71f4e3766d8f948c5889fee6871a2f1d3 Reviewed-on: https://chromium-review.googlesource.com/767731 Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Qiang(Joe) Xu <warx@chromium.org> Cr-Commit-Position: refs/heads/master@{#516115}
-
Zhiling Huang authored
This reverts commit cf285443. Reason for revert: gerrit issue 784527. The stack script hangs. Original change's description: > Multithread the process of objdump to speed up symbolization. > > When we have the more-info flag, objdump becomes the bottleneck of > symbolization as calls to objdump takes a long time. > > In this cl, I am multithreading the objdump calls, to speed up > symbolization when we have the more-info flag set as true. > > Bug: 774267 > Change-Id: I1f192e00481107555183bb9300cccc48e6d1db20 > Reviewed-on: https://chromium-review.googlesource.com/759322 > Commit-Queue: Zhiling Huang <hzl@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Reviewed-by: agrieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#515830} TBR=agrieve@chromium.org,hzl@chromium.org,jbudorick@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 774267 Change-Id: If181108109f1b6e97f439ff8aed976b1396dc6ce Reviewed-on: https://chromium-review.googlesource.com/767189Reviewed-by:
Zhiling Huang <hzl@chromium.org> Commit-Queue: Zhiling Huang <hzl@chromium.org> Cr-Commit-Position: refs/heads/master@{#516114}
-
Vladimir Levin authored
This patch ensures that we don't always go to full scale decode if an intermediate scale is available. Likewise, when we do decode to scale this would first find an available decode (even if it's the full size decode from the decode api) before trying to actually decode to scale. R=khushalsagar@chromium.org Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I7b464aa0964b2cbc5e873780d70582865085625a Reviewed-on: https://chromium-review.googlesource.com/758634 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#516113}
-
Ned Nguyen authored
Bug: 753495 Change-Id: I0121d82ce25bc037c20914b74714aec076aa8fe3 Reviewed-on: https://chromium-review.googlesource.com/763873Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#516112}
-
Dominick Ng authored
The EngagementDetails struct allows consumers to determine if a particular origin is added to home screen. The querying is equivalent to that implemented in Important Sites - both use a 10 day recency cutoff. All recently launched sites are recorded by the engagement service at the exact same time as the content setting used by the Important Sites code. This CL removes the custom querying for installed state in Important Sites and simply checks the EngagementDetails struct. BUG=711041 Change-Id: I7747f0fbd08e6912cc5966f3ced678b717114547 Reviewed-on: https://chromium-review.googlesource.com/765555Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#516111}
-
Wei-Yin Chen (陳威尹) authored
This reverts commit fa849f85. Reason for revert: downstream CL is not ready yet. Original change's description: > Chrome retrieves Browser Actions' custom item icons through resource ids > > Browser Actions will pass only the resource ids of the custom items' > icons through the Intent, instead of passing the whole Bitmaps. Then > with the source package name, Chrome can retrieve the client app's > Resources by PackageManager.getResourcesForApplication() and use it to > get the icons. > > Bug: 775798 > Change-Id: Ia63f07a6245673df63e71b550ffff2f63753964f > Reviewed-on: https://chromium-review.googlesource.com/758745 > Commit-Queue: Lei Tian <ltian@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#516036} TBR=tedchoc@chromium.org,yusufo@chromium.org,ltian@chromium.org Change-Id: Ief3ca089894435000d493ff2af37d35a8003d24e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 775798 Reviewed-on: https://chromium-review.googlesource.com/767807Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#516110}
-
Robert Sesek authored
The code was not properly checking that the length of the key string contained within the buffer. The string uses UTF-16 (two-byte) units but was treating the length as single-byte units. This switches the code to use the size-checked GetLeafData<T> wrapper. Bug: 783914 Change-Id: I4f9207532181656e4865eb4c397cae5745b5785a Reviewed-on: https://chromium-review.googlesource.com/767408Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#516109}
-
Charlie Andrews authored
TBR=kochi@chromium.org, hayato@chromium.org Bug: 780506 Change-Id: I0e014e8974011ba1c4c43cb7386e91073267e2f6 Reviewed-on: https://chromium-review.googlesource.com/767156Reviewed-by:
Charlie Andrews <charliea@chromium.org> Commit-Queue: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#516108}
-
Fady Samuel authored
In RenderWidgetHostViewMac::UpdateScreenInfo, it may follow a null |render_widget_host_| pointer at tear down. This CL adds a null check. Bug: 783547 Change-Id: Ia83c3f82ea8331c1fa52edaebc4cf88a9a1a20f3 Reviewed-on: https://chromium-review.googlesource.com/767687Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#516107}
-
Greg Thompson authored
BUG=783601 R=sky@chromium.org Change-Id: I99bebdf3bd59cde120494c1c55840f3262f87a58 Reviewed-on: https://chromium-review.googlesource.com/765829 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#516106}
-
Ryan Hamilton authored
Flip recent QUIC flags. https://chromium-review.googlesource.com/c/chromium/src/+/767009 make QuicStream::WriteMemSlices() public. Merge internal change: 175016870 https://chromium-review.googlesource.com/c/chromium/src/+/767067 In QUIC, rename ScopedPacketBundler to ScopedPacketFlusher. As generator is always in batch mode, generator is flushed only when Flush() is called. No functional change expected. Merge internal change: 174845352 https: //chromium-review.googlesource.com/c/chromium/src/+/767007 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I023f08e24946346aaf268c98fb726d0a398f1e7a Reviewed-on: https://chromium-review.googlesource.com/767031Reviewed-by:
Buck Krasic <ckrasic@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#516105}
-
Timothy Loh authored
The permission RAPPOR metrics have long been supplanted by permission action reporting metrics (via the safebrowsing service). This patch removes the RAPPOR logging which we no longer need. Bug: 605836 Change-Id: Ibdbb394a074d5c1543538a2ffab44617481d2417 Reviewed-on: https://chromium-review.googlesource.com/765561Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#516104}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c4f852d8..69801a6a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I840ed38bcc70912b1e6b0cf276de379313f50b38 Reviewed-on: https://chromium-review.googlesource.com/766513Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#516103}
-
Daniel Murphy authored
Bug: 784020 Change-Id: I973eb7cbd7067ce3a95a4ee4781f9d8aa3d54739 Reviewed-on: https://chromium-review.googlesource.com/765096Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#516102}
-
Tom Anderson authored
When Chrome uses the non-standard NewWindow action, there is a duplicated entry in GNOME shell: one is the shell's built-in new window action, and the other is Chrome's. Using new-window instead solves this issue. Also, change NewPrivateWindow to use new-private-window as well, since this is what firefox does. BUG=783963 R=thestig@chromium.org Change-Id: I9747a402358089bfa297cf32f29c50c2a1f53035 Reviewed-on: https://chromium-review.googlesource.com/764557Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#516101}
-
- 13 Nov, 2017 19 commits
-
-
James Cook authored
Several mojo interface implementation in //ash only support a single connection. For example, many interfaces exist primarily to provide a single client/delegate interface back to the browser. Replace their usage of BindingSet with Binding. Also clean up some interface overrides where a FooImpl in ash overrides both mojom::Foo and mojom::FooClient. These impl objects are not "is-a" client interface impls, so don't derive from that interface. Bug: none Test: ash_unittests, browser_tests Change-Id: Id65aadda0ad9dd74702fbf21fbb8aa307b39d9fc Reviewed-on: https://chromium-review.googlesource.com/766649 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#516100}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/9fa5036245c3..f2d490650cef $ git log 9fa503624..f2d490650 --date=short --no-merges --format='%ad %ae %s' 2017-11-13 hnakashima Remove virtual from EmbedderTest methods that are not overridden. 2017-11-13 thestig Check first page number in IsLinearizedHeaderValid(). Created with: roll-dep src/third_party/pdfium BUG=781529 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ia254f6081520caf0c3eaa7cd6167c5ef6e52bdcc Reviewed-on: https://chromium-review.googlesource.com/767013 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#516099}
-
Rune Lillesveen authored
Corrected documentation for attaching LayoutObjects to whitespace text nodes after landing crrev.com/7c44da72 Bug: 756340 Change-Id: I1ed807b170f613f6b7b7dfed50b58b121af0b564 Reviewed-on: https://chromium-review.googlesource.com/766349Reviewed-by:
nainar <nainar@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#516098}
-
Qiang Xu authored
changes: move TriggerAccessibilityAlert from AccessibilityDelegate to AccessibilityController. This is part of mash work aimed at removing AccessibilityDelegate. Bug: 618070 Test: covered by tests Change-Id: Ic5c026df5a33516e135be5edf38f6fea4cf1d9dc Reviewed-on: https://chromium-review.googlesource.com/764597 Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#516097}
-
Alexey Kozyatinskiy authored
- Promise.resolve -> Promise.then - Promise.reject -> Promise.catch R=dgozman@chromium.org Bug: chromium:778796 Change-Id: Ieca9cb08f474a600752e8ae6520a6d93452cb084 Reviewed-on: https://chromium-review.googlesource.com/767008 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#516096}
-
Michael Giuffrida authored
Tab metrics prefs should be registered by Chrome. Currently they live in the metrics component itself, which isn't Chrome-specific. The other prefs in the metrics component are related to metrics collecting/uploading. Prefs needed for tracking arbitrary features via metrics should be colocated with the classes that track them. This change also ensures we don't register these prefs on Android, where they aren't used. Bug: 720131 Change-Id: Ibaca7241b4dc2d62a8c631fe15a7774cd6fe474c Reviewed-on: https://chromium-review.googlesource.com/760402 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#516095}
-
Bence Béky authored
This is to assess if pushed responses with Vary header could be rejected (if proportion is very-very low). See public discussion at https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/5_aP_stqndw. Also add unittests. Bug: 554220 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I8c5c95fc12da056fed7f837c79419e969f991a35 Reviewed-on: https://chromium-review.googlesource.com/755093Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#516094}
-
Tom Anderson authored
This CL switches the default sysroot from Jessie to Stretch. There are no deps changes. The libstdc++ requirement is not affected because we do an in-tree build of libc++ instead. The glibc requirement is also not changed because we don't currently use any of the symbols from the newer version. BUG=751812 R=dpranke@chromium.org,thestig@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.linux:linux_arm Change-Id: I89da578852fe0f7bfd27ffc08fda99e3b4df239e Reviewed-on: https://chromium-review.googlesource.com/598737Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#516093}
-
wutao authored
When popup window, e.g. settings, in immersive fullscreen is with immersive revealed, the top view inset should be 0 otherwise in the overview mode it will clip extra part of the popup window. Bug: 778840 Test: On emulator and device. Change-Id: Id0c3ac949186101fe6dca201a133e3258cfa2454 Reviewed-on: https://chromium-review.googlesource.com/750078Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#516092}
-
Charlie Andrews authored
TBR=nednguyen@google.com, junov@chromium.org Bug: 784540 Change-Id: Ie82891952ed92ca920d2e14c42b7bc1520068310 Reviewed-on: https://chromium-review.googlesource.com/767288Reviewed-by:
Charlie Andrews <charliea@chromium.org> Commit-Queue: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#516091}
-
Dirk Pranke authored
This moves chromeos-daisy-rel and linux-chromeos-rel from 50% experiments to full members of the CQ, and removes chromeos_daisy_chromium_compile_only_ng and linux_chromium_chromeos_rel_ng (which are on tryserver.chromium.linux) from the CQ. R=jbudorick@chromium.org BUG=732531 Change-Id: I3d91014b8c1f4f1d9d91acb0f8816faa155813b3 Reviewed-on: https://chromium-review.googlesource.com/767042Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#516090}
-
Dominick Ng authored
This CL removes the domain to origin scoped migration code added for crbug.com/604612. The pref used for the migration is now cleared on startup to ensure that dead data is not retained. BUG=621398 Change-Id: I053091ae9e6e5f816a5e5ece84bd7f46882904fa Reviewed-on: https://chromium-review.googlesource.com/765554Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#516089}
-
Tarun Bansal authored
* Remove some of the leftover tamper detection code * Add an explicit callback when a new client config is fetched * Limit the use of mock config for only the tests where it is actually required * Remove the deprecated mock call to the network quality estimator Bug: 760294, 675761 Change-Id: Iaf8077e83bacca574aa6dea0ed9906f0d25d0176 Reviewed-on: https://chromium-review.googlesource.com/766072Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#516088}
-
Will Chen authored
I discovered this because animation frames weren't being executed since the test config wasn't properly replicated in the test_runner for secondary renderer. Previously in the old test harness, this worked because DevTools was the secondary window and LayoutTestDevToolsBindings observes the DevTools window and implements RenderFrameCreated. This includes a test that we previously couldn't migrate because rAF was never called. Bug: 667560 Change-Id: I286f27af3e4b87ffff368f2284a9a3b373e9b269 Reviewed-on: https://chromium-review.googlesource.com/764853 Commit-Queue: Will Chen <chenwilliam@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#516087}
-
Eugene But authored
Removed code duplication for these calls: [self loadCompleteWithSuccess:NO forNavigation:navigation]; [self loadErrorInNativeView:error navigationContext:navigationContext]; Bug: None Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie550a088fefb154c13bc0409eaf7772b1d14b4c4 Reviewed-on: https://chromium-review.googlesource.com/757823Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#516086}
-
Scott Violet authored
The FYI bot ran without any failures in browser_tests for the weekend. BUG=755272,755328 TEST=test only change Change-Id: I104e75be6c0f6edf767cb1e67eafb4514725d1c2 Reviewed-on: https://chromium-review.googlesource.com/767015Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#516085}
-
Xianzhu Wang authored
Bug: 771643 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I7258834a228a67f0adae1496fb89ebe2ed29c3f8 Reviewed-on: https://chromium-review.googlesource.com/723859 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#516084}
-
Matthew Wang authored
Needed for JS support for OpenVPN.ExtraHosts Bug=742666 TEST=Manually tested using networkingPrivate Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If0de0606074c6805311d9b299bdc5c0a3de91b19 Reviewed-on: https://chromium-review.googlesource.com/726884Reviewed-by:
Kevin Cernekee <cernekee@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Commit-Queue: Matthew Wang <matthewmwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#516083}
-
Raymond Toy authored
The test code for verifying the scaling of the FFT was totally confused (and confusing). Correct the code, and only use the promise instead of both the promise and the completion event. Bug: 783314 Test: Analyser/realtimeanalyser-fft-scaling.html Change-Id: Iecc607205c1cd0ed6e76bfa7c627907238f6a46e Reviewed-on: https://chromium-review.googlesource.com/761436Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#516082}
-