1. 09 Nov, 2017 1 commit
  2. 20 Apr, 2017 1 commit
    • tzik's avatar
      Rewrite base::Bind to base::BindOnce with base_bind_rewriters in //chrome/browser/{i,l,m,n,p,r}* · 3f7781da
      tzik authored
      This is a generated CL by a clang refactoring tool at //tools/clang/base_bind_rewriters.
      The tool rewrites base::Bind to base::BindOnce where the resulting Callback
      is immediately converted to OnceCallback.
      E.g.:
        base::PostTask(FROM_HERE, base::Bind(&Foo));
      is rewritten to:
        base::PostTask(FROM_HERE, base::BindOnce(&Foo));
      
      In terms of the behavior change after the rewrite, the OnceCallback
      implementation moves out the bound argument to the target function, unlike
      Callback.
      
      BUG=554299
      
      Review-Url: https://codereview.chromium.org/2828663002
      Cr-Commit-Position: refs/heads/master@{#466030}
      3f7781da
  3. 15 Sep, 2016 1 commit
  4. 01 Sep, 2016 1 commit
    • tzik's avatar
      Remove unneeded scoped_refptr<>::get() on method binding · 07cace49
      tzik authored
      This CL is generated by a clang tool being added by http://crrev.com/2283003002.
      scoped_refptr<>::get() on method bindings are unneeded, are a source of implicit
      raw pointer to scoped_refptr<> conversion, and make following refactoring less
      mechanical.
      This CL removes most of get() call throughout the source tree.
      
      BUG=589048
      CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
      
      Review-Url: https://codereview.chromium.org/2283373002
      Cr-Commit-Position: refs/heads/master@{#415878}
      07cace49
  5. 04 Jun, 2016 1 commit
  6. 19 Apr, 2016 2 commits
  7. 18 Apr, 2016 1 commit
  8. 26 Dec, 2015 1 commit
  9. 28 Jul, 2015 1 commit
  10. 12 Jun, 2015 1 commit
  11. 18 Mar, 2015 1 commit
  12. 24 Feb, 2015 1 commit
  13. 05 Jan, 2015 1 commit
  14. 22 Dec, 2014 1 commit
  15. 30 Oct, 2014 1 commit
    • dcheng's avatar
      Standardize usage of virtual/override/final specifiers. · e1bc798b
      dcheng authored
      The Google C++ style guide states:
      
        Explicitly annotate overrides of virtual functions or virtual
        destructors with an override or (less frequently) final specifier.
        Older (pre-C++11) code will use the virtual keyword as an inferior
        alternative annotation. For clarity, use exactly one of override,
        final, or virtual when declaring an override.
      
      To better conform to these guidelines, the following constructs have
      been rewritten:
      
      - if a base class has a virtual destructor, then:
          virtual ~Foo();                   ->  ~Foo() override;
      - virtual void Foo() override;        ->  void Foo() override;
      - virtual void Foo() override final;  ->  void Foo() final;
      
      This patch was automatically generated. The clang plugin can generate
      fixit hints, which are suggested edits when it is 100% sure it knows how
      to fix a problem. The hints from the clang plugin were applied to the
      source tree using the tool in https://codereview.chromium.org/598073004.
      
      BUG=417463
      R=jhawkins@chromium.org
      
      Review URL: https://codereview.chromium.org/684613002
      
      Cr-Commit-Position: refs/heads/master@{#301990}
      e1bc798b
  16. 07 Oct, 2014 1 commit
  17. 24 Jul, 2013 1 commit
  18. 28 May, 2013 1 commit
  19. 15 May, 2013 1 commit
  20. 24 Feb, 2013 1 commit
  21. 10 Feb, 2013 1 commit
    • brettw@chromium.org's avatar
      Merge branch 'master' into file_path_browser · 650b2d5c
      brettw@chromium.org authored
      version control markers
      
      Merge branch 'master' into file_path_browser
      
      remove version control
      
      Fix typo
      
      Merge branch 'master' into file_path_browser
      
      Conflicts:
      	chrome/browser/intents/native_services_browsertest.cc
      	chrome/browser/ui/intents/native_file_picker_service.cc
      
      Merge branch 'master' into file_path_browser
      
      Conflicts:
      	chrome/browser/chromeos/drive/drive_file_system.cc
      	chrome/browser/chromeos/drive/drive_file_system.h
      	chrome/browser/chromeos/drive/drive_file_system_interface.h
      	chrome/browser/chromeos/drive/drive_file_system_unittest.cc
      	chrome/browser/chromeos/drive/file_system/drive_operations.cc
      	chrome/browser/chromeos/login/wallpaper_manager.cc
      	chrome/browser/chromeos/login/wallpaper_manager.h
      	chrome/browser/chromeos/login/wallpaper_manager_browsertest.cc
      	chrome/browser/extensions/api/sync_file_system/extension_sync_event_observer.cc
      	chrome/browser/google_apis/gdata_wapi_operations.cc
      	chrome/browser/google_apis/gdata_wapi_operations.h
      	chrome/browser/google_apis/gdata_wapi_operations_unittest.cc
      	chrome/browser/profiles/off_the_record_profile_impl.cc
      	chrome/browser/profiles/off_the_record_profile_impl.h
      	chrome/browser/profiles/profile_impl.cc
      	chrome/browser/profiles/profile_impl.h
      	chrome/browser/profiles/profile_impl_io_data.cc
      	chrome/browser/profiles/profile_impl_io_data.h
      	chrome/browser/sync_file_system/drive_file_sync_client_unittest.cc
      	chrome/browser/ui/webui/options/manage_profile_handler.cc
      
      Long lines
      
      long lines
      
      some long lines.
      
      long lines
      
      long lines
      
      Beginning of lines.
      
      Rename FilePath -> base::FilePath in chrome/browser
      
      git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181638 0039d316-1c4b-4281-b951-d872f2087c98
      650b2d5c
  22. 07 Feb, 2013 1 commit
  23. 02 Jan, 2013 1 commit
    • gab@chromium.org's avatar
      Refactor first_run, very few things should depend on whether the First Run... · 3f002a38
      gab@chromium.org authored
      Refactor first_run, very few things should depend on whether the First Run sentinel itself was present... (i.e. most tasks should not be on if flags such as --no-first-run are present).
      
      This is a prerequisite for issue 165048 as we want to be able to launch Chrome with --no-first-run and have two guarantees:
      1) No first run tasks happen
      2) First Run sentinel is set so that first run never happens for this new Chrome.
      
      This also removes PreInteractiveFirstRunInit() and PostInteractiveFirstRunInit() from BrowserMainParts as I just realized AutoImport is now silent and it is thus no longer necessary to split this in two :)! Moved everything to first_run::PostImportTasks().
      
      This CL also buffs --first-run to --force-first-run (to be more explicit); --first-run now overrides --no-first-run as far as first run tasks are concerned (i.e. as far as everything first run related is concerned; except code that specifically looks for --no-first-run on the command line) -- kNoFirstRun used to state it would override kFirstRun, but that wasn't true anyways ans it makes more sense/is more useful the other way around.
      
      Now a browser test may specify --force-first-run and get the full first run experience even if the underlying test harness specifies --no-first-run for all tests :).
      
      --no-first-run is otherwise unaffected (i.e. same behavior as before) if --force-first-run is not present
      
      BUG=165048
      TEST=
      1) Run chrome.exe --force-first-run from build output and see First Run flow although First Run beacon is  present.
      2) Delete "First Run" beacon and ensure that chrome.exe --no-first-run both skips the first run and creates the beacon.
      3) Ensure that chrome.exe --force-first-run --no-first-run acts the same as chrome.exe --force-first-run.
      
      Review URL: https://chromiumcodereview.appspot.com/11636031
      
      git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174809 0039d316-1c4b-4281-b951-d872f2087c98
      3f002a38
  24. 16 Nov, 2012 1 commit
  25. 01 Nov, 2012 1 commit
  26. 09 Jul, 2012 1 commit
  27. 23 Apr, 2012 1 commit
  28. 11 Apr, 2012 1 commit
  29. 17 Nov, 2011 1 commit
  30. 12 Oct, 2011 1 commit
  31. 29 Jul, 2011 1 commit
  32. 26 Jul, 2011 1 commit
  33. 19 Jul, 2011 1 commit
  34. 15 Jul, 2011 1 commit
  35. 14 Jul, 2011 1 commit
  36. 19 May, 2011 1 commit
  37. 28 Mar, 2011 1 commit
    • levin@chromium.org's avatar
      Move some files from base to base/memory. · 3b63f8f4
      levin@chromium.org authored
      raw_scoped_refptr_mismatch_checker.h
      ref_counted.cc
      ref_counted.h
      ref_counted_memory.cc
      ref_counted_memory.h
      ref_counted_unittest.cc
      scoped_callback_factory.h
      scoped_comptr_win.h
      scoped_handle.h
      scoped_native_library.cc
      scoped_native_library.h
      scoped_native_library_unittest.cc
      scoped_nsobject.h
      scoped_open_process.h
      scoped_ptr.h
      scoped_ptr_unittest.cc
      scoped_temp_dir.cc
      scoped_temp_dir.h
      scoped_temp_dir_unittest.cc
      scoped_vector.h
      singleton.h
      singleton_objc.h
      singleton_unittest.cc
      linked_ptr.h
      linked_ptr_unittest.cc
      weak_ptr.cc
      weak_ptr.h
      weak_ptr_unittest.cc
      
      BUG=None
      TEST=Compile
      
      Review URL: http://codereview.chromium.org/6714032
      
      git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98
      3b63f8f4
  38. 19 Jan, 2011 1 commit
  39. 13 Jan, 2011 1 commit