1. 22 Aug, 2016 1 commit
    • ricea's avatar
      Re-write many calls to WrapUnique() with MakeUnique() · 68860bd0
      ricea authored
      A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
      MakeUnique<Foo>(...). See the thread at
      https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
      for background.
      
      To avoid requiring too many manual fixups, the change skips some cases that are
      frequently problematic. In particular, in methods named Foo::Method() it will
      not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
      Foo::Method() may be accessing an internal constructor of Foo.
      
      Cases where MakeUnique<NestedClass>(...) is called within a method of
      OuterClass are common but hard to detect automatically, so have been fixed-up
      manually.
      
      The only types of manual fix ups applied are:
      1) Revert MakeUnique back to WrapUnique
      2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
         correctly)
      3) Add base:: namespace qualifier where missing.
      
      WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
      change behaviour if Foo does not have a user-defined constructor. For example,
      WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
      creates an integer initialised to 0.
      
      git cl format has been been run over the CL. Spot-checking has uncovered no
      cases of mis-formatting.
      
        BUG=637812
      
      Review-Url: https://codereview.chromium.org/2253233004
      Cr-Commit-Position: refs/heads/master@{#413390}
      68860bd0
  2. 06 Apr, 2016 1 commit
  3. 11 Feb, 2016 1 commit
    • sergeyu's avatar
      Use UrlRequest in PortAllocator. · c3c43e87
      sergeyu authored
      PepperPortAllocator and ChromiumPortAllocator were different only in
      how they were sending HTTP requests to allocate relay session. They were
      using pp::URLLoader and net::URLFetcher respectively, but otherwise
      contained largely the same logic. Now URL request logic is abstracted
      with remoting::UrlRequest interface and so a single PortAllocator
      implementation can be used in all cases.
      
      BUG=577954
      
      Review URL: https://codereview.chromium.org/1681393006
      
      Cr-Commit-Position: refs/heads/master@{#375042}
      c3c43e87
  4. 16 Dec, 2015 1 commit
    • sergeyu's avatar
      Add TransportContext class. · 86030f38
      sergeyu authored
      The new TransportContext is now used to store all parameters required
      to initialize Transport objects and is applicable both to IceTransport
      and WebrtcTransport. It also allowed to reduce amount of boilerplate
      code when passing around these parameters.
      
      BUG=547158
      
      Review URL: https://codereview.chromium.org/1521883006
      
      Cr-Commit-Position: refs/heads/master@{#365649}
      86030f38
  5. 14 Dec, 2015 1 commit
  6. 11 Dec, 2015 2 commits
    • hans's avatar
      Revert of Removing references to webrtc::PortAllocatorFactoryInterface.... · ed698a70
      hans authored
      Revert of Removing references to webrtc::PortAllocatorFactoryInterface. (patchset #6 id:100001 of https://codereview.chromium.org/1500663003/ )
      
      Reason for revert:
      Broke the build:
      
      ../../remoting/host/remoting_me2me_host.cc:1505:9: error: no viable conversion from 'scoped_ptr<remoting::protocol::PortAllocatorFactory>' to 'rtc::scoped_refptr<webrtc::PortAllocatorFactoryInterface>'
              port_allocator_factory = protocol::ChromiumPortAllocatorFactory::Create(
              ^                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      ../../third_party/webrtc/base/scoped_ref_ptr.h:76:3: note: candidate constructor not viable: no known conversion from 'scoped_ptr<remoting::protocol::PortAllocatorFactory>' to 'webrtc::PortAllocatorFactoryInterface *' for 1st argument
        scoped_refptr(T* p) : ptr_(p) {
        ^
      ../../third_party/webrtc/base/scoped_ref_ptr.h:81:3: note: candidate constructor not viable: no known conversion from 'scoped_ptr<remoting::protocol::PortAllocatorFactory>' to 'const scoped_refptr<webrtc::PortAllocatorFactoryInterface> &' for 1st argument
        scoped_refptr(const scoped_refptr<T>& r) : ptr_(r.ptr_) {
        ^
      ../../third_party/webrtc/base/scoped_ref_ptr.h:87:3: note: candidate template ignored: could not match 'scoped_refptr' against 'scoped_ptr'
        scoped_refptr(const scoped_refptr<U>& r) : ptr_(r.get()) {
        ^
      ../../base/memory/scoped_ptr.h:378:3: note: candidate function
        operator Testable() const {
        ^
      1 error generated.
      
      From https://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg%29/builds/97032/
      
      Original issue's description:
      > Removing references to webrtc::PortAllocatorFactoryInterface.
      >
      > Now using a new CreatePeerConnection method that takes a
      > PortAllocator as input. This removes the need for some
      > boilerplate code and code duplication between webrtc and chromium.
      > It also fixes an issue with TURN candidate priorities.
      >
      > BUG=webrtc:5209
      >
      > Committed: https://crrev.com/ad868b5edf13e869e835b847078b4dcc8aa7cd0d
      > Cr-Commit-Position: refs/heads/master@{#364544}
      
      TBR=sergeyu@chromium.org,deadbeef@chromium.org
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      BUG=webrtc:5209
      
      Review URL: https://codereview.chromium.org/1514853003
      
      Cr-Commit-Position: refs/heads/master@{#364556}
      ed698a70
    • deadbeef's avatar
      Removing references to webrtc::PortAllocatorFactoryInterface. · ad868b5e
      deadbeef authored
      Now using a new CreatePeerConnection method that takes a
      PortAllocator as input. This removes the need for some
      boilerplate code and code duplication between webrtc and chromium.
      It also fixes an issue with TURN candidate priorities.
      
      BUG=webrtc:5209
      
      Review URL: https://codereview.chromium.org/1500663003
      
      Cr-Commit-Position: refs/heads/master@{#364544}
      ad868b5e
  7. 10 Nov, 2015 1 commit
  8. 06 Aug, 2014 1 commit
  9. 31 Jul, 2014 2 commits
  10. 22 Jul, 2014 1 commit