1. 28 Aug, 2017 1 commit
    • Gabriel Charette's avatar
      Fix MessageLoop and RunLoop includes via script. · 078e3664
      Gabriel Charette authored
      This is a re-run of the script used for MessageLoop @
      https://codereview.chromium.org/2876013002.
      
      And a barely tweaked version of it applied to RunLoop.
      
      TBR=fdoray@chromium.org
      
      (which includes run_loop.h) @
      
      Bug: Missing includes prevents removal of message_loop.h
      Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_site_isolation;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
      Change-Id: I37cbd887744a31ba6e34046c83d6e09624ac4a93
      https: //chromium-review.googlesource.com/c/chromium/src/+/638550
      Reviewed-on: https://chromium-review.googlesource.com/639231
      Commit-Queue: Gabriel Charette <gab@chromium.org>
      Reviewed-by: default avatarGabriel Charette <gab@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#497917}
      078e3664
  2. 13 Jun, 2017 1 commit
  3. 06 Jun, 2017 1 commit
  4. 09 May, 2017 1 commit
  5. 22 Aug, 2016 1 commit
    • ricea's avatar
      Re-write many calls to WrapUnique() with MakeUnique() · 68860bd0
      ricea authored
      A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
      MakeUnique<Foo>(...). See the thread at
      https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
      for background.
      
      To avoid requiring too many manual fixups, the change skips some cases that are
      frequently problematic. In particular, in methods named Foo::Method() it will
      not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
      Foo::Method() may be accessing an internal constructor of Foo.
      
      Cases where MakeUnique<NestedClass>(...) is called within a method of
      OuterClass are common but hard to detect automatically, so have been fixed-up
      manually.
      
      The only types of manual fix ups applied are:
      1) Revert MakeUnique back to WrapUnique
      2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
         correctly)
      3) Add base:: namespace qualifier where missing.
      
      WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
      change behaviour if Foo does not have a user-defined constructor. For example,
      WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
      creates an integer initialised to 0.
      
      git cl format has been been run over the CL. Spot-checking has uncovered no
      cases of mis-formatting.
      
        BUG=637812
      
      Review-Url: https://codereview.chromium.org/2253233004
      Cr-Commit-Position: refs/heads/master@{#413390}
      68860bd0
  6. 13 May, 2016 1 commit
  7. 06 Apr, 2016 1 commit
  8. 20 Feb, 2016 1 commit