1. 11 Apr, 2017 2 commits
  2. 04 Jan, 2017 1 commit
    • kjellander's avatar
      Add xmllite and xmpp sources to third_party/ · f0e410bf
      kjellander authored
      Add third_party/xmllite and third_party/xmpp source repos,
      which used to be located in third_party/webrtc/libjingle since
      the code is no longer used by WebRTC; only Chromium.
      
      Modifications made:
      * Include paths in jingle/ and remoting/ are updated to reflect
        the new location of xmllite and xmpp.
      * Include paths in third_party/libjingle_xmpp/xmllite and
        third_party/libjingle_xmpp/xmpp are updated to reflect the new
        absolute paths to their own headers.
      * Update previous include paths using non-absolute paths referencing
        "webrtc/libjingle/xmpp" to third_party/libjingle_xmpp/xmpp.
      * Update includes from webrtc/ to third_party/webrtc
      * Update includes of webrtc/base/logging.h to third_party/webrtc_overrides/webrtc/base/logging.h
      * Added DEPS file in each folder, to restrict includes.
      
      BUG=webrtc:5539
      
      Review-Url: https://codereview.chromium.org/2443903004
      Cr-Commit-Position: refs/heads/master@{#441371}
      f0e410bf
  3. 25 Aug, 2016 1 commit
    • fdoray's avatar
      Remove calls to deprecated MessageLoop methods on Windows and Linux. · 6ef45cf4
      fdoray authored
      This Cl removes most calls to these methods on Windows and Linux:
      - MessageLoop::PostTask
      - MessageLoop::PostDelayedTask
      - MessageLoop::ReleaseSoon
      - MessageLoop::DeleteSoon
      - MessageLoop::Run
      - MessageLoop::RunUntilIdle
      
      Also note that calls to thread->message_loop()->task_runner() have
      been replaced with thread->task_runner() (|thread| is a base::Thread).
      
      This CL was generated by running the clang-tidy checks available here
      https://crbug.com/616447#c153 on Windows and Mac and by applying a few
      manual fixes (e.g. to remove a call made from a macro in
      audio_low_latency_input_win_unittest.cc).
      
      BUG=616447
      CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
      
      Review-Url: https://codereview.chromium.org/2211473003
      Cr-Commit-Position: refs/heads/master@{#414442}
      6ef45cf4
  4. 22 Aug, 2016 1 commit
    • ricea's avatar
      Re-write many calls to WrapUnique() with MakeUnique() · 68860bd0
      ricea authored
      A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
      MakeUnique<Foo>(...). See the thread at
      https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
      for background.
      
      To avoid requiring too many manual fixups, the change skips some cases that are
      frequently problematic. In particular, in methods named Foo::Method() it will
      not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
      Foo::Method() may be accessing an internal constructor of Foo.
      
      Cases where MakeUnique<NestedClass>(...) is called within a method of
      OuterClass are common but hard to detect automatically, so have been fixed-up
      manually.
      
      The only types of manual fix ups applied are:
      1) Revert MakeUnique back to WrapUnique
      2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
         correctly)
      3) Add base:: namespace qualifier where missing.
      
      WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
      change behaviour if Foo does not have a user-defined constructor. For example,
      WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
      creates an integer initialised to 0.
      
      git cl format has been been run over the CL. Spot-checking has uncovered no
      cases of mis-formatting.
      
        BUG=637812
      
      Review-Url: https://codereview.chromium.org/2253233004
      Cr-Commit-Position: refs/heads/master@{#413390}
      68860bd0
  5. 11 May, 2016 1 commit
  6. 06 Apr, 2016 1 commit
  7. 11 Feb, 2016 1 commit
    • sergeyu's avatar
      Use UrlRequest in PortAllocator. · c3c43e87
      sergeyu authored
      PepperPortAllocator and ChromiumPortAllocator were different only in
      how they were sending HTTP requests to allocate relay session. They were
      using pp::URLLoader and net::URLFetcher respectively, but otherwise
      contained largely the same logic. Now URL request logic is abstracted
      with remoting::UrlRequest interface and so a single PortAllocator
      implementation can be used in all cases.
      
      BUG=577954
      
      Review URL: https://codereview.chromium.org/1681393006
      
      Cr-Commit-Position: refs/heads/master@{#375042}
      c3c43e87
  8. 09 Feb, 2016 1 commit
    • sergeyu's avatar
      Fix IceTransportTest.TestBrokenTransport · 785b2e72
      sergeyu authored
      Previously the test wasn't verifying what it's supposed to verify and
      was flaky, particularly on DrMemory bots. The test attemps to connect
      two IceTransport instances with settings that should prevent them from
      connecting and verifies that they fail to connect. There were two issues:
       1. NetworkSettings were not passed to IceTransport objects properly,
          so they could still connect.
       2. The test was just calling RunLoopUntilIdle() and wasn't waiting
          for transport failure, so in most cases the test would pass even if
          the transports could connect, which masked (1).
      
      Fixed both issues.
      
      BUG=585531
      
      Review URL: https://codereview.chromium.org/1687543002
      
      Cr-Commit-Position: refs/heads/master@{#374536}
      785b2e72
  9. 04 Feb, 2016 1 commit
  10. 28 Dec, 2015 1 commit
    • sergeyu's avatar
      Move ownership of Transport out of Session. · e5767602
      sergeyu authored
      Previously Session implementations were responsible for creation and
      ownership of Transport objects. Now Connection* classes own both
      Transport and Session instances. This allows to ensure that correct
      type of transport is created (i.e. WebRTC connection uses
      WebrtcTransport). It also makes it possible for the host to support
      two types of connections similtaneously (previously Ice connections
      were not working when the host was started with --enable-webrtc).
      
      Session is no longer responsible for tracking state of the Transport,
      so it doesn't need CONNECTED state anymore. Session just passes
      transport-info messages to and from transport and the Connection
      object is responsible for tracking the state of the transport.
      
      BUG=547158
      
      Review URL: https://codereview.chromium.org/1545743002
      
      Cr-Commit-Position: refs/heads/master@{#367003}
      e5767602
  11. 24 Dec, 2015 1 commit
  12. 22 Dec, 2015 2 commits
  13. 16 Dec, 2015 1 commit
    • sergeyu's avatar
      Add TransportContext class. · 86030f38
      sergeyu authored
      The new TransportContext is now used to store all parameters required
      to initialize Transport objects and is applicable both to IceTransport
      and WebrtcTransport. It also allowed to reduce amount of boilerplate
      code when passing around these parameters.
      
      BUG=547158
      
      Review URL: https://codereview.chromium.org/1521883006
      
      Cr-Commit-Position: refs/heads/master@{#365649}
      86030f38
  14. 11 Dec, 2015 1 commit