1. 06 Apr, 2016 1 commit
  2. 22 Dec, 2015 1 commit
  3. 20 Jul, 2015 1 commit
    • sergeyu's avatar
      Add P2PDatagramSocket and P2PStreamSocket interfaces. · aa22c085
      sergeyu authored
      Previously remoting code was using net::Socket and net::StreamSocket
      for datagram and stream socket. Problem is that net::StreamSocket
      interface contains a lot of methods that are not relevant for
      peer-to-peer connections in remoting. Added P2PDatagramSocket and
      P2PStreamSocket interfaces independent of net::Socket. This allowed to
      remove a lot of the redundant code needed for net::StreamSocket
      implementations. There are two new adapters required in
      SslHmacChannelAuthenticator for the SSL layer, but these won't be
      necessary after we migrate to QUIC.
      
      Review URL: https://codereview.chromium.org/1197853003
      
      Cr-Commit-Position: refs/heads/master@{#339489}
      aa22c085
  4. 21 Oct, 2014 1 commit
  5. 08 Oct, 2014 1 commit
  6. 12 Sep, 2014 1 commit
    • sergeyu's avatar
      Move PseudoTCP and channel auth out of LibjingleTransportFactory. · 9cb142f0
      sergeyu authored
      Previously TransportFactory interface was responsible for creation
      and initialization of several protocol layers, including PseudoTCP and
      authentication (TLS). Simplified it so now it only creates raw datagram
      transport channel. PseudoTcpChannelFactory is now responsible for
      setting up PseudoTcpAdapter and AuthenticatingChannelFactory takes care
      of channel authentication. Also added DatagramChannelFactory for
      Datagram channels.
      
      This change will make it possible to replace PseudoTcpChannelFactory
      with an object that creates SCTP-based channels.
      
      Also fixed a bug in SslHmacChannelAuthenticator. It wasn't working
      properly when deleted from the callback. (base::Callback objects
      shouldn't be deleted while being called because when deleted they
      also destroy reference parameters values they are holding).
      
      BUG=402993
      
      Review URL: https://codereview.chromium.org/551173004
      
      Cr-Commit-Position: refs/heads/master@{#294653}
      9cb142f0
  7. 11 Sep, 2014 2 commits
    • nasko's avatar
      Revert of Move PseudoTCP and channel auth out of LibjingleTransportFactory.... · 8a450db4
      nasko authored
      Revert of Move PseudoTCP and channel auth out of LibjingleTransportFactory. (patchset #5 id:100001 of https://codereview.chromium.org/551173004/)
      
      Reason for revert:
      Failed to compile on android builder.
      
      http://build.chromium.org/p/chromium.webkit/builders/Android%20Builder/builds/46485
      
      In file included from ../../remoting/protocol/pseudotcp_channel_factory.h:11:0,
                       from ../../remoting/protocol/pseudotcp_channel_factory.cc:5:
      ../../remoting/protocol/stream_channel_factory.h:34:41:error: 'string' in namespace 'std' does not name a type
         virtual void CreateChannel(const std::string& name,
                                               ^
      ../../remoting/protocol/stream_channel_factory.h:40:49:error: 'string' in namespace 'std' does not name a type
         virtual void CancelChannelCreation(const std::string& name) = 0;
      ...
      
      Original issue's description:
      > Move PseudoTCP and channel auth out of LibjingleTransportFactory.
      >
      > Previously TransportFactory interface was responsible for creation
      > and initialization of several protocol layers, including PseudoTCP and
      > authentication (TLS). Simplified it so now it only creates raw datagram
      > transport channel. PseudoTcpChannelFactory is now responsible for
      > setting up PseudoTcpAdapter and AuthenticatingChannelFactory takes care
      > of channel authentication. Also added DatagramChannelFactory for
      > Datagram channels.
      >
      > This change will make it possible to replace PseudoTcpChannelFactory
      > with an object that creates SCTP-based channels.
      >
      > Also fixed a bug in SslHmacChannelAuthenticator. It wasn't working
      > properly when deleted from the callback. (base::Callback objects
      > shouldn't be deleted while being called because when deleted they
      > also destroy reference parameters values they are holding).
      >
      > BUG=402993
      >
      > Committed: https://crrev.com/28d886c967e016a5d5812be43cd5916f577c2e10
      > Cr-Commit-Position: refs/heads/master@{#294474}
      
      TBR=wez@chromium.org,sergeyu@chromium.org
      NOTREECHECKS=true
      NOTRY=true
      BUG=402993
      
      Review URL: https://codereview.chromium.org/570463002
      
      Cr-Commit-Position: refs/heads/master@{#294488}
      8a450db4
    • sergeyu's avatar
      Move PseudoTCP and channel auth out of LibjingleTransportFactory. · 28d886c9
      sergeyu authored
      Previously TransportFactory interface was responsible for creation
      and initialization of several protocol layers, including PseudoTCP and
      authentication (TLS). Simplified it so now it only creates raw datagram
      transport channel. PseudoTcpChannelFactory is now responsible for
      setting up PseudoTcpAdapter and AuthenticatingChannelFactory takes care
      of channel authentication. Also added DatagramChannelFactory for
      Datagram channels.
      
      This change will make it possible to replace PseudoTcpChannelFactory
      with an object that creates SCTP-based channels.
      
      Also fixed a bug in SslHmacChannelAuthenticator. It wasn't working
      properly when deleted from the callback. (base::Callback objects
      shouldn't be deleted while being called because when deleted they
      also destroy reference parameters values they are holding).
      
      BUG=402993
      
      Review URL: https://codereview.chromium.org/551173004
      
      Cr-Commit-Position: refs/heads/master@{#294474}
      28d886c9