GitLab

BUG=n/a

Review-Url: https://codereview.chromium.org/2779763003
Cr-Commit-Position: refs/heads/master@{#460033}

BUG=None
NOTRY=true

Review-Url: https://codereview.chromium.org/2774723003
Cr-Commit-Position: refs/heads/master@{#459449}

Also includes `git cl format`, per the presubmit.

BUG=571533, 661796

Review-Url: https://codereview.chromium.org/2765733002
Cr-Commit-Position: refs/heads/master@{#458484}

BUG=

Review-Url: https://codereview.chromium.org/2765853002
Cr-Commit-Position: refs/heads/master@{#458390}

Review-Url: https://codereview.chromium.org/2759563002
Cr-Commit-Position: refs/heads/master@{#457616}

Create watchlist for directories where share test utility code
is stored. Add baxley@, huangml@, and liaoyuke@ to this list.

BUG=None

Review-Url: https://codereview.chromium.org/2751653007
Cr-Commit-Position: refs/heads/master@{#457212}

Review-Url: https://codereview.chromium.org/2749953003
Cr-Commit-Position: refs/heads/master@{#457020}

BUG=661797, 661796, 661799

Review-Url: https://codereview.chromium.org/2746663002
Cr-Commit-Position: refs/heads/master@{#456986}

Update safe_browsing WATCHLIST to include the safe_browsing
component. Also add myself to safe_browsing and
safe_browsing_db watchlists.

BUG=

Review-Url: https://codereview.chromium.org/2747853003
Cr-Commit-Position: refs/heads/master@{#456597}

Added myself to a new blink_image_capture and
removed/renamed myself from a few categories

Review-Url: https://codereview.chromium.org/2741853004
Cr-Commit-Position: refs/heads/master@{#456120}

BUG=none
R=dbeam@chromium.org

Review-Url: https://codereview.chromium.org/2732063002
Cr-Commit-Position: refs/heads/master@{#454979}

Landing this right after the M58 branch will complicate backports. I'm
going to land it right before the M59 branch.

This reverts commit 654b40da.

Original description:
Now that mustash can use standard aura windows we don't need the ash/aura
vs. ash/mus vs. ash/common distinction. Eliminate //ash/common. Also move
files in //ash/common/system/chromeos out to //ash/system because ash only
compiles on chromeos these days.

Part 3 the rest of //ash/common into //ash. The CQ cannot move all the
files at once, see https://codereview.chromium.org/2734653002/

BUG=690096
TEST=compiles, ash_unittests
TBR=oshima@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2729363002
Cr-Original-Commit-Position: refs/heads/master@{#454793}
Committed: https://chromium.googlesource.com/chromium/src/+/654b40da8d742dffec55c07907136d4c08c49c9e
Review-Url: https://codereview.chromium.org/2734733002 .
Cr-Commit-Position: refs/heads/master@{#454797}

Now that mustash can use standard aura windows we don't need the ash/aura
vs. ash/mus vs. ash/common distinction. Eliminate //ash/common. Also move
files in //ash/common/system/chromeos out to //ash/system because ash only
compiles on chromeos these days.

Part 3 the rest of //ash/common into //ash. The CQ cannot move all the
files at once, see https://codereview.chromium.org/2734653002/

BUG=690096
TEST=compiles, ash_unittests
TBR=oshima@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2729363002
Cr-Commit-Position: refs/heads/master@{#454793}

BUG=None

Review-Url: https://codereview.chromium.org/2729673002
Cr-Commit-Position: refs/heads/master@{#454646}

Introduced by: https://codereview.chromium.org/2730843002

TBR=mcasas@chromium.org

Review-Url: https://codereview.chromium.org/2727123005
Cr-Commit-Position: refs/heads/master@{#454544}

As said, adding relevant new folders and removing blink_ prefix
since it doesn't apply.

BUG=none

Review-Url: https://codereview.chromium.org/2730843002
Cr-Commit-Position: refs/heads/master@{#454515}

BUG=

Review-Url: https://codereview.chromium.org/2723223002
Cr-Commit-Position: refs/heads/master@{#454458}

Review-Url: https://codereview.chromium.org/2724443005
Cr-Commit-Position: refs/heads/master@{#453675}

The Android Studio Style configuration does not match the checkstyle
configuration, which causes import order to be wrong. The configuration
is specified here:
//tools/android/checkstyle/chromium-style-5.0.xml
under ImportOrder.

This CL copies the style configuration from the Android repository,
but changes it so that it matches what we have in checkstyle.

It also updates the Android Studio documentation to point to the
new file, and adds the new content and the documentation to the
watchlist for Android Studio in addition to updating the error message
from checkstyle to now refer to the new style file.

BUG=None

Review-Url: https://codereview.chromium.org/2710573004
Cr-Commit-Position: refs/heads/master@{#453542}

BUG=None

Review-Url: https://codereview.chromium.org/2714293002
Cr-Commit-Position: refs/heads/master@{#453266}

BUG=None
TBR=slangley@chromium.org

Review-Url: https://codereview.chromium.org/2720503004
Cr-Commit-Position: refs/heads/master@{#453131}

Review-Url: https://codereview.chromium.org/2709973003
Cr-Commit-Position: refs/heads/master@{#452158}

BUG=None
TEST=python ../depot_tools/watchlists.py chrome/browser/chromeos/app_mode/arc/arc_kiosk_app_service.cc

Review-Url: https://codereview.chromium.org/2706753003
Cr-Commit-Position: refs/heads/master@{#451779}

BUG=

Review-Url: https://codereview.chromium.org/2708923002
Cr-Commit-Position: refs/heads/master@{#451764}

BUG=

Review-Url: https://codereview.chromium.org/2693413004
Cr-Commit-Position: refs/heads/master@{#451551}

BUG=None

Review-Url: https://codereview.chromium.org/2695983002
Cr-Commit-Position: refs/heads/master@{#451227}

fmalita+watch@, to facilitate filtering.

TBR=

Review-Url: https://codereview.chromium.org/2702483004
Cr-Commit-Position: refs/heads/master@{#451224}

BUG=None

Review-Url: https://codereview.chromium.org/2697813003
Cr-Commit-Position: refs/heads/master@{#451223}

The CL https://codereview.chromium.org/2698043006 added a watchlist
entry for changes related to Android Studio.

This CL adds more users to this watchlist.

BUG=None

Review-Url: https://codereview.chromium.org/2697393002
Cr-Commit-Position: refs/heads/master@{#451135}

BUG=620034

Review-Url: https://codereview.chromium.org/2698043006
Cr-Commit-Position: refs/heads/master@{#451090}

We, goma team, are tracking CQ compile time, so when the set
of CQ builders are updated, we'd like to detect it.

BUG=

Review-Url: https://codereview.chromium.org/2696383002
Cr-Commit-Position: refs/heads/master@{#450915}

They are not parts of DOM. https://www.w3.org/TR/orientation-event/ defines
them.  So they should be moved to LayoutTests/orientation-event/.

This CL has no behavior changes.

BUG=685886
R=timvolodine@chromium.org

Review-Url: https://codereview.chromium.org/2677603003
Cr-Commit-Position: refs/heads/master@{#449114}

BUG=

Review-Url: https://codereview.chromium.org/2679943002
Cr-Commit-Position: refs/heads/master@{#448610}

Also add subresource-filter-reviews@ to this new watchlist.

BUG=None

Review-Url: https://codereview.chromium.org/2681653003
Cr-Commit-Position: refs/heads/master@{#448603}

Geolocation API isn't a part of DOM.
This CL has no behavior changes.

BUG=685886
R=mvanouwerkerk@chromium.org

Review-Url: https://codereview.chromium.org/2671933003
Cr-Commit-Position: refs/heads/master@{#448422}

BUG=677672

Review-Url: https://codereview.chromium.org/2672093003
Cr-Commit-Position: refs/heads/master@{#448235}

I don't really need them any more as I'm not only qualified OWNER :).

TBR=qyearsley@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2660763002
Cr-Commit-Position: refs/heads/master@{#446927}

BUG=n/a

Review-Url: https://codereview.chromium.org/2660433003
Cr-Commit-Position: refs/heads/master@{#446611}

Review-Url: https://codereview.chromium.org/2658893002
Cr-Commit-Position: refs/heads/master@{#446552}

The `services` directory contains exactly one child directory.

BUG=

Review-Url: https://codereview.chromium.org/2657823005
Cr-Commit-Position: refs/heads/master@{#446509}