1. 06 Nov, 2015 1 commit
  2. 11 Jul, 2012 1 commit
  3. 16 May, 2012 1 commit
  4. 15 May, 2012 1 commit
    • thakis@chromium.org's avatar
      Change the way _EXPORT macros look. · b387864d
      thakis@chromium.org authored
      With the current setup, if you have a header file my_class.h
      
      class BASE_EXPORT MyClass {
       public:
        void MyInlineMethod() { /* do stuff, inline */ }
      };
      
      then every cc file that includes my_class.h will have a public symbol
      for MyInlineMethod (because inline methods need to be emitted to
      every translation unit, and the linker sorts them out). With the
      components build, the linker can't decide to drop these inline methods,
      so every .so that uses this header file will have the same public symbol.
      
      With this proposed change, the symbol will only be visible in the target
      the header file belongs to, and it will be hidden in all other components.
      That's cleaner, and it also prevents accident hidden dependencies (say
      target A depends on B, and B depends on C. A accidentally uses an inline
      function from a class in C. With this change, that would result in a linker
      error, and an explicit dependency from A on C would have to be added).
      
      Also add a missing CHROMEOS_IMPLEMENTATION define which went
      unnoticed until now.
      
      BUG=90078
      TEST=Things still build.
      TBR=ben, tony, viettrungluu, thestig, agl, willchan
      
      Review URL: https://chromiumcodereview.appspot.com/10386108
      
      git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137130 0039d316-1c4b-4281-b951-d872f2087c98
      b387864d
  5. 05 Aug, 2011 1 commit
  6. 19 Jul, 2011 1 commit
  7. 13 Jul, 2011 3 commits
  8. 30 Jun, 2011 1 commit
  9. 29 Apr, 2011 1 commit
  10. 28 Mar, 2011 1 commit
  11. 22 Mar, 2011 1 commit