1. 29 Jun, 2016 2 commits
    • fdoray's avatar
      Don't use ::GetFileVersionInfo() in CreateFileVersionInfoForModule() · 5b7de9e9
      fdoray authored
      Currently, base::FileVersionInfo::CreateFileVersionInfoForModule()
      calls ::GetModuleFileName and ::GetFileVersionInfo, grabs the loader
      lock and potentially touches the disk to obtain the VS_VERSION_INFO
      of the module. This is gratuitous for a module that is already loaded.
      
      With this CL, base::FileVersionInfo::CreateFileVersionInfoForModule()
      uses base::win::GetResourceFromModule() to get the VS_VERSION_INFO
      resource from memory.
      
      First version of this CL: https://codereview.chromium.org/2046583002/
      
      TBR=thestig@chromium.org
      BUG=609709
      
      Review-Url: https://codereview.chromium.org/2111613002
      Cr-Commit-Position: refs/heads/master@{#402985}
      5b7de9e9
    • petewil's avatar
      Revert of Don't use ::GetFileVersionInfo() in CreateFileVersionInfoForModule()... · d916fc3b
      petewil authored
      Revert of Don't use ::GetFileVersionInfo() in CreateFileVersionInfoForModule() (patchset #13 id:240001 of https://codereview.chromium.org/2046583002/ )
      
      Reason for revert:
      Sheriff reverting on suspicion of causing the Win x64 build to fail:
      https://build.chromium.org/p/chromium/builders/Win%20x64/builds/1995
      
      From the log:
      FAILED: obj/base/base.file_version_info_win.obj
      ninja -t msvc -e environment.x64 -- C:\b\build\slave\cache\cipd\goma/gomacc "C:\b\depot_tools\win_toolchain\vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC @obj\base\base.file_version_info_win.obj.rsp /c ..\..\base\file_version_info_win.cc /Foobj\base\base.file_version_info_win.obj /Fdobj\base\base.cc.pdb
      c:\b\build\slave\win_x64\build\src\base\file_version_info_win.cc(81): error C2220: warning treated as error - no 'object' file generated
      c:\b\build\slave\win_x64\build\src\base\file_version_info_win.cc(81): warning C4267: 'argument': conversion from 'size_t' to 'DWORD', possible loss of data
      [8341/32887] CXX obj\base\threading\base.thread_collision_warner.obj
      
      Original issue's description:
      > Don't use ::GetFileVersionInfo() in CreateFileVersionInfoForModule()
      >
      > Currently, base::FileVersionInfo::CreateFileVersionInfoForModule()
      > calls ::GetModuleFileName and ::GetFileVersionInfo, grabs the loader
      > lock and potentially touches the disk to obtain the VS_VERSION_INFO
      > of the module. This is gratuitous for a module that is already loaded.
      >
      > With this CL, base::FileVersionInfo::CreateFileVersionInfoForModule()
      > uses base::win::GetResourceFromModule() to get the VS_VERSION_INFO
      > resource from memory.
      >
      > BUG=609709
      >
      > Committed: https://crrev.com/f177a678814f97f0b35bd6aa678c1cf885ad1656
      > Cr-Commit-Position: refs/heads/master@{#402549}
      
      TBR=grt@chromium.org,thestig@chromium.org,fdoray@chromium.org
      # Skipping CQ checks because original CL landed less than 1 days ago.
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      BUG=609709
      
      Review-Url: https://codereview.chromium.org/2102363002
      Cr-Commit-Position: refs/heads/master@{#402616}
      d916fc3b
  2. 28 Jun, 2016 1 commit
    • fdoray's avatar
      Don't use ::GetFileVersionInfo() in CreateFileVersionInfoForModule() · f177a678
      fdoray authored
      Currently, base::FileVersionInfo::CreateFileVersionInfoForModule()
      calls ::GetModuleFileName and ::GetFileVersionInfo, grabs the loader
      lock and potentially touches the disk to obtain the VS_VERSION_INFO
      of the module. This is gratuitous for a module that is already loaded.
      
      With this CL, base::FileVersionInfo::CreateFileVersionInfoForModule()
      uses base::win::GetResourceFromModule() to get the VS_VERSION_INFO
      resource from memory.
      
      BUG=609709
      
      Review-Url: https://codereview.chromium.org/2046583002
      Cr-Commit-Position: refs/heads/master@{#402549}
      f177a678
  3. 26 Dec, 2015 1 commit
  4. 10 Dec, 2015 1 commit
    • thakis's avatar
      clang/win: Let some chromium_code targets build with -Wextra. · 9230c1d2
      thakis authored
      To make warning flags between Windows and non-Windows clang consistent,
      I'd like to build chromium_code targets with -Wextra enabled.  This fixes
      -Wextra warnings in about 14k of 31k build steps.
      
      Most of the warnings were about signed/unsigned mismatches; some were about
      "const"s that had no effect.
      
      (This CL does not contain the change to actually turn on -Wextra, only
      cleanups.)
      
      BUG=567877
      TBR=content/common/sandbox
      
      Review URL: https://codereview.chromium.org/1507413003
      
      Cr-Commit-Position: refs/heads/master@{#364232}
      9230c1d2
  5. 06 Nov, 2014 1 commit
  6. 01 Oct, 2014 1 commit
  7. 30 Dec, 2013 1 commit
  8. 24 Feb, 2013 1 commit
  9. 18 Feb, 2013 1 commit
  10. 19 Jul, 2011 1 commit
  11. 22 Apr, 2011 1 commit
  12. 07 Apr, 2011 3 commits
  13. 01 Jan, 2011 1 commit
  14. 23 Dec, 2010 1 commit
  15. 04 Nov, 2010 1 commit
  16. 03 Nov, 2010 2 commits
  17. 14 Apr, 2010 1 commit
  18. 09 Sep, 2009 1 commit
  19. 03 Jun, 2009 1 commit
  20. 10 Mar, 2009 1 commit
  21. 23 Dec, 2008 1 commit
  22. 24 Aug, 2008 1 commit
  23. 14 Aug, 2008 1 commit
  24. 26 Jul, 2008 1 commit