1. 26 Apr, 2017 2 commits
  2. 25 Apr, 2017 10 commits
  3. 24 Apr, 2017 5 commits
  4. 22 Apr, 2017 2 commits
  5. 21 Apr, 2017 4 commits
  6. 20 Apr, 2017 6 commits
  7. 19 Apr, 2017 7 commits
    • paulmiller's avatar
      Get Proguard flags from GMS clients (upstream part) · 3278d07f
      paulmiller authored
      Update the GMS preprocessing script to enumerate the proguard files that
      come with the client libs, and put them in a generated .gni file. Use
      the generated file to pull in the recommended flags, and remove them
      from apk_proguard.flags. This will preclude some human error in the GMS
      roll process.
      
      In v9, each GMS client has its own proguard.txt file, with common flags
      duplicated accross clients. In v10, most clients don't have their own
      proguard.txt, with common flags only in the "basement" client.
      
      BUG=708349
      
      Review-Url: https://codereview.chromium.org/2827793005
      Cr-Commit-Position: refs/heads/master@{#465814}
      3278d07f
    • brucedawson's avatar
      Copy dbghelp.dll to output directory · 6db4113f
      brucedawson authored
      Chrome's tests sometimes symbolize call stacks. In order to support new
      PDB formats such as PDB's generated by VS 2017's updated /debug:fastlink
      we need to use a recent version of dbghelp.dll. This change restores a
      modified version of _CopyDebugger that was removed a few weeks ago, thus
      avoiding a CPU busy hang in the system version of dbghelp.dll.
      
      R=jochen@chromium.org
      BUG=712905
      
      Review-Url: https://codereview.chromium.org/2834513003
      Cr-Commit-Position: refs/heads/master@{#465784}
      6db4113f
    • thakis's avatar
      Get rid of LASTCHANGE.blink · 69e2570d
      thakis authored
      Now that blink lives in the src repo, there's no need to generate a
      separate LASTCHANGE file for it.
      
      The LASTCHANGE line makes it into the user agent. LASTCHANGE.blink
      used --git-hash-only to only have the git hash in there.  Remove
      that now-unused flag and use version.py's -e flag to get the same
      effect for webkit_version.h
      
      Reverts parts of https://chromiumcodereview.appspot.com/14973005/
      No intended behavior change.
      
      BUG=none
      
      Review-Url: https://codereview.chromium.org/1982423002
      Cr-Commit-Position: refs/heads/master@{#465739}
      69e2570d
    • mark's avatar
      Update Crashpad to f487da4ff2c47a129e2f8f3a7e0c769b54e4585f · e6724112
      mark authored
      ffe4c1018c1b net: Update Blink source code references
      e04194afd91d win: Wrap TerminateProcess() to accept cdecl patches on x86
      74fddc3fed2a win: Wrap test::ChildLauncher::Start() in
                   ASSERT_NO_FATAL_FAILURE()
      f487da4ff2c4 win handler: Move test targets to handler_test.gyp
      
      BUG=crashpad:179
      
      Review-Url: https://codereview.chromium.org/2833533003
      Cr-Commit-Position: refs/heads/master@{#465723}
      e6724112
    • wnwen's avatar
      Android: Add module "_all" for Android Studio · 03427bcc
      wnwen authored
      Adding all sources to a "_all" pseudo module fixes Studio's code analysis
      functions (imports, refactoring).
      
      In order to have things build properly in gradle, the "_all" module has
      all sources excluded (gradle applies the filters, studio does not).
      
      Also fix "--all" targets to include tests. Make it easier to make sweeping
      java refactors in Android Studio.
      
      BUG=620034
      
      Review-Url: https://codereview.chromium.org/2812133003
      Cr-Commit-Position: refs/heads/master@{#465700}
      03427bcc
    • sebmarchand's avatar
      Remove Speedometer from the PGO training set. · aa335b32
      sebmarchand authored
      This benchmark has been failing (timing out) for months now, so removing it won't affect the performance.
      
      The issue seem to be that Speedometer takes a while to tun, and it's much slower in a PGI build, so we timeout after 10 minutes and at this
      point the benchmark is still running. We could increase the timeout
      but as mentioned above this has been failing for months and we haven't noticed a performance regression.
      
      BUG=650432
      
      Review-Url: https://codereview.chromium.org/2814103003
      Cr-Commit-Position: refs/heads/master@{#465682}
      aa335b32
    • sakal's avatar
      Change dummy package name so it doesn't include a reserved word. · 7acdbdd5
      sakal authored
      Using dummy.package as a package name causes problems in Android Studio
      2.3.
      
      BUG=webrtc:7498, 700438
      
      Review-Url: https://codereview.chromium.org/2827923002
      Cr-Commit-Position: refs/heads/master@{#465624}
      7acdbdd5
  8. 18 Apr, 2017 1 commit
    • mark's avatar
      Update Crashpad to b8aaa22905308cc400f880006a84dddac834bd6b · 22d1fa7c
      mark authored
      bc7c6e235d64 mac: Prevent the same report from being uploaded multiple
                   times
      5d07d81458dc Fix Doxygen warnings after 30385d4e4772
      2ec34e32c2f4 linux: Support 4.10 format for empty Groups: lines in
                   /proc/pid/status
      8297b19a5e85 Don’t attempt to do periodic tasks in a secondary
                   crashpad_handler
      c64fd3f9b4d5 Update mini_chromium to dc3d480305b2
      ddcc74f08f4f mac: Tolerate dead names for reply ports in the exception
                   handler server
      b8aaa2290530 mac handler: Record a file-limits annotation (temporarily)
      
      BUG=crashpad:30,crashpad:143,crashpad:167,crashpad:180
      
      Review-Url: https://codereview.chromium.org/2825103002
      Cr-Commit-Position: refs/heads/master@{#465308}
      22d1fa7c
  9. 17 Apr, 2017 3 commits
    • estevenson's avatar
      Android: update patch size reference APKs for m59. · fb11d048
      estevenson authored
      Also change the CURRENT_MILESTONE to 59 and make the docs a little
      easier to follow.
      
      BUG=
      TBR=agrieve@chromium.org
      
      Review-Url: https://codereview.chromium.org/2820163003
      Cr-Commit-Position: refs/heads/master@{#465039}
      fb11d048
    • alexmos's avatar
      Revert of (Reland) Expose resources in Robolectric/JUnit tests. (patchset #2... · 3781c029
      alexmos authored
      Revert of (Reland) Expose resources in Robolectric/JUnit tests. (patchset #2 id:20001 of https://codereview.chromium.org/2819983002/ )
      
      Reason for revert:
      Appears to be breaking chrome_junit_tests: https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/40695
      
      Stack trace from failed tests:
      android.content.res.Resources$NotFoundException: Resource ID #0x7f0a0153
      	at android.content.res.ResourcesImpl.getValue(ResourcesImpl.java:190)
      	at android.content.res.Resources.getDimensionPixelSize(Resources.java:667)
      	at org.chromium.chrome.browser.suggestions.TileGroup.<init>(TileGroup.java:192)
      	at org.chromium.chrome.browser.suggestions.TileGroupTest.testReceiveNewTilesWithoutChanges(TileGroupTest.java:110)
      	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
      	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
      	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:52)
      	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
      	at org.robolectric.RobolectricTestRunner$HelperTestRunner$1.evaluate(RobolectricTestRunner.java:515)
      	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
      	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
      	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
      	at org.robolectric.RobolectricTestRunner$2.evaluate(RobolectricTestRunner.java:316)
      	at org.robolectric.RobolectricTestRunner.runChild(RobolectricTestRunner.java:236)
      	at org.robolectric.RobolectricTestRunner.runChild(RobolectricTestRunner.java:41)
      	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
      	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
      	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
      	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
      	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
      	at org.robolectric.RobolectricTestRunner$1.evaluate(RobolectricTestRunner.java:176)
      	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
      	at org.chromium.testing.local.GtestComputer$GtestSuiteRunner.run(GtestComputer.java:46)
      	at org.junit.runners.Suite.runChild(Suite.java:128)
      	at org.junit.runners.Suite.runChild(Suite.java:27)
      	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
      	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
      	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
      	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
      	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
      	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
      	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
      	at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
      	at org.chromium.testing.local.JunitTestMain.main(JunitTestMain.java:105)
      
      Original issue's description:
      > (Reland) Expose resources in Robolectric/JUnit tests.
      >
      > Will let people use Android resources in Robolectric tests.
      > To use, specify package_name GN variable in junit_binary
      > targets with your apps package name.
      >
      > This change will also (basically) require that you use the
      > generated wrappers from out_dir/bin/run_<suite name> to run
      > the tests since GN will be generating many arguments to
      > pass along to the test runner.
      >
      > BUG=693573
      >
      > Review-Url: https://codereview.chromium.org/2819983002
      > Cr-Commit-Position: refs/heads/master@{#464973}
      > Committed: https://chromium.googlesource.com/chromium/src/+/30bba37e58b51483b1ec77bc3f697deb8e4033c1
      
      TBR=jbudorick@chromium.org,nyquist@chromium.org,mikecase@chromium.org
      # Skipping CQ checks because original CL landed less than 1 days ago.
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      BUG=693573
      
      Review-Url: https://codereview.chromium.org/2824863002
      Cr-Commit-Position: refs/heads/master@{#465027}
      3781c029
    • mikecase's avatar
      (Reland) Expose resources in Robolectric/JUnit tests. · 30bba37e
      mikecase authored
      Will let people use Android resources in Robolectric tests.
      To use, specify package_name GN variable in junit_binary
      targets with your apps package name.
      
      This change will also (basically) require that you use the
      generated wrappers from out_dir/bin/run_<suite name> to run
      the tests since GN will be generating many arguments to
      pass along to the test runner.
      
      BUG=693573
      
      Review-Url: https://codereview.chromium.org/2819983002
      Cr-Commit-Position: refs/heads/master@{#464973}
      30bba37e