1. 03 May, 2016 1 commit
    • brettw's avatar
      GN: forward_variables_from shouldn't clobber vars. · 0785c950
      brettw authored
      The documentation for forward_variables_from specifies that it will give an error if the variable already exists in the target scope. But this was not implemented. Instead, the value would be silently overwritten.
      This change implements the error, and fixes the times this happens in the Linux and Android builds.
      Review-Url: https://codereview.chromium.org/1943583002
      Cr-Commit-Position: refs/heads/master@{#391136}
  2. 03 Sep, 2015 1 commit
  3. 20 Feb, 2015 1 commit
    • dpranke's avatar
      Update Chomium's build files to work w/ latest GN binaries. · 4327621a
      dpranke authored
      The latest GN binaries rename cpu_arch to current_cpu and/or target_cpu
      as appropriate, build_cpu_arch to host_cpu, and os to current_os and target_os as appropriate.
      Review URL: https://codereview.chromium.org/913373002
      Cr-Commit-Position: refs/heads/master@{#317223}
  4. 02 Dec, 2014 1 commit
    • scottmg's avatar
      gn format //build · b199254f
      scottmg authored
      A starting point for doing all of src, and adding a PRESUBMIT.
      Includes https://codereview.chromium.org/772663002/ and https://codereview.chromium.org/770053002/.
      I haven't pushed new binaries yet.
      Generated via:
      > cd build
      > git ls-files *.gn *.gni | sed -e "s/^/@..\\\\out\\\\Debug\\\\gn format --in-place /" >x.bat && x.bat
      The only things that I don't love in the current output are:
      1. Turning
          args = [
            "--depfile", rebase_path(depfile, root_build_dir),
            "--android-sdk-tools", rebased_android_sdk_build_tools,
            "--dex-path", rebased_output,
          args = [
            rebase_path(depfile, root_build_dir),
      The heuristic for this isn't trivial though, and it also affects e.g. '-Xclang' in cflags, as well
      as assignments to temporaries that are later assigned to args.
      2. Turning single line
          if (defined(invoker.inputs)) { inputs = invoker.inputs }
          if (defined(invoker.inputs)) {
            inputs = invoker.inputs
      This could be argued to be an improvement, but as it's very boilerplate-y perhaps an exception to
      allow single line in this case is worthwhile. I think there was discussion of new syntax for this
      case too, something like "inputs ?= invoker.inputs" maybe.
      In both cases, I think it's worthwhile to get formatting turned on, and then go back and special
      case these if we decide it's worthwhile.
      Review URL: https://codereview.chromium.org/766573003
      Cr-Commit-Position: refs/heads/master@{#306305}
  5. 02 Sep, 2014 1 commit
  6. 28 Aug, 2014 1 commit
    • Brett Wilson's avatar
      Fix compiled action dependencies in GN. · 4b04efb4
      Brett Wilson authored
      The yasm uses of compiled action used sources instead of inputs. Sources applies to the _foreach version but not the plain "compiled_action". These did not trigger an unused variable warning because the declarations themselves dereferenced the sources variable for computing args to the script.
      This adds some extra documentation and assertion to the compiled action template. It also adds the binary itself as an input. This should be strictly unnecessary since there should be an implicit dependency on the target, but I like this since it makes things more explicit.
      Review URL: https://codereview.chromium.org/505403002
      Cr-Commit-Position: refs/heads/master@{#292447}
  7. 09 Jul, 2014 1 commit
  8. 12 Jun, 2014 1 commit
    • brettw@chromium.org's avatar
      Add yasm to the GN build. · 137dff6d
      brettw@chromium.org authored
      This is forked off of https://codereview.chromium.org/266613002 The code to compile yasm itself is mostly from that patch, with a few updates for the other changes.
      Adds a template for running compiled binaries. Compared to Albert's patch above, this assumes the binary is generated by the source tree so can have a cleaner interface (just specify the label of the tool you use).
      The yasm rule is new compared to Albert's patch. It uses a special wrapper script instead of the new compiled_action templates so it can properly support depfiles. This also adds convenient support for defines and include dirs.
      This adds some trivial ios changes to the content/public/browser. This should be a NOP now.
      Fixes a bug in GN depfile creation. Previously, the .d file was emitted as an output of the script, but this confuses ninja. This change just removes that.
      Review URL: https://codereview.chromium.org/321323004
      git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276772 0039d316-1c4b-4281-b951-d872f2087c98