- 06 Mar, 2017 1 commit
-
-
michaeldo authored
TBR=cmasso@chromium.org BUG=none Review-Url: https://codereview.chromium.org/2731293003 Cr-Commit-Position: refs/heads/master@{#454972}
-
- 23 Feb, 2017 1 commit
-
-
sdefresne authored
Document how to build Chromium for devices, how to configure the Code Signing Identity to use and which Mobile Provisioning Profile are required to build Chromium and the tests for device. BUG=694604 Review-Url: https://codereview.chromium.org/2712513003 Cr-Commit-Position: refs/heads/master@{#452459}
-
- 22 Dec, 2016 1 commit
-
-
srikanthg authored
BUG= Review-Url: https://codereview.chromium.org/2595233004 Cr-Commit-Position: refs/heads/master@{#440517}
-
- 21 Dec, 2016 1 commit
-
-
rohitrao authored
BUG=None Review-Url: https://codereview.chromium.org/2597573003 Cr-Commit-Position: refs/heads/master@{#440209}
-
- 06 Dec, 2016 1 commit
-
-
xiaoyin.l authored
Since almost all Google domains support HTTPS, and it is a good practice to use HTTPS wherever possible, thus in this patch, I changed most HTTP links to https whose domains are known to support HTTPS well. Modifications are generated by running these commands in src/docs directory: sed -i 's/http:\/\/www.chromium.org/https:\/\/www.chromium.org/g' *.md sed -i 's/http:\/\/developer.android.com/https:\/\/developer.android.com/g' *.md sed -i 's/http:\/\/dev.chromium.org/https:\/\/dev.chromium.org/g' *.md sed -i 's/http:\/\/build.chromium.org/https:\/\/build.chromium.org/g' *.md sed -i 's/http:\/\/src.chromium.org/https:\/\/src.chromium.org/g' *.md sed -i 's/http:\/\/crbug.com/https:\/\/crbug.com/g' *.md sed -i 's/http:\/\/groups.google.com/https:\/\/groups.google.com/g' *.md sed -i 's/http:\/\/cs.chromium.org/https:\/\/cs.chromium.org/g' *.md sed -i 's/http:\/\/codereview.chromium.org/https:\/\/codereview.chromium.org/g' *.md BUG= Review-Url: https://codereview.chromium.org/2545363002 Cr-Commit-Position: refs/heads/master@{#436501}
-
- 02 Dec, 2016 1 commit
-
-
dpranke authored
It looks like the new instructions are reasonably good, so I think we can remove the old ones now. R=thakis@chromium.org BUG=670518 Review-Url: https://codereview.chromium.org/2544963002 Cr-Commit-Position: refs/heads/master@{#435817}
-
- 01 Dec, 2016 2 commits
-
-
dpranke authored
This picks up various fixes noted by scottmg@chromium.org, thakis@chromium.org, and Twitter user @florpelier, as well as a few more things I wanted to clean up. R=scottmg@chromium.org, thakis@chromium.org, sdy@chromium.org BUG= Review-Url: https://codereview.chromium.org/2543503004 Cr-Commit-Position: refs/heads/master@{#435533}
-
sdy authored
- Standardize on fenced code blocks, add 'shell' where appropriate. - Add '$' to shell commands where missing. - Add `code` marks to more identifiers. - Minor stylistic/grammatical suggestions. R=dpranke@chromium.org, teresam@google.com Review-Url: https://codereview.chromium.org/2536723008 Cr-Commit-Position: refs/heads/master@{#435508}
-
- 30 Nov, 2016 1 commit
-
-
dpranke authored
We have lots of inconsistencies between the different platforms in the public instructions, and between the public instructions and the internal instructions. This CL (along with an internal one) should clean everything up. TBR=teresam@google.com, sdy@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2526563003 Cr-Commit-Position: refs/heads/master@{#435138}
-
- 19 Sep, 2016 1 commit
-
-
sdefresne authored
Upstream some scripts used to simplify the setup of a new Chromium on iOS checkout and update the instruction to remove obsolete informations, and add recommendation to use the script. BUG=None Review-Url: https://codereview.chromium.org/2343853002 Cr-Commit-Position: refs/heads/master@{#419422}
-
- 28 Apr, 2016 1 commit
-
-
patricialor authored
Review-Url: https://codereview.chromium.org/1904773003 Cr-Commit-Position: refs/heads/master@{#390250}
-
- 17 Mar, 2016 1 commit
-
-
tfarina authored
According to the style guide a nested codeblock within a list, which is the case we are changing here, should be indented, otherwise it will break the numbering of the list, like it is now. Without this indentation the numbering looks like: 1., 2., 1.. But that is just wrong, and should be 1., 2., 3.. The indentation should restore the right numbering here. https://github.com/google/styleguide/blob/gh-pages/docguide/style.md#nest-codeblocks-within-lists BUG=None R=sdefresne@chromium.org Review URL: https://codereview.chromium.org/1811613003 Cr-Commit-Position: refs/heads/master@{#381742}
-
- 08 Mar, 2016 1 commit
-
-
tfarina authored
The current wording says you 'should' install to build, but that is not really true if you don't want to test some Google services and 'should' sounds very strong. The Mac version has nicer wording for directing users to install the API keys if they want so we ported it over here. BUG=None R=sdefresne@chromium.org Review URL: https://codereview.chromium.org/1774133002 Cr-Commit-Position: refs/heads/master@{#379885}
-
- 07 Mar, 2016 1 commit
-
-
tfarina authored
Due to the code block in the second item, the Markdown engine is not smart enough to figure out that the next one is related to the other items and thus should be '3' not '1'. To fix this, we number the list ourselves rather than letting the Markdown engine do this work for us. BUG=None TEST=load the document in http://dillinger.io/ before this change, confirm it has the issue, then change it and confirm it has the right numbering for the list. R=sdefresne@chromium.org Review URL: https://codereview.chromium.org/1775473002 Cr-Commit-Position: refs/heads/master@{#379590}
-
- 04 Mar, 2016 1 commit
-
-
tfarina authored
This patch tries to clear the last paragraph of "Converting-an-existing-Mac-checkout-into-an-iOS-checkout" section, to be more to the point and slightly more accurate in the future. Given that at some point into the not-so-distant future GN will replace GYP, the word about "gyp_chromium" won't be necessarily true anymore. It does not seem worth to mention this implementation detail of 'gclient sync'. BUG=None R=sdefresne@chromium.org Review URL: https://codereview.chromium.org/1765633005 Cr-Commit-Position: refs/heads/master@{#379332}
-
- 03 Mar, 2016 1 commit
-
-
tfarina authored
This patch changes ios_build_instructions to use asterisk ('*') rather than dash ('-') for a unnumbered or bullet list. This make it conform with other files in the docs/ directory, like mac_build_instructions.md and with the style guide: https://github.com/google/styleguide/blob/gh-pages/docguide/style.md#nested-list-spacing BUG=None R=sdefresne@chromium.org Review URL: https://codereview.chromium.org/1752293005 Cr-Commit-Position: refs/heads/master@{#379040}
-
- 02 Mar, 2016 2 commits
-
-
tfarina authored
This patch makes the title of ios_build_instructions.md match with the other two (mac_build_instructions.md and linux_build_instructions.md). It also reorders/rewords the title so it matches with the Mac one. This patch also changes the headings to use "##" rather than "____" as that is what is recommended by the style guide at https://github.com/google/styleguide/blob/gh-pages/docguide/style.md#atx-style-headings. BUG=None R=sdefresne@chromium.org Review URL: https://codereview.chromium.org/1755133002 Cr-Commit-Position: refs/heads/master@{#378755}
-
sdefresne authored
Add internal links (i.e. links to anchor) as the version of Markdown used by gitiles generate anchors for each heading automatically. Use ``` syntax to introduce the blocs of code so that we can specify the syntax to use for color highlighting (shell, json, ...). Convert enumerated list (1-, 2-, ...) to the proper format to get a nice HTML enumerated list (i.e. 1., 2., ...). Remove superfluous '\' that appeared in the output and always format file names as code using `filename`. BUG=None Review URL: https://codereview.chromium.org/1757833002 Cr-Commit-Position: refs/heads/master@{#378723}
-
- 01 Mar, 2016 2 commits
-
-
tfarina authored
This patch fixes some layout issues when rendering the Markdown file in Gitiles. This should address the post-commit review from https://chromium.googlesource.com/chromium/src/+/b8f70688d44d033c9f14786cb19ea6b176559456 BUG=None TEST=loaded the markdown file in a Markdown viewer(I used http://dillinger.io/), and visually inspected it. R=sdefresne@chromium.org Review URL: https://codereview.chromium.org/1753693002 Cr-Commit-Position: refs/heads/master@{#378522}
-
tfarina authored
This patch converts iOS Build Instructions from https://www.chromium.org/developers/how-tos/build-instructions-ios to Markdown and check it in docs/ directory. The process for doing this was done partially by command line tools and partially manually after inspection at http://dillinger.io/. The command lines to generate the markdown file were: $ wget https://www.chromium.org/developers/how-tos/build-instructions-ios $ pandoc -s -r html build-instructions-ios -o ios_build_instructions.md BUG=None TEST=opened ios_build_instructions.md in dillinger.io and visually inspected it. R=sdefresne@chromium.org Review URL: https://codereview.chromium.org/1747873002 Cr-Commit-Position: refs/heads/master@{#378417}
-