GitLab

There are two that are wrong because cpplint gets confused about
variables named 'copy' and methods named 'swap'. Those I've left alone.

BUG=none

Review-Url: https://codereview.chromium.org/2677583002
Cr-Commit-Position: refs/heads/master@{#447926}

/analyze on Windows complains about using HRESULT in a Boolean context,
so check returned values using the appropriate macro.

BUG=687394
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2669083002
Cr-Commit-Position: refs/heads/master@{#447925}

BUG=682002

Review-Url: https://codereview.chromium.org/2668833002
Cr-Commit-Position: refs/heads/master@{#447924}

- Some buttons were missing the "secondary-button"/"cancel-button" class.
- removing rule-lines
- remove unnecessary controls

BUG=684152
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2668163002
Cr-Commit-Position: refs/heads/master@{#447923}

Otherwise, the cast might be performed on a garbage memory and
CFI will detect that the cast is invalid as the vtable is invalid.

BUG=688055

Review-Url: https://codereview.chromium.org/2673683002
Cr-Commit-Position: refs/heads/master@{#447922}

BUG=672142

Review-Url: https://codereview.chromium.org/2657953005
Cr-Commit-Position: refs/heads/master@{#447921}

Cr-Commit-Position: refs/heads/master@{#447920}

https://pdfium.googlesource.com/pdfium.git/+log/44b297bb2c94..65c7c234d026

$ git log 44b297bb2..65c7c234d --date=short --no-merges --format='%ad %ae %s'
2017-02-02 dsinclair Remove FX_WSTRC usage

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2670073003
Cr-Commit-Position: refs/heads/master@{#447919}

BUG=687558
R=johnme@chromium.org

Review-Url: https://codereview.chromium.org/2667193002
Cr-Commit-Position: refs/heads/master@{#447918}

BUG=665891

Review-Url: https://codereview.chromium.org/2661023006
Cr-Commit-Position: refs/heads/master@{#447917}

BUG=687395

Review-Url: https://codereview.chromium.org/2664083007
Cr-Commit-Position: refs/heads/master@{#447916}

This CL has no behaivor changes.

BUG=685886
TBR=kochi@chromium.org

Review-Url: https://codereview.chromium.org/2670783003
Cr-Commit-Position: refs/heads/master@{#447915}

The API was only used on android to ensure that the CompositorFrame for
a tab is not evicted if a readback request is pending for it. This is
now achieved by creating a readback layer instead, which is attached
to the browser compositor's layer tree. This layer adds a destruction
dependency on the Surface to ensure that the frame is not evicted till
the layer is attached to the tree.

The use of the API has already been removed. This change simply removes
the now dead code.
TBR=piman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2658293002
Cr-Commit-Position: refs/heads/master@{#447914}

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

This CL migrates most, but not all references to one type of remove()
method (that takes a KeyPeekInType).

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2673543003
Cr-Commit-Position: refs/heads/master@{#447913}

https://boringssl.googlesource.com/boringssl/+log/c26692cfdd9b0c86f2573ad03461416c9702bd39..772a5bed7d5065b301c3979c325248689d36b92c

BUG=none

Review-Url: https://codereview.chromium.org/2672943002
Cr-Commit-Position: refs/heads/master@{#447912}

When error occurs during initializing the remote renderer,
CourierRenderer should not report the failure to media pipeline.
Instead, it should always report success to the media pipeline, and
then become a no-op renderer after that point.  The remoting session
will soon end, and a normal local renderer will be created instead.

BUG=687750

Review-Url: https://codereview.chromium.org/2669033004
Cr-Commit-Position: refs/heads/master@{#447911}

We're not working on this config at the moment, so having a red buildbot
testing it is just waste of cycles.

BUG=688123, 598772

Review-Url: https://codereview.chromium.org/2677593002
Cr-Commit-Position: refs/heads/master@{#447910}

This will measure how often the Form-Not-Secure warnings ("Login not secure" or
"Payment not secure" in the autofill dropdown) are clicked on to
show more information about the warning.

BUG=687823
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2665313002
Cr-Commit-Position: refs/heads/master@{#447909}

Currently there are no crash handlers for uncaught java exceptions
in child processes. Add a chrome debug url to crash the GPU process
with an uncaught java exception to aid in testing this code path.

The plumbing is same as chrome://gpucrash, except everything is
behind OS_ANDROID guards. The actual implementation of throwing
the exception is in base.

BUG=680775
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2664373002
Cr-Commit-Position: refs/heads/master@{#447908}

This is very similar to DomTreeExtractor (which we should remove
later) except it uses DOM.getFlattenedDocument.  This is useful for
very large documents which might otherwise blow up the JSON parse
which currently has a nesting depth limit of 200

BUG=546953

Review-Url: https://codereview.chromium.org/2673773002
Cr-Commit-Position: refs/heads/master@{#447907}

Currently, ResourceProvider members which are set once at init and never
modified are not clearly identified. This makes it hard to see what
members can be used in a threadsafe manner.

This change moves these members to a Settings struct and makes the
settings "const", making it clearer how these may be used.

R=vmpstr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2662303004
Cr-Commit-Position: refs/heads/master@{#447906}

This fixes site-details related tests in Vulcanized mode as well as the site
details view when the --enable-site-settings runtime flag is supplied.

When in Vulcanized mode, the tests can no longer include site_details.html
directly, since all URLs redirect to the top-level doc. <site-details> was not
imported anywhere from settings.html's transitive deps, making it impossible for
the tests to pass in Vulcanized mode.

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2669033008
Cr-Commit-Position: refs/heads/master@{#447905}

BUG=678847

Review-Url: https://codereview.chromium.org/2667283005
Cr-Commit-Position: refs/heads/master@{#447904}

CompositingRecorder::endCompositing has an optimization [1] to turn
patterns like [..., begin compositing, drawing, end compositing]
into [..., composited drawing] which takes advantage of an SkPicture
recording optimization. An SkPictureBuilder is not needed in this
case, as we can modify the underlying display list while creating the
new composited drawing. To do this, a DCHECK in DrawingRecorder that
the underlying list doesn't change has been suppressed with
DisableListModificationCheck.

The last user of DisableNullPaintPropertyChecks has been removed which
lets us delete code from PaintChunker.

[1] https://codereview.chromium.org/2186643002

BUG=628831
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2675773003
Cr-Commit-Position: refs/heads/master@{#447903}

Modifies ServiceSyncObserver to recieve SyncService* to the notifying
service in all of it's methods.

Also adds OnShutdown() notification.

This will support adding a long-lived observer in
https://codereview.chromium.org/2653693004/

TBR=sdefresne,treib

BUG=

Review-Url: https://codereview.chromium.org/2657673004
Cr-Commit-Position: refs/heads/master@{#447902}

BUG=none

Review-Url: https://codereview.chromium.org/2655393003
Cr-Commit-Position: refs/heads/master@{#447901}

This CL lands support for QR/barcode detection in Mac by
adding the correspondent files in services/shape_detection.

Most of the work is reshuffling code that was specific to
Face detection, to suit both Face and Barcode detection:

- Removed shape_detection_service_dispatcher.h and merged
 its two methods as statics in render_process_host_impl.cc.

- Moved common service/ code to detection_utils_mac.h/mm
 (1 helper function)

** Important note re. testing **
Chromium Mac bots seem to have troubles running CoreImage
methods, probably because they are virtual machines (no GPU).
This prevents testing the Barcode detection API properly, and also
renders void the current Face detection test. So, the plan is:
a) Remove the current Mac-Face detection test, because is not
testing anything, really (there was a bug in the error-return path
that is cleaned up here).
b) land (imminently) new unit tests for face and barcode, running
in Mac Gpu bots.

This CL does a); b) will be done in a subsequent CL.

BUG=665150
TEST=
./out/gn/Chromium.app/Contents/MacOS/Chromium --enable-blink-features=ShapeDetection,GeometryInterfaces  https://codepen.io/miguelao/full/wgrYjZ
NOTE: unittests for {face/barcode}_detection_impl_mac.mm coming
imminently after this).

Review-Url: https://codereview.chromium.org/2655303005
Cr-Commit-Position: refs/heads/master@{#447900}

BUG=none

Review-Url: https://codereview.chromium.org/2644233007
Cr-Commit-Position: refs/heads/master@{#447899}

Make a copy of the sink-id before removing it from the map. This is
because the id variable is owned by the GpuCompositorFrameSink in the
map. So when the sink is removed from the map, the id is also destroyed.
But the map can continue to iterate and try to use it. Making a copy of
it avoids this.

BUG=none

Review-Url: https://codereview.chromium.org/2673823002
Cr-Commit-Position: refs/heads/master@{#447898}

This patch initialized the underlying ThreadSpecific<WTFThreadData>*
in a separate code path during initialization, to avoid a branch in
wtfThreadData().

BUG=621786

Review-Url: https://codereview.chromium.org/2646003003
Cr-Commit-Position: refs/heads/master@{#447897}

Revert of Convert make_qualified_names and make_element_factory to use JSON5. (patchset #5 id:80001 of https://codereview.chromium.org/2645283006/ )

Reason for revert:
Unexpected compile failure --
https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/32431

Original issue's description:
> Convert make_qualified_names and make_element_factory to use JSON5.
>
> Convert make_qualified_names.py, make_element_factory.py,
> make_element_type_helpers.py, and make_element_lookup_trie.py
> to use JSON5 config format.
>
> Converted these config files accordingly:
>   Source/core/html/HTMLAttributeNames.in
>   Source/core/html/HTMLTagNames.in
>   Source/core/html/parser/MathMLAttributeNames.in
>   Source/core/html/parser/MathMLTagNames.in
>   Source/core/svg/SVGAttributeNames.in
>   Source/core/svg/SVGTagNames.in
>   Source/core/svg/xlinkattrs.in
>   Source/core/xml/xmlattrs.in
>   Source/core/xml/xmlnsattrs.in
>
> Note that these files are updated together because:
> 1. make_element_factory.py depends on make_qualified_names.py
> 2. HTMLTagNames.in is common input to the scripts make_element_factory,
> make_element_type_helpers and make_element_lookup_trie
>
> Removed FIXME in make_element_type_helpers.py since that case
> no longer occurs.
>
> Also fixed bug in json5_generator where parameters should not be
> validated if default_parameters is not provided.
> (caught when I had typo on default_parameters in the script)
>
> BUG=677884
>
> Review-Url: https://codereview.chromium.org/2645283006
> Cr-Original-Commit-Position: refs/heads/master@{#447450}
> Committed: https://chromium.googlesource.com/chromium/src/+/f5ca5654596eeda38c2a796bbbad299d92b7f008
> Review-Url: https://codereview.chromium.org/2645283006
> Cr-Commit-Position: refs/heads/master@{#447891}
> Committed: https://chromium.googlesource.com/chromium/src/+/701ccf95a0ec04657b59ad240e28be4085fe033f

TBR=nainar@chromium.org,sashab@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=677884

Review-Url: https://codereview.chromium.org/2677603002
Cr-Commit-Position: refs/heads/master@{#447896}

Revert of Allow using goma on Windows with symbol_level == 2 (patchset #2 id:20001 of https://codereview.chromium.org/2661023010/ )

Reason for revert:
It broke amd64-generic Trusty informational build at generate_build_files:
ERROR at //build/config/compiler/compiler.gni:115:3: Assertion failed.
  assert(is_win_fastlink || !use_goma,
  ^-----
Goma builds that use symbol_level 2 must use is_win_fastlink.
See //BUILD.gn:11:1: whence it was imported.
import("//build/config/compiler/compiler.gni")
^--------------------------------------------
GN gen failed: 1
step returned non-zero exit code: 1
@@@STEP_FAILURE@@@

See crbug.com/688203 for more info.

Original issue's description:
> Allow using goma on Windows with symbol_level == 2
>
> Traditionally goma for Chrome has been less useful on Windows than on
> other platforms because it was incompatible with full debug information.
> Building with goma requires using /Z7 instead of /Zi, and this causes
> the linker's memory usage and runtime to blow up as all of the debug
> information is merged.
>
> However, /debug:fastlink makes this work. Because it doesn't merge all
> of the debug information it makes goma and /Z7 practical. Full release
> component builds can be done in less than fifteen minutes, with
> incremental builds taking just a few seconds. Without goma a full
> release component build of Chrome can easily take 40+ minutes, even on a
> Z840.
>
> Goma's speedup comes from massively parallelizing the compile phase,
> however even with /debug:fastlink the linking phases are longer with the
> /Z7 switch that is required by goma. A /debug:fastlink of chrome.dll in
> a component build goes from ~32 seconds to ~110 seconds on a Z620 when
> /Z7 (goma) is selected. This penalty will be reduced by VC++ 2017 which
> claims 30% speed improvements on /debug:fastlink.
>
> So, if you frequently need to do full relinks then goma may still be a
> bad choice. However for most scenarios this change should make goma a
> good choice for component builds of Chrome, even with full debug
> information enabled. To make use of this ability you need to explicitly
> specify the switches below - symbol_level will otherwise default to 1
> when use_goma == true.
>
>     use_goma = true
>     is_win_fastlink = true
>     symbol_level = 2
>
> The fastlink PDBs work well for most scenarios but there are a few
> scenarios (rare for most people) where they do not work:
> - Copying PDBs to another machine (fails due to references to the .obj
> files)
> - Reporting on all symbols/globals with SymbolSort or similar fails
> - ETW tracing fails
> - VS heap profiling fails
> Ideally mspdbcmf.exe would let us create "normal" PDBs when needed but
> in practice this appears to be unusable with /Z7 created PDBs.
>
> R=scottmg@chromium.org
>
> Review-Url: https://codereview.chromium.org/2661023010
> Cr-Commit-Position: refs/heads/master@{#447892}
> Committed: https://chromium.googlesource.com/chromium/src/+/4a3cadb2d998fb8f477d0ebc7ff13619b123a805

TBR=scottmg@chromium.org,dpranke@chromium.org,brucedawson@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2669373002
Cr-Commit-Position: refs/heads/master@{#447895}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/b61c782e8622..53604dda661b

$ git log b61c782e8..53604dda6 --date=short --no-merges --format='%ad %ae %s'
2017-02-02 benjhayden Merge Breakdown diagnostics.
2017-02-02 benjhayden Add chromium and v8 commit positions to RevisionInfo.
2017-02-02 benjhayden Fix related histogram links.

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2673723003
Cr-Commit-Position: refs/heads/master@{#447894}

Make the GetTransferMatrix and GetRangeAdjustMatrix functions part of
gfx::ColorSpace instead of gfx::ColorSpaceTransform, and call them from
GLRenderer to compute the YUV to RGB matrix and offset.

Do not actually use the new computation results yet, because they break
pixel tests. Rather, add a DCHECK that the new results are very close to
the previous values being used (within 1/255.f).

Fix the transfer matrix for SMPTE170M to have Kb=0.114 instead of 0.144.

Change the definition of gfx::ColorSpace::CreateJPEG to use the Rec601
transfer matrix, not Rec709. This is necessary for the resulting YUV to
RGB conversion to match the previous behavior.

BUG=667966
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2670773002
Cr-Commit-Position: refs/heads/master@{#447893}

Traditionally goma for Chrome has been less useful on Windows than on
other platforms because it was incompatible with full debug information.
Building with goma requires using /Z7 instead of /Zi, and this causes
the linker's memory usage and runtime to blow up as all of the debug
information is merged.

However, /debug:fastlink makes this work. Because it doesn't merge all
of the debug information it makes goma and /Z7 practical. Full release
component builds can be done in less than fifteen minutes, with
incremental builds taking just a few seconds. Without goma a full
release component build of Chrome can easily take 40+ minutes, even on a
Z840.

Goma's speedup comes from massively parallelizing the compile phase,
however even with /debug:fastlink the linking phases are longer with the
/Z7 switch that is required by goma. A /debug:fastlink of chrome.dll in
a component build goes from ~32 seconds to ~110 seconds on a Z620 when
/Z7 (goma) is selected. This penalty will be reduced by VC++ 2017 which
claims 30% speed improvements on /debug:fastlink.

So, if you frequently need to do full relinks then goma may still be a
bad choice. However for most scenarios this change should make goma a
good choice for component builds of Chrome, even with full debug
information enabled. To make use of this ability you need to explicitly
specify the switches below - symbol_level will otherwise default to 1
when use_goma == true.

    use_goma = true
    is_win_fastlink = true
    symbol_level = 2

The fastlink PDBs work well for most scenarios but there are a few
scenarios (rare for most people) where they do not work:
- Copying PDBs to another machine (fails due to references to the .obj
files)
- Reporting on all symbols/globals with SymbolSort or similar fails
- ETW tracing fails
- VS heap profiling fails
Ideally mspdbcmf.exe would let us create "normal" PDBs when needed but
in practice this appears to be unusable with /Z7 created PDBs.

R=scottmg@chromium.org

Review-Url: https://codereview.chromium.org/2661023010
Cr-Commit-Position: refs/heads/master@{#447892}

Convert make_qualified_names.py, make_element_factory.py,
make_element_type_helpers.py, and make_element_lookup_trie.py
to use JSON5 config format.

Converted these config files accordingly:
  Source/core/html/HTMLAttributeNames.in
  Source/core/html/HTMLTagNames.in
  Source/core/html/parser/MathMLAttributeNames.in
  Source/core/html/parser/MathMLTagNames.in
  Source/core/svg/SVGAttributeNames.in
  Source/core/svg/SVGTagNames.in
  Source/core/svg/xlinkattrs.in
  Source/core/xml/xmlattrs.in
  Source/core/xml/xmlnsattrs.in

Note that these files are updated together because:
1. make_element_factory.py depends on make_qualified_names.py
2. HTMLTagNames.in is common input to the scripts make_element_factory,
make_element_type_helpers and make_element_lookup_trie

Removed FIXME in make_element_type_helpers.py since that case
no longer occurs.

Also fixed bug in json5_generator where parameters should not be
validated if default_parameters is not provided.
(caught when I had typo on default_parameters in the script)

BUG=677884

Review-Url: https://codereview.chromium.org/2645283006
Cr-Original-Commit-Position: refs/heads/master@{#447450}
Committed: https://chromium.googlesource.com/chromium/src/+/f5ca5654596eeda38c2a796bbbad299d92b7f008
Review-Url: https://codereview.chromium.org/2645283006
Cr-Commit-Position: refs/heads/master@{#447891}

Adds some comments that would have been helpful to me as I traced the code to understand it. I think they will be helpful to future readers of the code.

BUG=687424

Review-Url: https://codereview.chromium.org/2667023004
Cr-Commit-Position: refs/heads/master@{#447890}

https://skia.googlesource.com/skia.git/+log/78b6786beccb..1db215a8efb4

$ git log 78b6786be..1db215a8e --date=short --no-merges --format='%ad %ae %s'
2017-02-02 mtklein iOS: dequote args one level
2017-02-02 mtklein iOS: try running the binary
2017-02-02 bsalomon Revert "Revert "Spot shadow cleanup and optimization""
2017-02-02 halcanary bin/list-skia-bots
2017-02-02 msarett Blacklist large images on 32-bit Win 2k8

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=halcanary@google.com

Review-Url: https://codereview.chromium.org/2669203004
Cr-Commit-Position: refs/heads/master@{#447889}

This change:
1) Changes the title string to not include the trailing colon (this affects the
   non-Harmony version too)
2) Switches from 9px to 8px for the spacing between items (affects non-Harmony)
3) Makes the indent on permission entries conditional on non-Harmony

BUG=605667

Review-Url: https://codereview.chromium.org/2654123004
Cr-Commit-Position: refs/heads/master@{#447888}

Small code clean-up to avoid verbose standalone vector init.

R=vmpstr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2672553002
Cr-Commit-Position: refs/heads/master@{#447887}