1. 14 Nov, 2017 1 commit
  2. 10 Nov, 2017 1 commit
  3. 09 Nov, 2017 1 commit
    • Jun Cai's avatar
      Grant generic sensor permission for Android WebView · b6c4e590
      Jun Cai authored
      This CL adds code to grant generic sensor permission for Android
      WebView so that the sensors needed by device motion and orientation can
      be obtained from the generic sensor provider.
      
      Note: This will not allow Android WebView to have access to all the
      sensors that the generic sensor API provides since
      SensorProviderImpl::GetSensor() is still guarded by
      features::kGenericSensorExtraClasses flag. There is no new sensors
      permission granted, and the sensors that are exposed on WebView by
      this CL are those sensors that are already available on WebView
      previously which are used to implement device motion/orientation
      events.
      
      Bug: 779443
      Change-Id: I1405e54213bb07d1d781181e473fc77e89bb12ed
      Reviewed-on: https://chromium-review.googlesource.com/759240
      
      
      Commit-Queue: Jun Cai <juncai@chromium.org>
      Reviewed-by: default avatarReilly Grant <reillyg@chromium.org>
      Reviewed-by: default avatarTao Bai <michaelbai@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#515285}
      b6c4e590
  4. 08 Nov, 2017 1 commit
  5. 07 Nov, 2017 2 commits
  6. 03 Nov, 2017 1 commit
  7. 02 Nov, 2017 1 commit
  8. 31 Oct, 2017 1 commit
  9. 26 Oct, 2017 4 commits
  10. 25 Oct, 2017 1 commit
  11. 20 Oct, 2017 4 commits
  12. 19 Oct, 2017 1 commit
  13. 18 Oct, 2017 1 commit
    • danakj's avatar
      Report fatal vs transient errors when initializing contexts · 45cfd23c
      danakj authored
      Currently context creation and initialization reports back just true/false
      for if the process succeeded. This expands that information to a tri-state
      of success, fatal error, transient error. In the latter case, the client
      should retry making the context as it may succeed next time. This happens
      when, for instance, another client crashes the gpu process at the same
      time the context is being constructed. In the case of a fatal error, the
      context can not be made given the current inputs so either the gpu is not
      usable, or the client has a bug and is requesting an invalid context of
      some sort, but it will not make progress by retrying. So in this case the
      client should not retry and just fail back to a non-gpu mode.
      
      This information will allow us to remove the retry count when making the
      compositor context for the display compositor, removing the state machine
      in that code (as retry becomes a local decision from the result).
      
      TBR=raymes
      
      Bug: 772574
      Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
      Change-Id: Ic3574de9fccae42ac34ff8a5755d4cfa5f0dd2b0
      Reviewed-on: https://chromium-review.googlesource.com/717548
      
      Reviewed-by: default avatardanakj <danakj@chromium.org>
      Reviewed-by: default avatarSadrul Chowdhury <sadrul@chromium.org>
      Reviewed-by: default avatarKen Buchanan <kenrb@chromium.org>
      Reviewed-by: default avatarAntoine Labour <piman@chromium.org>
      Commit-Queue: danakj <danakj@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#509836}
      45cfd23c
  14. 14 Oct, 2017 1 commit
  15. 13 Oct, 2017 4 commits
  16. 12 Oct, 2017 1 commit
    • Zhenyao Mo's avatar
      Upstream GpuFeatureInfo access to ContextProvider. · 04ea0f07
      Zhenyao Mo authored
      Because we need it for removing a few incorrect workarounds added to Capabilities.
      
      Also, clean up an unnecessary copy of GpuDriverBugWorkarounds.
      
      BUG=744658
      TEST=bots
      R=piman@chromium.org
      
      Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
      Change-Id: Ibd3389ad2f120b4d161163e45a0a534a07a575b2
      Reviewed-on: https://chromium-review.googlesource.com/713736
      
      Reviewed-by: default avatarAntoine Labour <piman@chromium.org>
      Reviewed-by: default avatarBo <boliu@chromium.org>
      Commit-Queue: Zhenyao Mo <zmo@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#508195}
      04ea0f07
  17. 10 Oct, 2017 1 commit
    • Ehsan Chiniforooshan's avatar
      tracing: TracingController -> Coordinator · c77b44eb
      Ehsan Chiniforooshan authored
      This CL re-plumbs the content code to use the tracing::Coordinator
      interface instead of content::TracingControllerImpl.
      
      Summary of modifications:
      
      1- Existing tracing agents extend base::trace_event::TracingAgent. We
         modified them to extend tracing::Agent, instead.
      
      2- content::TracingControllerImpl is modified to forward all calls to
         tracing::Coordinator via Mojo.
      
      3- Chrome tracing IPC messages between child processes and
         content::TracingControllerImpl are deleted.
      
      4- Now that tracing agents (battor/etw/cros/arc) and chrome trace
         trace event clients are unified, there is no need for
         TracingController::TraceDataSink. It is deleted.
         TracingController::TraceDataEndpoint is used directly.
      
      Bug=640235
      
      Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
      Change-Id: I6dab520a2b53b0a56a016fccf9052e76fc99f78f
      Reviewed-on: https://chromium-review.googlesource.com/575716
      
      
      Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org>
      Reviewed-by: default avatarAntoine Labour <piman@chromium.org>
      Reviewed-by: default avatarScott Violet <sky@chromium.org>
      Reviewed-by: default avatarAhmed Fakhry <afakhry@chromium.org>
      Reviewed-by: default avatarKen Buchanan <kenrb@chromium.org>
      Reviewed-by: default avataroysteine <oysteine@chromium.org>
      Reviewed-by: default avatarBo <boliu@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#507717}
      c77b44eb
  18. 06 Oct, 2017 1 commit
  19. 05 Oct, 2017 3 commits
    • Lei Zhang's avatar
      Refer to ui::ResourceBundle with namespace in various dirs. · 0c4fa0d9
      Lei Zhang authored
      ResourceBundle became ui::ResourceBundle in r72038 but many callers
      still refer to it without the namespace.
      
      Change-Id: I920e21319041cd0e2a2fa671db709a9d8483fb2e
      Reviewed-on: https://chromium-review.googlesource.com/701662
      
      Reviewed-by: default avatarLuke Halliwell <halliwell@chromium.org>
      Reviewed-by: default avatarEugene But <eugenebut@chromium.org>
      Reviewed-by: default avatarRichard Coles <torne@chromium.org>
      Reviewed-by: default avatarScott Violet <sky@chromium.org>
      Commit-Queue: Lei Zhang <thestig@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#506826}
      0c4fa0d9
    • Avi Drissman's avatar
      Make DialogClosedCallback be a OnceCallback. · e04d3998
      Avi Drissman authored
      BUG=770788
      
      Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
      Change-Id: I5b0f2b2d6668bddfb92b6a452487edf69f817b1f
      Reviewed-on: https://chromium-review.googlesource.com/696684
      
      
      Commit-Queue: Avi Drissman <avi@chromium.org>
      Reviewed-by: default avatarScott Violet <sky@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#506734}
      e04d3998
    • Lucas Garron's avatar
      Remove `overridable` parameter from... · 9cc660cd
      Lucas Garron authored
      Remove `overridable` parameter from ContentBrowserClient::AllowCertificateError() and its overrides.
      
      content::SSLManager previously contained some logic for computing whether/how an
      interstitial should be bypassable, which it then passed into
      ContentBrowserClient::AllowCertificateError(), though only
      ChromeContentBrowserClient's implementation was using it. This presented a
      problem for the interstitial refactor because this logic is needed for
      interstitial display, but
      SSLManager/ChromeContentBrowserClient::AllowCertificateError() is no longer
      going to be the point that triggers interstitial display.
      
      crrev.com/c/679937 moved this logic into //chrome's SSLErrorHandler, which is a
      more convenient place for the logic to live because both the old and new
      interstitial display codepaths pass through that point. In order to simplify
      reviews, that CL kept the interface of
      `ContentBrowserClient::AllowCertificateError()` intact, even though the
      `overridable` calculation is now done in SSLErrorHandler. This follow-up CL
      modifies `AllowCertificateError` to remove the defunct `overridable` parameter.
      
      Note that this change does not update the similar parameter in
      WebClient::AllowCertificateError() on iOS.
      
      TBR=jochen@chromium.org
      
      Bug: 768105
      Change-Id: I8214a89b6497108dea3dfe636735c865041a0673
      Reviewed-on: https://chromium-review.googlesource.com/680114
      
      
      Commit-Queue: Lucas Garron <lgarron@chromium.org>
      Reviewed-by: default avatarEmily Stark <estark@chromium.org>
      Reviewed-by: default avatarNasko Oskov <nasko@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#506638}
      9cc660cd
  20. 04 Oct, 2017 2 commits
    • Bo Liu's avatar
      aw: shouldInterceptRequest for LoadDataWithBaseURL hack · cb8eb9fd
      Bo Liu authored
      Old behavior before PlzNavigate was that resource for a
      LoadDataWithBaseURL navigation does *not* trigger
      shouldInterceptRequest.
      
      Also add tests to verify shouldInterceptRequest with various
      load data calls.
      
      This CL adds a hack to get back to the same behavior. Hack works
      by filtering out empty data URLs, which through a quirk in content
      is what's sent up for the shouldInterceptRequest call.
      
      This is a hack because it's relying on a content implementation
      detail which can change at any time. It is also risky if there are
      legitimate cases where an empty data URL is used in practice.
      
      This is short term fix to ship PlzNavigate in webview, but this
      hack should definitely be revisited soon after.
      
      Bug: 769126
      Change-Id: I70b5ca44a33126f6470978a9ffe8f7d8126c15bd
      Reviewed-on: https://chromium-review.googlesource.com/698724
      
      Reviewed-by: default avatarNasko Oskov <nasko@chromium.org>
      Reviewed-by: default avatarNate Fischer <ntfschr@chromium.org>
      Commit-Queue: Bo <boliu@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#506569}
      cb8eb9fd
    • kylechar's avatar
      base: Change make_scoped_refptr to WrapRefCounted. · da69d884
      kylechar authored
      The helper function make_scoped_refptr() doesn't match the base/std
      naming convention for make to construct the object. Now there is
      MakeRefCounted() to make a new scoped_refptr and WrapRefCounted() to
      wrap something in scoped_refptr, similar to MakeUnique() and
      WrapUnique(). This is a purely mechanical regex search and replace.
      
      Bug: 765333
      Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
      Change-Id: I5057e51282e519693f6fca504bd54deb638b712f
      Reviewed-on: https://chromium-review.googlesource.com/667726
      
      
      Commit-Queue: kylechar <kylechar@chromium.org>
      Reviewed-by: default avatarScott Violet <sky@chromium.org>
      Reviewed-by: default avatardanakj <danakj@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#506316}
      da69d884
  21. 02 Oct, 2017 1 commit
  22. 29 Sep, 2017 2 commits
  23. 28 Sep, 2017 2 commits
  24. 27 Sep, 2017 1 commit
  25. 26 Sep, 2017 1 commit
    • Brett Wilson's avatar
      Convert std::deque to base::circular_deque. · 55ff1475
      Brett Wilson authored
      The Request class in deterministic_dispatcher.h was made moveable to support
      its inclusion in a circular_deque. There was some minor cleanup of this
      class.
      
      Typedefs around changed code were converted to using statements.
      
      Some unnecessary <deque> includes were removed. An unnecessary <list>
      include is removed from remoting/protocol/message_decoder.h, and a
      <list> include was addedto remoting/protocol/message_decoder_unittest.cc
      which was depending on this.
      
      TBR=stevenjb (chromeos/network owners)
      
      Bug: 757232
      Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
      Change-Id: I654daa3f575b21fbfd6db225d0c321bc5781f96f
      Reviewed-on: https://chromium-review.googlesource.com/676201
      
      
      Commit-Queue: Brett Wilson <brettw@chromium.org>
      Reviewed-by: default avatarenne <enne@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#504232}
      55ff1475