1. 14 Nov, 2017 1 commit
  2. 07 Nov, 2017 1 commit
  3. 13 Oct, 2017 1 commit
  4. 18 Sep, 2017 1 commit
  5. 11 Sep, 2017 1 commit
  6. 09 Sep, 2017 1 commit
  7. 14 Aug, 2017 2 commits
  8. 12 Aug, 2017 1 commit
  9. 28 Jul, 2017 1 commit
  10. 21 Jul, 2017 1 commit
  11. 11 Jul, 2017 1 commit
  12. 10 Jul, 2017 1 commit
  13. 22 Jun, 2017 1 commit
  14. 05 Jun, 2017 1 commit
    • paulmiller's avatar
      WebView: Add channel info for UMA · 234ec23e
      paulmiller authored
      Inspect the WebView provider package name to determine the channel. This
      only works for Monochrome (on Android N+); stand-alone WebView uses the
      same package across channels, and will still be reported as "unknown".
      Move version_utils from metrics/net/ to metrics/, and move the
      channel-checking code from chrome/browser/ to version_info/, so that
      WebView can use them.
      Split off the part of version_utils that depends on //ui/base, since
      most users of version_utils don't need that part, and it pulls in a huge
      tree of dependencies.
      Review-Url: https://codereview.chromium.org/2879703002
      Cr-Commit-Position: refs/heads/master@{#477124}
  15. 19 May, 2017 1 commit
    • ctzsm's avatar
      [WebView] Merge AwMetricsServiceClient and move few files to new place · 82bd374d
      ctzsm authored
      This CL:
      1) Move files around to let them make more sense.
      browser/net_init_native_callback.cc -> browser/net/init_native_callback.cc
      browser/aw_resource.cc -> common/aw_resource.cc
      2) Removed aw_metrics_service_client.{h,cc} and
      use aw_metrics_service_client_impl.{h,cc} to replace them.
      Hitting the same banned function usage:
      Use base/task_scheduler/post_task.h instead of the blocking pool.
      Hence requires no presubmit check.
      Review-Url: https://codereview.chromium.org/2886283005
      Cr-Commit-Position: refs/heads/master@{#473299}
  16. 14 Jan, 2017 1 commit
    • paulmiller's avatar
      Prepare to call GMS APIs from WebView · 85990128
      paulmiller authored
      - Switch setMetricsSettingListener from a listener to a 1-time query.
      - Replace tryEnableGms with canUseGms. (tryEnableGms will actually be
        removed in a follow-up, since overloading implementations elsewhere
        must be removed first.)
      - Fix the race condition between native AwMetricsServiceClient
        initialization and Java metrics setting query. The Java side will wait
        for native initialization before switching on metrics.
      - Move the native AwMetricsServiceClient implementation to native/,
        replacing AwMetricsServiceSwitch, so it can signal the Java
        AwMetricsServiceClient when it's ready.
      - Fix AwTestBase, which was incorrectly creating AwBrowserContext on the
        test thread. That was preventing us from using assertOnUiThread.
      - ...which requires fixing AwStrictModeTest, which was going out of its
        way to create AwBrowserContext on the UI thread, as runOnMainSync
        doesn't allow redundant invocations.
      - Some miscellaneous comment & whitespace cleanup.
      Review-Url: https://codereview.chromium.org/2611883002
      Cr-Commit-Position: refs/heads/master@{#443776}
  17. 13 Jan, 2017 1 commit
  18. 06 Jan, 2017 1 commit
  19. 30 Sep, 2016 1 commit
    • asvitkine's avatar
      Make logging of user actions consistent with histograms for OTR. · 7573bd00
      asvitkine authored
      Previously, we would not record user actions in UMA when an OTR
      (Incognito) window was active. However, since user actions don't
      contain any PII it was just causing a confusing discrepancy in
      counts when compared to histograms. This CL makes them consistent
      by making user actions be logged regardless of the OTR state.
      TBR=sgurun@chromium.org, wez@chromium.org, rohitrao@chromium.org
      Review-Url: https://codereview.chromium.org/2383533002
      Cr-Commit-Position: refs/heads/master@{#422133}
  20. 17 Aug, 2016 1 commit
    • asvitkine's avatar
      Remove OnRecordingDisabled() metrics client interface. · 12aec333
      asvitkine authored
      This was there so that crash client id could be cleared.
      However, this was being called out of MetricsService::Stop(),
      so it needed a special provision to not clear it when shutting
      down, for example.
      This change instead removes all of that plumbing and makes the
      id clearing happen in the same place we clear the UMA client id,
      when the user actually opts-out (as opposed to just metrics service
      stopping). Unifies the prefs manipulation that happens when the
      user changes the setting into a helper function.
      As a follow up change after this lands, we should also make that
      function be called on iOS.
      Review-Url: https://codereview.chromium.org/2248793002
      Cr-Commit-Position: refs/heads/master@{#412568}
  21. 12 May, 2016 1 commit
    • jwd's avatar
      Splitting the concept of UMA consent, and should UMA report. · a5d18839
      jwd authored
      The motivation here is to support sampling clients. When a client isn't in the sample, reporting will be disabled, even if they've consented.
      Knowing consent is still important to make sure the client_id is created, and the high entropy source is used for variations selection. Otherwise, clients would be shuffled into different variations whenever they come in or out of the sample.
      Review-Url: https://codereview.chromium.org/1958003003
      Cr-Commit-Position: refs/heads/master@{#393333}
  22. 01 Apr, 2016 1 commit
  23. 24 Feb, 2016 1 commit
    • hashimoto's avatar
      base: Stop overloading ReadFileToString() · 6da2fef0
      hashimoto authored
      With the existing code, base::Bind(&base::ReadFileToString) doesn't compile because
      the compiler cannot infer the argument's type (2-argument version or
      3-argument version).
      base::Bind<bool(*)(const base::FilePath&,
      std::string*)>(&base::ReadFileToString) compiles but it doesn't look
      As our style guide discourages function overloading(*), rename the 3-argument version (added in http://crrev.com/157593005) to stop overloading.
      TBR=sgurun@chromium.org for android_webview, derat@chromium.org for chromeos/accelerometer, bartfab@chromium.org for components/policy, dsinclair@chromium.org for components/tracing, estade@chromium.org for content/browser/webui, sergeyu@chromium.org for remoting
      Review URL: https://codereview.chromium.org/1719983005
      Cr-Commit-Position: refs/heads/master@{#377209}
  24. 03 Feb, 2016 3 commits
  25. 20 Jan, 2016 1 commit
    • paulmiller's avatar
      Fix race condition-y Finalize w/ extreme predjudice · 8ff952ae
      paulmiller authored
      There's potential a race condition between Finalize and
      InitializeWithGUID, if the browser context decides to call Finalize
      before GetOrCreateGUID has finished. But Finalize will never actually be
      called anyway, nor is it needed, so remove it along with the unused
      WebView versions of PostMainMessageLoopRun.
      Also fix up threading comments and add some more threading DCHECKs.
      Review URL: https://codereview.chromium.org/1584483004
      Cr-Commit-Position: refs/heads/master@{#370431}
  26. 14 Jan, 2016 1 commit
  27. 13 Jan, 2016 1 commit
  28. 05 Jan, 2016 1 commit