1. 28 Jun, 2016 1 commit
  2. 27 Jun, 2016 1 commit
  3. 17 Jun, 2016 1 commit
  4. 10 Jun, 2016 2 commits
  5. 04 Jun, 2016 1 commit
  6. 27 May, 2016 1 commit
    • juncai's avatar
      Refactor ChooserBubbleController · bf183dd5
      juncai authored
      This is part 1 of enabling the chooser UIs for Bluetooth from
      Apps to enable developers to make a transition.
      
      There are many common functionalities in ChooserBubbleController
      that chooser UI needs on both desktops and from Apps. But since
      now it is at:
      //chrome/browser/ui/website_settings/chooser_bubble_controller.h
      code from //extensions can not use it. This patch pulled some
      functionalities from ChooserBubbleController and moved it to
      ChooserController, which is added to
      //components/chooser_controller
      
      BUG=611917, 577170
      
      Review-Url: https://codereview.chromium.org/1984923002
      Cr-Commit-Position: refs/heads/master@{#396492}
      bf183dd5
  7. 24 May, 2016 1 commit
  8. 23 May, 2016 1 commit
  9. 20 May, 2016 1 commit
  10. 19 May, 2016 1 commit
    • changwan's avatar
      Stop using nested message loop for alert() and other JS dialogs · 6ed4d437
      changwan authored
      alert() needs to block on a single boolean result and is currently using
      a nested loop to process async messages while waiting for a reply from
      browser process. The nested loop adds a huge complexity to the subsystem as
      it requires support for reentrancy and reordering in handling every message.
      
      Especially, when ImeThread feature was enabled, it was causing a DCHECK
      failure and a hang because some messages got unexpectedly reordered.
      
      Instead of landing a workaround for ImeThread case, this removes nested
      message loop use case for RenderFrameImpl.
      
      Other changes here includes:
      1) Fix ExtensionApiTest not to send async messages and wait for result
         while alert dialog is showing up. This would hang otherwise.
      2) Change UnloadController / FastUnloadController to check whether
         beforeunload events have already been fired in the case of devtools.
         We were firing beforeunload events twice when closing devtools
         incorrectly even before this change, but closing process continued
         because async messages were allowed. This fixes
         DevToolsBeforeUnloadTest::TestUndockedDevToolsApplicationClose.
      3) For 2), change Browser and BrowserTabStripModel to call non-static
         member functions.
      4) Fix UnloadTest by removing the two second wait limit. Sometimes it took
         more than 2 seconds just to close the browser, but the test could close
         the browser because async messages were allowed. Now the test fails if
         before unload dialog shows up, so we prevent it by running an infinite
         loop.
      
      BUG=604675
      
      Review-Url: https://codereview.chromium.org/1931793002
      Cr-Commit-Position: refs/heads/master@{#394883}
      6ed4d437
  11. 11 May, 2016 1 commit
    • gab's avatar
      Fix include path for moved thread_task_runner_handle.h header in chrome/ · b15e1907
      gab authored
      Changes made by tools/git/move_source_file.py
      
      Note, these files are +1/-2 because header was duplicated:
       user_image_manager_impl.cc,
       device_local_account_policy_service.cc,
       user_cloud_policy_manager_factory_chromeos.cc,
       native_message_host_chromeos.cc
      
      Every other file is +1/-1 for rename + scripted re-order.
      
      (might need to disable codereview extensions to be able
      to render this 400 files CL... -- other components were split
      off to avoid a 1500 files CL but I'm hoping not also have to
      split chrome/)
      
      BUG=610438
      TBR=thakis@chromium.org
      NO_DEPENDENCY_CHECKS=true
      
      Review-Url: https://codereview.chromium.org/1967773004
      Cr-Commit-Position: refs/heads/master@{#393050}
      b15e1907
  12. 10 May, 2016 1 commit
  13. 07 May, 2016 1 commit
  14. 06 May, 2016 2 commits
  15. 05 May, 2016 1 commit
    • estade's avatar
      Remove requestAutocomplete · e62c2a4c
      estade authored
      Also fix some libaddressinput dependencies/includes which incorrectly used ENABLE_AUTOFILL_DIALOG (since libaddressinput is used for chrome://settings/autofill regardless of the use of the dialog).
      
      Also move some color constants closer to where they're used for the card unmask dialog.
      
      BUG=337587, 608824
      TBR=palmer@chromium.org
      
      Review-Url: https://codereview.chromium.org/1931043002
      Cr-Commit-Position: refs/heads/master@{#391821}
      e62c2a4c
  16. 03 May, 2016 1 commit
    • thomasanderson's avatar
      Add support for X11 workspaces · 06405c59
      thomasanderson authored
      The core changes introduced:
      - Add new observers that will get notified when a window's workspace
      changes.
      - Save the browser window workspace whenever the workspace changes
      - Restore the browser workspace for a restored browser session
      
      BUG=18596
      
      Review-Url: https://codereview.chromium.org/1927203003
      Cr-Commit-Position: refs/heads/master@{#391382}
      06405c59
  17. 18 Apr, 2016 1 commit
  18. 08 Apr, 2016 1 commit
  19. 05 Apr, 2016 1 commit
    • jshin's avatar
      Drop |languages| from FormatUrl*() and ElideUrl() · 1fb76469
      jshin authored
      In http://crrev.com/382029, IDN display policy was revised to be
      independent of Accept-Languages (A-L).  Therefore, IDNToUnicode(), FormatUrl*()
      and ElideUrl() do not need |languages| argument any more.
      ( ElideUrl() can pass A-L down to gfx string drawing/measuring API help
      their font selection, but there's no gfx string drawing/measuring API taking
      into account A-L values in the font selection atm.)
      
      Drop it in the API and fix all the call sites. There is a huge ripple effect
      and a lot of files have to be fixed up.
      
      BUG=336973
      TEST=Builds on all platforms and pass all the tests pass
      CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
      CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel
      
      Review URL: https://codereview.chromium.org/1841653003
      
      Cr-Commit-Position: refs/heads/master@{#385299}
      1fb76469
  20. 01 Apr, 2016 1 commit
  21. 29 Mar, 2016 1 commit
  22. 18 Mar, 2016 1 commit
  23. 16 Mar, 2016 1 commit
  24. 12 Mar, 2016 1 commit
  25. 26 Feb, 2016 2 commits
  26. 19 Feb, 2016 1 commit
    • mgiuca's avatar
      Fullscreen: Mouse events now count as input for activating the bubble. · ef9a2866
      mgiuca authored
      Only matters if the simplified-fullscreen-ui flag is enabled.
      
      After 15 minutes of no user input, the fullscreen / pointer lock bubble
      is re-shown on the next user input. Previously, this only considered
      mouse movement and key presses. Now all mouse events are also included
      for both extending the 15-minute timer, and re-showing the bubble after
      the timer has elapsed.
      
      Importantly, this works while mouselock is active (otherwise, you would
      not be reminded that you are in fullscreen if it also locks the mouse).
      The way mouse events are propagated from the RenderWidgetHostViewAura to
      the browser was changed to support this.
      
      Re-land (CL was committed in r369300, reverted in r369549).
      
      BUG=352425, 577983
      
      Review URL: https://codereview.chromium.org/1561963003
      
      Cr-Commit-Position: refs/heads/master@{#376357}
      ef9a2866
  27. 17 Feb, 2016 1 commit
  28. 09 Feb, 2016 2 commits
  29. 05 Feb, 2016 1 commit
  30. 04 Feb, 2016 3 commits
  31. 03 Feb, 2016 2 commits
    • sdefresne's avatar
      Abstract ToolbarModelImpl dependencies on //content. · 4d623d70
      sdefresne authored
      Add following methods to ToolbarModelImpl to abstract the dependencies
      on content::WebContents.
      
      - GetURL(): fetches the URL to display, if it exists, or return false,
      
      - ShouldDisplayURL(): returns whether the URL should be displayed in the
        toolbar or not (embedder specific)
      
      - GetSecurityLevel(): returns the security level of the underlying page,
        independently of the editing status of the toolbar,
      
      - GetSearchTerms(): extracts the search terms for the current page from
        the content::WebContents (implementation depends on the embedder),
      
      - GetCertificate(): returns the certificate for the current page, if
        any, otherwise returns null.
      
      Inject the constant content::kMaxURLDisplayChars through the constructor
      of ToolbarModelImpl to allow sharing the code with iOS that cannot depend
      on content.
      
      TBR=dzhioev@chromium.org
      BUG=582921
      
      Review URL: https://codereview.chromium.org/1653013002
      
      Cr-Commit-Position: refs/heads/master@{#373317}
      4d623d70
    • scottmg's avatar
      Remove the rest of HostDesktopType from c/b/ui/browser_finder.h · 34c5dd88
      scottmg authored
      R=sky@chromium.org
      BUG=558054
      
      Review URL: https://codereview.chromium.org/1661713002
      
      Cr-Commit-Position: refs/heads/master@{#373182}
      34c5dd88
  32. 02 Feb, 2016 1 commit
    • brettw's avatar
      Update chrome for new prefs location. · b1fc1b83
      brettw authored
      This is a search-and-replace update for includes with "base/prefs" ->
      "components/prefs" and the headers re-sorted in the chrome directory.
      
      DEPS files were updated to allow the components in question to depend on
      components/prefs. chrome/DEPS was updated to whitelist all components rather
      than listing all the ones it uses out individually. Checkdeps is a tool to
      enforce layering, and Chrome is allowed to depend on any component, so listing
      each one it uses doesn't help anything.
      
      This should be a no-op from a build perspective.
      
      BUG=583034
      TBR=jam@chromium.org
      
      Review URL: https://codereview.chromium.org/1658793002
      
      Cr-Commit-Position: refs/heads/master@{#372827}
      b1fc1b83
  33. 29 Jan, 2016 1 commit