1. 26 Apr, 2017 1 commit
  2. 12 Apr, 2017 2 commits
  3. 09 Apr, 2017 1 commit
    • Blink Reformat's avatar
      The Blink Rename · 1c4d759e
      Blink Reformat authored
      Identifiers in Blink now largely follow the standard Chrome style
      conventions, with several additional rules:
      - web-exposed methods remain namedLikeThis() for consistency with
        Javascript bindings.
      - method names are never named_in_hacker_case()
      - enumerator names are kNamedLikeThis.
      
      This commit was generated by the following process.
      1. Running //tools/clang/rewrite_to_chrome_style across the codebase.
      2. Apply manual fixes.
      3. git cl format
      
      BUG=578344
      R=lukasza@chromium.org
      TBR=darin@chromium.org
      
      Change-Id: Ide5d397d3c6a5d973fd0a6f81dccf82561d4bb71
      Reviewed-on: https://chromium-review.googlesource.com/472192
      
      Reviewed-by: default avatarBlink Reformat <blink-reformat@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#463139}
      1c4d759e
  4. 05 Apr, 2017 1 commit
  5. 24 Mar, 2017 1 commit
  6. 21 Feb, 2017 1 commit
  7. 07 Jan, 2017 1 commit
    • nasko's avatar
      Change computed style enums to be prefixed with 'k'. · dc8651b8
      nasko authored
      As part of the Blink rewrite to match Chromium style, all enums will
      be changed to have a 'k' prefix. The goal of this CL is to land one
      of these changes ahead of time, since the automated tool doesn't
      handle rewriting symbols that are declared in generated code.
      
      BUG=678974
      CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
      
      Review-Url: https://codereview.chromium.org/2614883007
      Cr-Commit-Position: refs/heads/master@{#442156}
      dc8651b8
  8. 22 Dec, 2016 1 commit
    • sashab's avatar
      Moved list-style-type to be generated in ComputedStyleBase · 3a0ac152
      sashab authored
      Move the inherited property list-style-type and its enum,
      EListStyleType, to be generated in ComputedStyleBase. Also moved getter
      / setter / initial value methods to be generated in ComputedStyleBase.
      
      Also renamed some of EListStyleType's values to be consistent with the
      keyword values for list-style-type:
      
      DecimalListStyle -> Decimal
      CJKIdeographic -> CjkIdeographic
      NoneListStyle -> None
      
      Since they are now inside an enum class, they cannot be used without the
      EListStyleType:: prefix, so they are safe to use simple names for.
      
      Review-Url: https://codereview.chromium.org/2597083002
      Cr-Commit-Position: refs/heads/master@{#440339}
      3a0ac152
  9. 11 Dec, 2016 1 commit
  10. 16 Nov, 2016 1 commit
    • sashab's avatar
      Changed EListStyleType to an enum class and renamed its members to keywords · ff0c1a48
      sashab authored
      Changed EListStyleType to an enum class and gave it an unsigned
      underlying type. Also renamed its members to match its keywords from
      CSSValueKeywords.in.
      
      Changing it to an enum class enforces better namespacing and code
      practices. Adding the unsigned underlying type is pre-work for when the
      class is eventually stored as an enum bitfield (it would be done in this
      patch, except a presubmit warning already exists that prevents that. The
      presubmit warning needs to be updated before that change can occur.)
      
      This is also pre-work to move EListStyleType to be generated in
      ComputedStyleBase.
      
      BUG=628043
      CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
      
      Review-Url: https://codereview.chromium.org/2367293002
      Cr-Commit-Position: refs/heads/master@{#432376}
      ff0c1a48
  11. 07 Oct, 2016 1 commit
  12. 01 Oct, 2016 1 commit
    • Blink Reformat's avatar
      Reformat blink. · 1c8e1a77
      Blink Reformat authored
      This should be behavior-preserving, so if `git blame` claims that this
      CL touched something last, look at the previous CL touching the line
      you're looking at.
      
        find third_party/WebKit/ -name '*.cpp' -o -name '*.h' -o -name '*.mm' | \
            xargs buildtools/linux64/clang-format -i
      
      BUG=563793
      
      Cr-Commit-Position: refs/heads/master@{#422256}
      1c8e1a77
  13. 09 Sep, 2016 1 commit
  14. 24 May, 2016 1 commit
  15. 12 Apr, 2016 1 commit
  16. 04 Apr, 2016 1 commit
    • robhogan's avatar
      Don't attempt to collapse empty anonymous blocks if they might already have been destroyed · 6b42be50
      robhogan authored
      LayoutBlock::addChild() can destroy its own object and that of any out-of-flow
      or floating siblings - for that reason it's not safe to access the object or any
      of its siblings after calling it. So when checking for an empty anonymous block
      here, do so after removing its child and before we add it to its new home.
      
      The check was introduced in wkbug.com/78250 and a follow-up wkbug.com/79681
      so we have test coverage from those two CLs as well.
      
      BUG=598722
      
      Review URL: https://codereview.chromium.org/1843213002
      
      Cr-Commit-Position: refs/heads/master@{#385009}
      6b42be50
  17. 26 Mar, 2016 1 commit
  18. 08 Feb, 2016 1 commit
    • hayato's avatar
      Rename ComposedTree to FlatTree · 5c496adc
      hayato authored
      The spec change is: https://github.com/w3c/webcomponents/commit/9b7f16e90b88594ed783ff7e0f971fad084e5f4d
      
      Blink should follow the change of the terminologies in the spec.
      There is no change on web-facing APIs.
      
      This CL is the result of the (almost) mechanical renaming, using:
      
      > zargs **/*.{h,cpp,gyp,gypi,idl,js,html,txt} -- sed -i -e 's/ComposedTree/FlatTree/g'
      > zargs **/*.{h,cpp,gyp,gypi,idl,js,html,txt} -- sed -i -e 's/composed tree/flat tree/g'
      > zargs **/*.{h,cpp,gyp,gypi,idl,js,html,txt} -- sed -i -e 's/Composed tree/Flat tree/g'
      > zargs **/*.{h,cpp,gyp,gypi,idl,js,html,txt} -- sed -i -e 's/Composed Tree/Flat Tree/g'
      
      Other renaming, which would require a more careful investigation, will be done in another CL.
      
      BUG=531990
      
      Review URL: https://codereview.chromium.org/1675163002
      
      Cr-Commit-Position: refs/heads/master@{#374095}
      5c496adc
  19. 02 Feb, 2016 1 commit
    • leviw's avatar
      Removing more implicit LayoutUnit construction · f4da8ea9
      leviw authored
      If you asked Canadian Prime Minister Justin Trudeau why we're removing
      all implicit LayoutUnit constructors, he'd probably have an easy answer
      for you: "It's 2016!"
      
      No functional changes beyond tiny differences in conversions, most to
      avoid unncecessary conversions.
      
      BUG=581254
      
      Review URL: https://codereview.chromium.org/1656743002
      
      Cr-Commit-Position: refs/heads/master@{#372856}
      f4da8ea9
  20. 30 Jan, 2016 1 commit
  21. 15 Jan, 2016 1 commit
  22. 21 Dec, 2015 1 commit
  23. 13 Nov, 2015 1 commit
    • jchaffraix's avatar
      ASSERTION FAILED: !m_overflow · ca105404
      jchaffraix authored
      InlineFlowBox doesn't expect m_overflow if knownToHaveNoOverflow is
      set. Unfortunately LayoutListItem was bypassing the normal overflow
      computation and setting m_overflow without knowledge of InlineFlowBox,
      yielding to an ASSERT triggering.
      
      This change refactors the API to prevent manipulations of m_overflow
      without the knowledge of InlineFlowBox, fixing the ASSERT. However it
      is not the right long term fix. LayoutListItem should be fixed to not
      do that as it seems very wrong (https://crbug.com/554160).
      
      BUG=546792
      
      Review URL: https://codereview.chromium.org/1415493008
      
      Cr-Commit-Position: refs/heads/master@{#359601}
      ca105404
  24. 14 Oct, 2015 1 commit
  25. 10 Oct, 2015 1 commit
  26. 01 Oct, 2015 1 commit
    • wangxianzhu's avatar
      Let LayoutObjects be const to painters · 36c3845d
      wangxianzhu authored
      Painters should not modify LayoutObject status except some status
      dedicated for painting. The exceptions are marked mutable.
      
      List of 'mutable's added in this CL:
      - FrameView::m_isPainting: for assertion (in FrameView::layout(),
        Document::updateLayoutTrees() and FramePainter::paintContents()).
        Will change to document cycle states.
      - LayoutObject::BitFields::m_boxDecorationBackgroundState: Lazily
        updated in LayoutObject::boxDecorationBackgroundIsKnownToBeObscured().
      - LayoutTable::m_currentBorder: Used temporarily during painting only.
        Will move into painter.
      
      List of 'const_cast's added in this CL:
      - ImageQualityController::highQualityRepaintTimerFired()
        when invalidating LayoutObject on timer. Will change to
        mutableForPainting[1].
      - LineBoxListPainter::paint()
        This is of const sementics, but LineLayoutBoxModel doesn't support
        const for now (crbug.com/535785)
      - SVGFilterPainter::prepareEffect()
        when calling m_filter.setFilterDataForLayoutObject. TODO(pdr).
      - ScrollbarPainter::paintIntoRect()
        a layer violation that the painter changes geometry of scrollbars.
        There is an existing FIXME.
      - When calling get() on a Map<non-const-pointer, ...>.
      - Used to implement const version of getters based on the non-const
        version.
      
      [1] mutableForPainting: https://codereview.chromium.org/1363613002/#msg6
      
      Review URL: https://codereview.chromium.org/1361363003
      
      Cr-Commit-Position: refs/heads/master@{#351868}
      36c3845d
  27. 25 Sep, 2015 1 commit
    • japhet's avatar
      When style changes, set the LayoutObject as a client for all StyleImage loads · c5ce89c7
      japhet authored
      We have logic to dynamically change an image load's
      ResourceLoadPriority based on whether it is in the viewport. We would like
      to generalize this logic to support other types of resources and other
      factors for priority. To do that, we need to ensure every image that might
      be in the viewport is associated with a LayoutObject, so that it can pull its
      priority state, rather than having the LayoutObject push the state.
      
      We have not been consistent about ensuring that every LayoutObject registers
      itself as a client with every StyleImage in its ComputedStyle. This change
      ensures that we do so.
      
      BUG=536147
      
      Review URL: https://codereview.chromium.org/1362693004
      
      Cr-Commit-Position: refs/heads/master@{#350946}
      c5ce89c7
  28. 17 Aug, 2015 1 commit
  29. 17 Jun, 2015 1 commit
  30. 08 Jun, 2015 1 commit
  31. 07 May, 2015 1 commit
  32. 30 Apr, 2015 1 commit
  33. 25 Apr, 2015 1 commit
  34. 14 Apr, 2015 1 commit
  35. 09 Apr, 2015 1 commit
  36. 02 Apr, 2015 1 commit
  37. 31 Mar, 2015 1 commit
  38. 24 Mar, 2015 1 commit
  39. 07 Mar, 2015 1 commit