GitLab

Because the things in ClassicPendingScript::DisposeInternal() except for
ScriptStreamer::Cancel() doesn't have to be called as a prefinalizer,
this CL introduces ClassicPendingScript::Prefinalize() that only calls
ScriptStreamer::Cancel() and thus makes Dispose() not to be called there.

This CL simplified the prefinalization of ClassicPendingScript, especially
order dependencies between ClassicPendingScript's prefinalizer and the
prefinalizer of its parent class (ResourceOwner).
Leaving ClassicPendingScript in a not-Dispose()d state is not observable
if the related classes obeys the rule of Oilpan, and
https://codereview.chromium.org/2837413002/ checks that in case there were
a bug.

BUG=715309

Review-Url: https://codereview.chromium.org/2844583002
Cr-Commit-Position: refs/heads/master@{#467299}

Bug: 709815
Change-Id: I8f35864239dc5a606b473cdd82add2e68a76cb08
Reviewed-on: https://chromium-review.googlesource.com/487861Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#467298}

Revert of headless: Add support for net logging (patchset #2 id:20001 of https://codereview.chromium.org/2841953002/ )

Reason for revert:

Findit(https://goo.gl/kROfz5) identified CL at revision 467289 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2I5YTQyYWI2ZjA3M2IwNTdjOGMwNWQyYmZjNzk5ZGNjODA4MmUyYTYM

Sheriff's note:
See crbug.com/715513 for details.

Original issue's description:
> headless: Add support for net logging
>
> This patch adds support for the --log-net-log command line flag to
> headless to help diagnosing issues with networking.
>
> BUG=706355
>
> Review-Url: https://codereview.chromium.org/2841953002
> Cr-Commit-Position: refs/heads/master@{#467289}
> Committed: https://chromium.googlesource.com/chromium/src/+/b9a42ab6f073b057c8c05d2bfc799dcc8082e2a6

TBR=eseckler@chromium.org,skyostil@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=706355,715513

Review-Url: https://codereview.chromium.org/2839153002
Cr-Commit-Position: refs/heads/master@{#467297}

+ Correctly focus the inner WebContents when the attachment frame is
  focused.
+ Enable Enable WebViewFocusInteractiveTest.Focus_FocusBeforeNavigation.
+ Prevent BrowserPluginGuest from unfocusing the guest in oopif mode.

BUG=672947
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2715213009
Cr-Commit-Position: refs/heads/master@{#467296}

This is web-exposed via Document and other interfaces.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Bug: 713843
Change-Id: Idff897e4f3177a0ff67ecfda413b8fae9d51f556
Reviewed-on: https://chromium-review.googlesource.com/487882
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#467295}

This new parameter intends to replace or complement the version override
param to distinguish various published versions of Popular Sites.

BUG=715039

Review-Url: https://codereview.chromium.org/2841643005
Cr-Commit-Position: refs/heads/master@{#467294}

Bug: 709815
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I6e5a2665f2b82b993a4544a8cbd052fadc35d987

Change-Id: I6e5a2665f2b82b993a4544a8cbd052fadc35d987
Reviewed-on: https://chromium-review.googlesource.com/487901
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#467293}

Work-around as browser_tests are erroneously not rebuilt properly on
gpu bots.

BUG=chromium:714976
TBR=kbr@chromium.org,fjhenigman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
NOTRY=true

Review-Url: https://codereview.chromium.org/2841833003
Cr-Commit-Position: refs/heads/master@{#467292}

The ServiceWorkerMessageEvent.* files were already removed from BUILD.gn:
https://codereview.chromium.org/2466513002

This inlines the templatized helpers in V8ServiceWorkerMessageEventInternal.h
into non-templated code in V8ExtendableMessageEventCustom.cpp, which is now the
only place the helpers are used.

BUG=659074

Review-Url: https://codereview.chromium.org/2837353003
Cr-Commit-Position: refs/heads/master@{#467291}

This enables birthday doodles.

BUG=715154

Review-Url: https://codereview.chromium.org/2838713003
Cr-Commit-Position: refs/heads/master@{#467290}

This patch adds support for the --log-net-log command line flag to
headless to help diagnosing issues with networking.

BUG=706355

Review-Url: https://codereview.chromium.org/2841953002
Cr-Commit-Position: refs/heads/master@{#467289}

This CL adds some debugging code to try and figure out
why Xvfb is dying on the Site Isolation Linux bot.

R=tansell@chromium.org
BUG=708681

Review-Url: https://codereview.chromium.org/2836403003
Cr-Commit-Position: refs/heads/master@{#467288}

Follow-up to https://codereview.chromium.org/2796643002 where the
metrics were added but an inconsistency was introduced between the C++
enum and the Javascript counterpart. This caused the wrong buckets being
counted for NewTabPage.TileType (ThumbnailLocal instead Thumbnail;
ThumbnailServer instead of ThumbnailFailed). The affected buckets
were already deprecated (DeprecatedThumbnailLocal and
DeprecatedThumbnailServer) and hence, luckily, there are no conflated
buckets.

Besides, histograms.xml was missing the new suffixes for
NewTabPageIconTypes, used to provide desktop-specific breakdowns for
NewTabPage.MostVisited and NewTabPage.SuggestionsImpression.

BUG=714095,703165
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2832173002
Cr-Commit-Position: refs/heads/master@{#467287}

BUG=583292

Review-Url: https://codereview.chromium.org/2811353002
Cr-Commit-Position: refs/heads/master@{#467286}

https://codereview.chromium.org/2518493002 removed the code to reenable
plugins but this doesn't reset the state and end up overwriting the
new pdf/flash setting each time the old prefs are read again.

After the CL the flag was not added to new Preferences files this code only applies to existing legacy settings.

BUG=705979

Review-Url: https://codereview.chromium.org/2841843002
Cr-Commit-Position: refs/heads/master@{#467285}

BUG=715440

Review-Url: https://codereview.chromium.org/2838013005
Cr-Commit-Position: refs/heads/master@{#467284}

This CL allows tasks to be posted via base/task_scheduler/post_task.h
as soon as BrowserMainLoop is instantiated. Tasks don't run until
TaskScheduler::Start() is called in BrowserMainLoop::CreateThreads().

BUG=690706

Review-Url: https://codereview.chromium.org/2835933004
Cr-Commit-Position: refs/heads/master@{#467283}

This is a follow-up to https://codereview.chromium.org/2805683002/

BUG=706310
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2837793003
Cr-Commit-Position: refs/heads/master@{#467282}

Adds the CCTBackgroundTab (ChromeFeatureList::CCT_BACKGROUND_TAB) feature
which is enabled by default.

BUG=708173

Review-Url: https://codereview.chromium.org/2837873002
Cr-Commit-Position: refs/heads/master@{#467281}

Following discussion in https://codereview.chromium.org/2800653002, cookies
are disabled for network request of:
components/policy/core/common/cloud/device_management_service.cc

BUG=

Review-Url: https://codereview.chromium.org/2837123005
Cr-Commit-Position: refs/heads/master@{#467280}

Revert of Decrease swarming shards for Linux RandomOrder bots from 18 to 6. (patchset #1 id:1 of https://codereview.chromium.org/2835903002/ )

Reason for revert:
Want to go back to 18 shards to increase likelihood of single shard failure issues.

Original issue's description:
> Decrease swarming shards for Linux RandomOrder bots from 18 to 6.
>
> Review-Url: https://codereview.chromium.org/2835903002
> Cr-Commit-Position: refs/heads/master@{#466599}
> Committed: https://chromium.googlesource.com/chromium/src/+/e510777b49ba34c52aebc3613552cf2f4acbc2dc

TBR=mcgreevy@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.

Review-Url: https://codereview.chromium.org/2842973002
Cr-Commit-Position: refs/heads/master@{#467279}

This patch matches NGInlineLayoutAlgorithm to CSS2 10.8 Line height
calculations: the 'line-height' and 'vertical-align' properties[1]
defining empty inline elements should influence line height.

Also, since the introduction of NGInlineBoxState, we had two places to
compute the union of boxes; NGInlineBoxState.stack_[0] and
NGLineBoxFragmentBuilder. Some code were uniting boxes to wrong one.
This patch unifies them to NGInlineBoxState.

[1] https://drafts.csswg.org/css2/visudet.html#line-height

BUG=636993

Review-Url: https://codereview.chromium.org/2845493002
Cr-Commit-Position: refs/heads/master@{#467278}

Part of project Ribbon

This refactor is one step in the process of refactoring out property
specific logic inside switch cases in
CSSPropertyParser::ParseSingleValue. This is required to implement the
parseSingleValue methods in the property APIs without passing property
ID to the API.

Given that the IsValidAnimationPropertyList function only ever returned
false if the property passed was CSSPropertyTransitionProperty, this
check was moved to the calling methods.

The next step in this process will be to refactor out the need to pass
property to the ConsumeAnimationPropertyList function. At this stage the
call to IsValidAnimationPropertyList will be moved to the
CSSPropertyTransitionProperty case only and the check for this property
will be removed.

The check for this property in
CSSPropertyParser::ConsumeAnimationShorthand will be refactored out at a
later stage in project Ribbon.

BUG=668012

Review-Url: https://codereview.chromium.org/2835893002
Cr-Commit-Position: refs/heads/master@{#467277}

The enum is unnecessary and is only used in tests. I've introduced an internal
namespace, but I'm happy to change if there's a more idiomatic approach.

BUG=712922

Review-Url: https://codereview.chromium.org/2825943002
Cr-Commit-Position: refs/heads/master@{#467276}

BUG=none

Review-Url: https://codereview.chromium.org/2840003002
Cr-Commit-Position: refs/heads/master@{#467275}

This should look better when the user name is too long.

Before: https://drive.google.com/open?id=0ByXziH_JVCGJRDBwcVNuZHN2QkE
After: https://drive.google.com/open?id=0ByXziH_JVCGJZE1xby10SFFKUTA

Related to b/36958290

BUG=661794

Review-Url: https://codereview.chromium.org/2825293002
Cr-Commit-Position: refs/heads/master@{#467274}

This patch marks tests that were fixed in the 'vertical-align' patch[1]
but were missed and not updated in TestExpectations.

[1] https://codereview.chromium.org/2803433002

BUG=636993

Review-Url: https://codereview.chromium.org/2839733005
Cr-Commit-Position: refs/heads/master@{#467273}

The HTMLElementFactory used to take the form element pointer for form
association. That operation happens as a discrete step now for
customized built-in elements. Now that HTMLElementFactory doesn't do
form association any more, HTML and non-HTML element construction can
be merged together the way they are in the specs.

BUG=648828

Review-Url: https://codereview.chromium.org/2842933002
Cr-Commit-Position: refs/heads/master@{#467272}

Linux 4.9 adds /proc/sys/user/max_user_namespaces to limit the number
of concurrent user namespaces.  Sometimes the limit is set to 0 in
which case clone() will return ENOSPC.  This CL avoids PCHECK()ing in
that case.

BUG=715138
R=mdempsky@chromium.org

Review-Url: https://codereview.chromium.org/2842033002
Cr-Commit-Position: refs/heads/master@{#467271}

FileEntry.file is slow operation internally queries file metadata.
However, FileTransferController calls FileEntry.file for all the
selected files each time CHANGE_THROTTLED event is fired.
CHANGE_THROTTLED is fired every time a file is copied
during multi file copy.
In some slow storage devices which do not support parallel requests
such as MTP connected ones, this severely slows down file copy.

BUG=712121
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2843683002
Cr-Commit-Position: refs/heads/master@{#467270}

This is a preparation CL for https://codereview.chromium.org/2778983006.

There are still other tests which will fail when /deep/ (or ::shadow) is disabled.
These tests are being tracked in meta bug 715034.

BUG=715034

Review-Url: https://codereview.chromium.org/2843883002
Cr-Commit-Position: refs/heads/master@{#467269}

BUG=546953

Review-Url: https://codereview.chromium.org/2843773002
Cr-Commit-Position: refs/heads/master@{#467268}

Mainly, some enums were being displayed in their raw form, due to the
Blink Rename. For example, "kSignalingStateStable" instead of "stable".

BUG=chromium:714375

Review-Url: https://codereview.chromium.org/2832263004
Cr-Commit-Position: refs/heads/master@{#467267}

Review-Url: https://codereview.chromium.org/2837423003
Cr-Commit-Position: refs/heads/master@{#467266}

According to latest changes in specification [1,2], when invalid
NFCPushOptions.timeout is provided to nfc.push function, promise
must be rejected with TypeError.

[1] https://w3c.github.io/web-nfc/#dom-nfc-push
[2] https://github.com/w3c/web-nfc/issues/112

BUG=714035

Review-Url: https://codereview.chromium.org/2836813007
Cr-Commit-Position: refs/heads/master@{#467265}

fileManagerPrivate.getFileTasks is slow.
However, every time a file is copied during multi file copy, the method
was called via CHANGE_THROTTLED event listener.
This CL stops creating FileTasks again when file entries for the
previous FileTasks are same as the current ones.
Other possible solution to this problem is to change C++ interface of
fileManagerPrivate.getFileTasks to support incremental update of
FileTasks.

BUG=462989,712121
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2833413003
Cr-Commit-Position: refs/heads/master@{#467264}

Resulting vector of statuses must have the same size as the given permissions vector.

Review-Url: https://codereview.chromium.org/2838543003
Cr-Commit-Position: refs/heads/master@{#467263}

Currently generated groups such as StyleSurroundData inherit from
RefCounted, which means we have to explicitly specify a copy
constructor. Inheriting from RefCountedCopyable instead means we can
just use the compiler generated copy constructor.

Diff of generated files:
https://gist.github.com/darrnshn/b3f3492858caedc6359a0507dc173dff/revisions

BUG=628043

Review-Url: https://codereview.chromium.org/2799363002
Cr-Commit-Position: refs/heads/master@{#467262}

Introduces assert_promise_event_order_ that checks the order of promise
resolution and events firing is correct.

Makes assert_event_fires_after_promise and assert_event_fires_before_promise
use this function.

Also removes some obsolete TODOs.

BUG=697698

Review-Url: https://codereview.chromium.org/2825393004
Cr-Commit-Position: refs/heads/master@{#467261}

This CL replace DefineOwnProperty with SetNativeDataProperty in
InstallAttributeInternal<v8::Object>() not to create function
templates or instances on feature installations.

This change enables us to use the function for all data properties
and it improves performance of preparing origin-trial features
and dynamic installs of runtime enabled features.

BUG=617892

Review-Url: https://codereview.chromium.org/2815453005
Cr-Commit-Position: refs/heads/master@{#467260}