1. 03 Apr, 2017 1 commit
  2. 24 Mar, 2017 1 commit
  3. 23 Mar, 2017 1 commit
  4. 13 Mar, 2017 1 commit
    • wez's avatar
      Replace use of logging::DEBUG_MODE with DCHECK_IS_ON(). · 8ccfd32a
      wez authored
      DEBUG_MODE was originally provided to allow code of the form:
      
        if (DEBUG_MODE) { ... }
      
      rather than preprocessor conditional (i.e. #ifdef _DEBUG), while
      still ensuring that the condition was static at compile-time, allowing
      the affected code to be trivially optimized-out.
      
      The function-like macro DCHECK_IS_ON(), added to simplify conditional
      compilation of DCHECK-related code when DCHECK_ALWAYS_ON was added, can
      now be used safely for both preprocessor and C++ conditionals in place of
      DEBUG_MODE.
      
      Review-Url: https://codereview.chromium.org/2731823002
      Cr-Commit-Position: refs/heads/master@{#456519}
      8ccfd32a
  5. 08 Mar, 2017 2 commits
    • ymzhang's avatar
      [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. · 2314fa58
      ymzhang authored
      We are adding COMPONENT/TEAM information into OWNERS file
      (domain_reliability, etc).
      
      Proposal to add TEAM/COMPONENT information into OWNERS files
      http://bit.ly/add-team-component-proposal
      Proposal about how to get suggested component for directory.
      http://bit.ly/directory-mapping-proposal
      TEAM-COMPONENT mapping
      http://bit.ly/component-team-mapping
      
      Additional Information:
      Component lists
      https://bugs.chromium.org/p/chromium/adminComponents
      
      BUG=679905
      R=davidben@chromium.org
      
      Review-Url: https://codereview.chromium.org/2740683004
      Cr-Commit-Position: refs/heads/master@{#455597}
      2314fa58
    • scottmg's avatar
      Require explicit selection of traits for LazyInstance · 5e65e3a4
      scottmg authored
      This change requires the user of LazyInstance to explicitly select
      either ::DestructorAtExit or ::Leaky. It seems clear that many users of
      LazyInstance have just gone with default and are either unaware or
      didn't consider that the default requires running an AtExit at process
      shutdown.
      
      As a first step, make this choice explicit, and update current users
      to be ::DestructorAtExit to maintain current behaviour. Follow ups can
      then attempt to consider individual switches from DestructorAtExit to
      Leaky including reviewers with domain-specific knowledge.
      
      i.e. No intended behaviour change from this CL.
      
      R=thakis@chromium.org
      
      Lots of TBRs for mechanical changes:
      boliu: android_webview/
      danakj: cc/
      dmurph: storage/
      jam: content/ ipc/, mojo/
      jbauman: gpu/
      jochen: gin/
      oshima: chromeos/
      raymes: ppapi/
      rdevlin.cronin: extensions/
      rockot: device/, services/
      rogerta: google_apis/
      rsleevi: net/, crypto/
      sdefresne: components/, ios/
      sergeyu: jingle/
      slan: chromecas...
      5e65e3a4
  6. 03 Feb, 2017 1 commit
  7. 30 Jan, 2017 1 commit
  8. 04 Jan, 2017 1 commit
    • davidben's avatar
      Remove the password parameter for ECPrivateKey::ExportEncryptedPrivateKey. · 1c02c94c
      davidben authored
      Even with a password, the encryption scheme used here is really not what
      we'd want people to use. This does two things:
      
      1. Cut down on the number of ways to use ExportEncryptedPrivateKey and
         makes it less likely someone will mistakenly use it for security
         purposes.
      
      2. When we ported to BoringSSL, we added "raw" versions of
         PKCS8_{encrypt,decrypt} to account for confusion about two ways to
         encode the empty password. But PKCS8_{encrypt,decrypt} already
         handled this by treating NULL and "" differently. Limiting to just
         the empty password lets us trim BoringSSL's API surface in
         preparation for decoupling it from crypto/asn1.
      
      BUG=603319
      
      Review-Url: https://codereview.chromium.org/2608453002
      Cr-Commit-Position: refs/heads/master@{#441365}
      1c02c94c
  9. 03 Jan, 2017 1 commit
  10. 07 Dec, 2016 1 commit
    • jbriance's avatar
      Cleanup remaining class/struct fwd declarations · db24b9e6
      jbriance authored
      Remove remaining useless class and struct forward declarations from
      Chromium (excluding third_party directory) using a homemade script
      available in bug 662195 comments. An up-and-running presubmit check
      is now available and should prevent new useless forward declarations
      to come up.
      
      BUG=662195
      CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_nacl_sdk
      
      Review-Url: https://codereview.chromium.org/2554863002
      Cr-Commit-Position: refs/heads/master@{#436883}
      db24b9e6
  11. 05 Dec, 2016 1 commit
  12. 23 Nov, 2016 1 commit
    • jschuh's avatar
      Remove remaining base dependencies from base/numerics · 56e74941
      jschuh authored
      All that was left was base/logging.h. And since this gets pulled in for
      a lot of other projects, it's best to make it dependency clean.
      It also necessitated several IWYU fixes for the missing header.
      
      TBR=jam@chromium.org,
      CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
      
      Review-Url: https://codereview.chromium.org/2523663002
      Cr-Commit-Position: refs/heads/master@{#434057}
      56e74941
  13. 03 Nov, 2016 1 commit
  14. 28 Oct, 2016 1 commit
    • tfarina's avatar
      include boringssl headers from third_party explicitly · 29a3a174
      tfarina authored
      This also allow us to participate in DEPS checking, which will help
      catch instances of directories including BoringSSL without adding to
      build targets.
      
      This patch was partly generated by the following command lines:
      
      $ g grep -l -e '^#[[:blank:]]*include <\(openssl[^>]*\)>' | xargs sed -i
      '/^#[[:blank:]]*include/s/<\(openssl[^>]*\)>/"\1"/'
      $ g grep -l "#include \"openssl/" | xargs sed -i -e 's/\(#.*
      \)"\(openssl\/.*\)"/\1"third_party\/boringssl\/src\/include\/\2"/'
      
      The regex were taken from http://stackoverflow.com/a/25378698 and
      https://svn.boost.org/trac/boost/ticket/12057, and adapted to suit our
      needs.
      
      Then the includes were put in their right places with some manual editing and
      the help of tools/sort-headers.py.
      
      BUG=446558
      R=davidben@chromium.org,thestig@chromium.org,jochen@chromium.org,slan@chromium.org
      
      Review-Url: https://codereview.chromium.org/2449873005
      Cr-Commit-Position: refs/heads/master@{#428442}
      29a3a174
  15. 11 Oct, 2016 1 commit
  16. 08 Oct, 2016 1 commit
  17. 01 Oct, 2016 1 commit
  18. 15 Sep, 2016 1 commit
  19. 01 Sep, 2016 1 commit
    • maruel's avatar
      Delete all test isolate file now that M54 was branched. · 95b6282d
      maruel authored
      The runtime dependencies data was successfully transitioned to GN.
      
      Keep non-testing isolate as some projects (v8, webrtc) still need some. They
      will be curated incrementally.
      
      Ran:
        $ git rm $(git ls-files -- "*.isolate" | grep -i test | grep -v testserver)
        $ git ls-files -- "*.isolate" | wc -l
        14
      
      TBR=dpranke@chromium.org
      BUG=
      CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
      
      Review-Url: https://codereview.chromium.org/2257893002
      Cr-Commit-Position: refs/heads/master@{#415954}
      95b6282d
  20. 30 Aug, 2016 2 commits
  21. 25 Aug, 2016 1 commit
  22. 12 Aug, 2016 1 commit
  23. 05 Aug, 2016 1 commit
  24. 14 Jul, 2016 1 commit
    • brettw's avatar
      Convert some GN test support targets to static libs. · 2dbbe5b0
      brettw authored
      Converts some source sets that were source sets into static libraries. Converts additional targets in the touched files to static libraries where it seemed relevant.
      
      Update the definition of //crypto:test_support to mark it testonly and make the conditions append sources rather than subtract them in the reverse condition.
      
      A few redundant dependencies were removed (one shouldn't need to specify both "foo" and "foo:test_support").
      
      BUG=627637
      CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
      
      Review-Url: https://codereview.chromium.org/2151653003
      Cr-Commit-Position: refs/heads/master@{#405544}
      2dbbe5b0
  25. 13 Jul, 2016 1 commit
    • agl's avatar
      Switch to OpenSSL's |EVP_PKEY_up_ref| signature. · 5a7cadf1
      agl authored
      |EVP_PKEY_up_ref| was a BoringSSL addition to OpenSSL The next major,
      public OpenSSL release will include it, but it'll return 0/1 rather than
      the object being referenced.
      
      This change updates Chromium to expect that function signature (in a
      backwards compatible way). Once all callers have been updated likewise,
      BoringSSL will align this function with upstream OpenSSL.
      
      BUG=none
      
      Review-Url: https://codereview.chromium.org/2113143004
      Cr-Commit-Position: refs/heads/master@{#405192}
      5a7cadf1
  26. 29 Jun, 2016 1 commit
  27. 28 Jun, 2016 1 commit
  28. 22 Jun, 2016 1 commit
  29. 08 Jun, 2016 1 commit
    • fdoray's avatar
      Remove use of deprecated MessageLoop methods in crypto. · 34e1fb87
      fdoray authored
      MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon
      are deprecated. This CL makes the following replacements to
      remove some uses of these methods:
      
      "MessageLoop::current()->PostTask" ->
        "ThreadTaskRunnerHandle::Get()->PostTask"
      "MessageLoop::current()->PostDelayedTask" ->
        "ThreadTaskRunnerHandle::Get()->PostDelayedTask"
      "MessageLoop::current()->DeleteSoon" ->
        "ThreadTaskRunnerHandle::Get()->DeleteSoon"
      "MessageLoop::current()->ReleaseSoon" ->
        "ThreadTaskRunnerHandle::Get()->ReleaseSoon"
      
      In files where these replacements are made, it adds these includes:
        #include "base/location.h"
        #include "base/single_thread_task_runner.h"
        #include "base/threading/thread_task_runner_handle.h"
      
      And removes this include if it is no longer required:
        #include "base/message_loop/message_loop.h"
      
      Why ThreadTaskRunnerHandle::Get() instead of
      MessageLoop::current()->task_runner()?
       - The two are equivalent on threads that run a MessageLoop.
       - MessageLoop::current() doesn't work in base/task_scheduler
         because the scheduler's thread don't run MessageLoops.
         This CL will therefore facilitate the migration of browser
         threads to base/task_scheduler.
      
      Steps to generate this patch:
      1. Run message_loop_cleanup.py (see code on the bug).
      2. Run tools/sort-headers.py on modified files.
      3. Run git cl format.
      
      BUG=616447
      R=agl@chromium.org
      
      Review-Url: https://codereview.chromium.org/2033193002
      Cr-Commit-Position: refs/heads/master@{#398549}
      34e1fb87
  30. 07 Jun, 2016 2 commits
    • rsleevi's avatar
      Remove traces of USE_NSS_CERTS from crypto/ · a3ad8d0b
      rsleevi authored
      NSS is no longer an option as the cryptographic service
      provider - all platforms have transitioned to using BoringSSL. Any remaining files in crypto/ that use NSS will always have USE_NSS_CERTS set.
      
      This also fixes some unit tests that used the wrong ifdefs once
      everything was converted to use BoringSSL.
      
      BUG=604728
      
      Review-Url: https://codereview.chromium.org/2046863002
      Cr-Commit-Position: refs/heads/master@{#398348}
      a3ad8d0b
    • davidben's avatar
      Add PKCS#8 ECPrivateKey export/import functions. · 212cdf69
      davidben authored
      Also const-correct a few functions and add some missing error tracers.
      Deprecate the old ones. Also const-correct a few functions and add some missing
      error tracers. Future work migrate existing serializations to the new format.
      
      BUG=603319
      
      Review-Url: https://codereview.chromium.org/1935053003
      Cr-Commit-Position: refs/heads/master@{#398318}
      212cdf69
  31. 11 May, 2016 1 commit
    • rsesek's avatar
      [Mac/GN] Set up the component build. · 02aa51cf
      rsesek authored
      This adds the required framework to libs[] wherever they are required (most
      of the changes in this CL). It also enables the component build optimization
      of creating a non-bundled dylib to roll up all the sources and dependencies.
      The framework then links that, which allows the build to not copy the bundled
      library if any sources change. This is based on the technique implemented
      https://codereview.chromium.org/11420019/.
      
      BUG=431177
      R=thakis@chromium.org,brettw@chromium.org
      CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
      
      Review-Url: https://codereview.chromium.org/1961473003
      Cr-Commit-Position: refs/heads/master@{#392823}
      02aa51cf
  32. 10 May, 2016 1 commit
    • brettw's avatar
      Address more TODO(GYP) in the GN build. · 57399c53
      brettw authored
      Addresses another batch of TODO(GYP) annotations in GN files.
      
      Removes all references to msvs_shard which is not necesasary in the GN build.
      
      A number of these were related to things to support the nacl64 build. In GN we just do cross-compiles of the fill targets. This seems to be working OK. Probably the sizes can be brought down a bit by optimizing this and producing nacl-specific targets with only the bare necessities, but it seems the marginal benefit doesn't outweigh the build complexity.
      
      TBR=thestig@chromium.org for linux/build (comment change)
      
      Review-Url: https://codereview.chromium.org/1957683002
      Cr-Commit-Position: refs/heads/master@{#392660}
      57399c53
  33. 02 May, 2016 2 commits
  34. 26 Apr, 2016 1 commit
    • svaldez's avatar
      Renaming _openssl files to _impl · e83af293
      svaldez authored
      Since we no longer have NSS implementations, we rename all the _openssl
      specific implementations to _impl to align with the rest of the code
      base.
      
      TBR=kelvinp@chromium.org
      R=davidben@chromium.org, kelvinp@chromium.org
      BUG=604728
      
      Review URL: https://codereview.chromium.org/1921563003
      
      Cr-Commit-Position: refs/heads/master@{#389776}
      e83af293
  35. 21 Apr, 2016 2 commits