GitLab

Replaced all *_EXPORT_PRIVATE macros with *_EXPORT except for /net, /sync and
/storage.

BUG=552248
TEST=No functionality change.

Review URL: https://codereview.chromium.org/1413173005

Cr-Commit-Position: refs/heads/master@{#358362}

This CL needs memory suppression because of missing CloseTestNSSDB().
See also TODO.

BUG=136950, 156433


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162327

Review URL: https://chromiumcodereview.appspot.com/11174006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162659 0039d316-1c4b-4281-b951-d872f2087c98

BUG=136950


Review URL: https://chromiumcodereview.appspot.com/11174006

TBR=toyoshim@chromium.org
BUG=156433
Review URL: https://codereview.chromium.org/11196028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162511 0039d316-1c4b-4281-b951-d872f2087c98

BUG=136950


Review URL: https://chromiumcodereview.appspot.com/11174006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162327 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10695140

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146077 0039d316-1c4b-4281-b951-d872f2087c98

With the current setup, if you have a header file my_class.h

class BASE_EXPORT MyClass {
 public:
  void MyInlineMethod() { /* do stuff, inline */ }
};

then every cc file that includes my_class.h will have a public symbol
for MyInlineMethod (because inline methods need to be emitted to
every translation unit, and the linker sorts them out). With the
components build, the linker can't decide to drop these inline methods,
so every .so that uses this header file will have the same public symbol.

With this proposed change, the symbol will only be visible in the target
the header file belongs to, and it will be hidden in all other components.
That's cleaner, and it also prevents accident hidden dependencies (say
target A depends on B, and B depends on C. A accidentally uses an inline
function from a class in C. With this change, that would result in a linker
error, and an explicit dependency from A on C would have to be added).

Also add a missing CHROMEOS_IMPLEMENTATION define which went
unnoticed until now.

BUG=90078
TEST=Things still build.
TBR=ben, tony, viettrungluu, thestig, agl, willchan

Review URL: https://chromiumcodereview.appspot.com/10386108

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137130 0039d316-1c4b-4281-b951-d872f2087c98

R=rvargas@chromium.org
Review URL: http://codereview.chromium.org/7491061

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95652 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=try

Review URL: http://codereview.chromium.org/7375016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93026 0039d316-1c4b-4281-b951-d872f2087c98

This avoids the need to define FOO_DLL macros for each project that we wish to
optionally build as a DLL (when component=="shared_library").  This in turn
means that we do not need direct_dependent_settings to define FOO_DLL, and that
means that we don't need to update projects to convert transitive dependencies
into explicit dependencies.  This makes the component build more consistent
with the static build.

An alternative would be to use all_dependent_settings, but I feel that the
global approach is simpler as it creates less repetition in each target
definition for components.

A side-effect of this change is that I needed to make base_nacl_win64 be a
shared_library in the component build.

R=rvargas,bradnelson,evan
Review URL: http://codereview.chromium.org/7344022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92409 0039d316-1c4b-4281-b951-d872f2087c98

The change broke compilation on Linux Builder (dbg)(shared):
http://build.chromium.org/p/chromium/builders/Linux%20Builder%20%28dbg%29%28shared%29/builds/3365/steps/compile/logs/stdio

TBR=darin
BUG=None
TEST=None

Review URL: http://codereview.chromium.org/7352014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92329 0039d316-1c4b-4281-b951-d872f2087c98

This avoids the need to define FOO_DLL macros for each project that we wish to
optionally build as a DLL (when component=="shared_library").  This in turn
means that we do not need direct_dependent_settings to define FOO_DLL, and that
means that we don't need to update projects to convert transitive dependencies
into explicit dependencies.  This makes the component build more consistent
with the static build.

An alternative would be to use all_dependent_settings, but I feel that the
global approach is simpler as it creates less repetition in each target
definition for components.

A side-effect of this change is that I needed to make base_nacl_win64 be a
shared_library in the component build.

R=rvargas,bradnelson

Review URL: http://codereview.chromium.org/7344022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92325 0039d316-1c4b-4281-b951-d872f2087c98

a shared net library on Linux, and update base and
crypto API definitions.

BUG=76997
TEST=none
Review URL: http://codereview.chromium.org/7240021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91234 0039d316-1c4b-4281-b951-d872f2087c98

crypto_unittests.

BUG=85776
TEST=none
Review URL: http://codereview.chromium.org/7168004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89551 0039d316-1c4b-4281-b951-d872f2087c98