Skip to content
  • Lukasz Anforowicz's avatar
    Removing callers of the WebContents::GetRenderProcessHost() method. · 705c3935
    Lukasz Anforowicz authored
    WebContents::GetRenderProcessHost is an API that doesn't behave as
    expected with out-of-process iframes, as multiple processes can be
    associated with a single WebContents.  This CL replaces callers of this
    API, so that they go through an equivalent API that explicitly selects
    which frame's process is needed.
    
    This CL was started by using an ad-hoc clang-plugin that replaced
    existing callsites of WebContents::GetRenderProcessHost() with a call to
    something like wc->GetMainFrame()->GetProcess().  This was followed-up
    by manually adding an include of render_frame_host.h and git cl format
    and git cl lint and then a self-review with small tweaks (e.g. sometimes
    using a wc->GetRenderViewHost()->GetProcess() is more appropriate).
    
    This CL was uploaded by git cl split.
    
    R=thestig@chromium.org
    
    Bug: 666525
    Change-Id: If9b034c86f4332d9196e759cc948dca8c3d9ce17
    Reviewed-on: https://chromium-review.googlesource.com/689125
    
    
    Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
    Commit-Queue: Lei Zhang <thestig@chromium.org>
    Reviewed-by: default avatarLei Zhang <thestig@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#504921}
    705c3935