• sergeyu's avatar
    Fix IceTransportTest.TestBrokenTransport · 785b2e72
    sergeyu authored
    Previously the test wasn't verifying what it's supposed to verify and
    was flaky, particularly on DrMemory bots. The test attemps to connect
    two IceTransport instances with settings that should prevent them from
    connecting and verifies that they fail to connect. There were two issues:
     1. NetworkSettings were not passed to IceTransport objects properly,
        so they could still connect.
     2. The test was just calling RunLoopUntilIdle() and wasn't waiting
        for transport failure, so in most cases the test would pass even if
        the transports could connect, which masked (1).
    
    Fixed both issues.
    
    BUG=585531
    
    Review URL: https://codereview.chromium.org/1687543002
    
    Cr-Commit-Position: refs/heads/master@{#374536}
    785b2e72
network_settings.h 1.91 KB