Skip to content
  • ajwong@chromium.org's avatar
    Callback API Change: Reimplement Bind(); support IgnoreResult, full currying, and use less types. · 7296f276
    ajwong@chromium.org authored
    The main API change IgnoreResult() and fully currying.  See unittest for what the new API looks like.  The rest of the changes are done to support that.
    
    Previously, IgnoreReturn could not be used with WeakPtr<> Bind()s as it was applied after the fact to the Callback object.  Now, IgnoreResult() wraps the function like Unretained().
    
    As an incidental benefit, the new implementation gave us fully currying for free.
    
    Also, the new implementation scales better when supporting higher arities of functions.  The new type growth is:
    
      (n^2 + 20n) / 2
    
    as opposed to
    
      (3n^2 + 17n) / 2
    
    where n == arity.
    
    For n = 6 and n=10, the new implementation has 81 and 155 templates respectively.
    
    The old implementation had 105 and 235 templates respectively.
    
    BUG=35233,98919,98542
    TEST=existing unittests
    
    Review URL: http://codereview.chromium.org/8483003
    
    git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110975 0039d316-1c4b-4281-b951-d872f2087c98
    7296f276