• brettw's avatar
    New build flag system, convert Google Now flag · 06c2ba31
    brettw authored
    This generates headers with build flags rather than forcing them all to be global. It includes an accessor wrapper so that references to the flags will fail if the proper header is not included.
    
    Converts Google Now to use this and remove the global google now define and grit define.
    
    Adds support for grit define values of "true" and "false" for ease of integration with GN (they are mapped to the corresponding Python "True" and "False").
    
    Adds dependencies from the main gyp targets to the new generated feature define target. Since GYP only does hard dependencies one level, this should reduce the chance that somebody adds more of these cases and forces to add a dependency.
    
    Reland of https://codereview.chromium.org/1475513006/
    Reland of https://codereview.chromium.org/1458653002/
    TBR=mark@chromium.org
    
    Review URL: https://codereview.chromium.org/1469383005
    
    Cr-Commit-Position: refs/heads/master@{#361854}
    06c2ba31
write_buildflag_header.py 3.14 KB