Skip to content
  • pavor's avatar
    Fix PlatformInfo variation for mime util IsCodecSupportedOnAndroidTest · 56a00719
    pavor authored
    The parameterized template function RunCodecSupportTest is supposed to
    invoke tested callback with different combinations of PlatformInfo settings,
    but it actually used only initial values of PlatformInfo fields.
    
    Also it seems that H264 is always supported for non-encrypted video, so the
    test IsCodecSupportedOnAndroidTest.ClearCodecBehavior should be corrected.
    This has been revealed only after fixing parameter variation.
    
    Initial changeset https://codereview.chromium.org/2804883007 was reverted,
    I was accessing a vector at index just before checking the index vs
    vector size. This time I moved access of the states vector into loop body,
    and split RUN_TEST_VECTOR into two macros: RUN_TEST_VECTOR_BEGIN and
    RUN_TEST_VECTOR_END.
    
    R=chcunningham, dalecurtis
    BUG=709428
    
    Review-Url: https://codereview.chromium.org/2808373002
    Cr-Commit-Position: refs/heads/master@{#463968}
    56a00719