Skip to content
  • brettw's avatar
    GN Windows component build fixes · 51d04a1d
    brettw authored
    The main thing this fixes is the midi component. Previously midi_unittests was never compiled on any Windows component bot and the component build was all messed up. This patch makes the component build work correctly for this component.
    
    Remove installer_util_unittests.rc and its header. These seem to be autogenerated Visual Studio files. They just include the strings resource file, but GN includes the strings resource file itself by nature of the dependencies (GYP doesn't do this).
    
    CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg
    BUG=470212
    
    Review URL: https://codereview.chromium.org/1121363002
    
    Cr-Commit-Position: refs/heads/master@{#328383}
    51d04a1d