Skip to content
  • emircan's avatar
    Reland: Use GpuMemoryBufferVideoFramePool for WebMediaPlayerMS and MediaStreamVideoRendererSink · c1463d52
    emircan authored
    Relanding after expanding a DCHECK on CopyFrameToYV12() of wedmediaplayer_ms.cc
    
    TBR=dcastagna@chromium.org, phoglund@chromium.org, mcasas@chromium.org, sievers@chromium.org, xhwang@chromium.org, rationale: this patch is equivalent
    to the already LGTMd
    
    Original description ---------------------------------------------------
    Use GpuMemoryBufferVideoFramePool for WebMediaPlayerMS and MediaStreamVideoRendererSink
    
    MediaStreamVideoRendererSink is the common sink for video playback where we receive both the local camera capture frame and all the remote capture frames from peer connections. They are all hooked to the MediaStream elements.
    
    This CL follows dcastagna's CL that applies asynchronous copies to WebMediaPlayerimpl [0].
    [0] https://codereview.chromium.org/1273943002/
    
    BUG=440843, 503835
    TEST=
    On Linux:
    - With and Without the kUseGpuMemoryBuffersForCapture flag, AppRTC loopback runs as expected.
    - With and Without the kEnableGpuMemoryBufferVideoFrames flag, AppRTC loopback runs as expected
    
    Committed: https://crrev.com/d49c3945570e7eff2ce728927f8c9fecd04f3487
    Cr-Commit-Position: refs/heads/master@{#353839}
    
    patch from issue 1358883003 at patchset 310001 (http://crrev.com/1358883003#ps310001)
    
    Review URL: https://codereview.chromium.org/1407703003
    
    Cr-Commit-Position: refs/heads/master@{#354087}
    c1463d52