Skip to content
  • csharrison's avatar
    Don't remove CSSPreloaderResourceClient for unused speculative markup preloads · dff0384e
    csharrison authored
    The CSS @import scanner attaches a passive resource client to a css
    preload request. This passive client should not affect the policy
    decisions of the preload and should just observe notifications passively.
    
    This patch fixes a bug where removing a passive client from an otherwise
    unused preload ends up cancelling it, which removes the preload from
    memory cache. This is very wrong behavior, and causes the optimization
    to be less effective, and report bad metrics.
    
    Simply not removing the client will not cause the resource to live
    longer than necessary, because the client holds only weak references
    to the resource.
    
    BUG=670295,662999
    
    Review-Url: https://codereview.chromium.org/2542183002
    Cr-Commit-Position: refs/heads/master@{#436312}
    dff0384e