Commit e9b2ece8 authored by jbriance's avatar jbriance Committed by Commit bot

remoting: Cleanup class/struct fwd declarations

Remove useless class and struct forward declarations, and add
missing ones in remoting header files.

BUG=662195

Review-Url: https://codereview.chromium.org/2538183002
Cr-Commit-Position: refs/heads/master@{#435574}
parent 7497990e
......@@ -37,10 +37,8 @@ class TransportContext;
class VideoRenderer;
} // namespace protocol
class AudioDecodeScheduler;
class ClientContext;
class ClientUserInterface;
class FrameConsumerProxy;
class ChromotingClient : public SignalStrategy::Listener,
public protocol::ConnectionToHost::HostEventCallback,
......
......@@ -18,7 +18,6 @@ class DesktopFrame;
namespace remoting {
class GlCanvas;
class GlRenderLayer;
// This class draws the desktop on the canvas.
class GlDesktop {
......
......@@ -35,7 +35,6 @@
namespace remoting {
// class AudioPlayerIos;
class AudioConsumer;
class ClientProxy;
class ClientStatusLogger;
class FrameConsumerBridge;
......
......@@ -25,16 +25,13 @@ namespace remoting {
namespace protocol {
class ClipboardEvent;
class CursorShapeInfo;
class PerformanceTracker;
class FrameConsumer;
class VideoRenderer;
} // namespace protocol
class AudioPlayerAndroid;
class ChromotingJniRuntime;
class JniClient;
class DisplayHandler;
class JniPairingSecretFetcher;
// ChromotingJniInstance is scoped to the session.
......
......@@ -23,8 +23,6 @@ class VideoRenderer;
} // namespace protocol
class ChromotingJniRuntime;
class DualBufferFrameConsumer;
class EglThreadContext;
// Handles OpenGL display operations. Draws desktop and cursor on the OpenGL
// surface. The handler should be used and destroyed on the UI thread. It also
......
......@@ -44,7 +44,6 @@ class DictionaryValue;
namespace pp {
class InputEvent;
class Module;
class VarDictionary;
} // namespace pp
......
......@@ -16,7 +16,6 @@ class InputEvent;
namespace remoting {
namespace protocol {
class InputStub;
class InputEventTracker;
} // namespace protocol
......
......@@ -19,8 +19,6 @@ class Instance;
namespace remoting {
class PepperInputHandler;
class PepperMouseLocker : public pp::MouseLock,
public protocol::CursorShapeStub {
public:
......
......@@ -8,8 +8,6 @@
#include "remoting/protocol/video_renderer.h"
namespace webrtc {
class DesktopSize;
class DesktopVector;
class DesktopRegion;
} // namespace webrtc
......@@ -20,12 +18,6 @@ class View;
namespace remoting {
class ClientContext;
namespace protocol {
class FrameStatsConsumer;
} // namespace protocol
// Interface for video renderers that render video in pepper plugin.
class PepperVideoRenderer : public protocol::VideoRenderer {
public:
......
......@@ -29,7 +29,6 @@ class ScopedClosureRunner;
namespace webrtc {
class DesktopFrame;
class SharedDesktopFrame;
} // namespace webrtc
namespace remoting {
......
......@@ -14,6 +14,10 @@
#include "base/memory/ref_counted.h"
#include "remoting/host/desktop_environment.h"
namespace base {
class SingleThreadTaskRunner;
}
namespace webrtc {
class DesktopCaptureOptions;
......
......@@ -34,10 +34,6 @@
#include "remoting/protocol/video_stream.h"
#include "third_party/webrtc/modules/desktop_capture/desktop_geometry.h"
namespace base {
class SingleThreadTaskRunner;
} // namespace base
namespace remoting {
class AudioStream;
......
......@@ -23,10 +23,6 @@ class DesktopCaptureOptions;
namespace remoting {
namespace protocol {
class CursorShapeInfo;
} // namespace protocol
// DesktopCapturerProxy is responsible for calling webrtc::DesktopCapturer on
// the capturer thread and then returning results to the caller's thread.
// GetSourceList() and SelectSource() functions are not implemented by this
......
......@@ -14,10 +14,6 @@
#include "base/memory/weak_ptr.h"
#include "remoting/host/desktop_environment_options.h"
namespace base {
class SingleThreadTaskRunner;
} // namespace base
namespace webrtc {
class DesktopCapturer;
class MouseCursorMonitor;
......@@ -25,10 +21,6 @@ class MouseCursorMonitor;
namespace remoting {
namespace protocol {
class ClientStub;
} // namespace protocol
class AudioCapturer;
class ClientSessionControl;
class InputInjector;
......
......@@ -26,7 +26,6 @@ class ChannelProxy;
namespace remoting {
class AutoThreadTaskRunner;
class DesktopEnvironment;
class DesktopEnvironmentFactory;
class DesktopSessionAgent;
......
......@@ -29,7 +29,6 @@
namespace base {
class TimeDelta;
class SingleThreadTaskRunner;
} // namespace base
namespace remoting {
......
......@@ -21,7 +21,6 @@ class SingleThreadTaskRunner;
namespace remoting {
class AutoThreadTaskRunner;
class HostStatusMonitor;
// A HostStatusObserver to block screen saver from taking effect during the
......
......@@ -7,12 +7,7 @@
#include <string>
namespace net {
class IPEndPoint;
} // namespace net
namespace remoting {
class SignalStrategy;
namespace protocol {
struct TransportRoute;
......
......@@ -31,7 +31,6 @@ class ChromotingHost;
class ChromotingHostContext;
class DesktopEnvironmentFactory;
class HostEventLogger;
class HostNPScriptObject;
class HostStatusLogger;
class PolicyWatcher;
class RegisterSupportHostRequest;
......
......@@ -18,7 +18,6 @@
#include "remoting/host/native_messaging/native_messaging_writer.h"
namespace base {
class DictionaryValue;
class Value;
} // namespace base
......
......@@ -10,8 +10,6 @@
namespace remoting {
class DaemonInstallerWin;
class DaemonControllerDelegateWin : public DaemonController::Delegate {
public:
DaemonControllerDelegateWin();
......
......@@ -14,10 +14,6 @@
#include "remoting/host/setup/oauth_client.h"
namespace net {
class URLRequestContext;
}
namespace remoting {
// A wrapper around gaia::GaiaOAuthClient that provides a more
......
......@@ -25,10 +25,6 @@ class SingleThreadTaskRunner;
class Value;
} // namespace base
namespace gaia {
class GaiaOAuthClient;
} // namespace gaia
namespace remoting {
namespace protocol {
......
......@@ -15,6 +15,8 @@
namespace remoting {
class RsaKeyPair;
// This class dispenses |TokenValidator| implementations that use a UrlFetcher
// to contact a |token_validation_url| and exchange the |token| for a
// |shared_secret|.
......
......@@ -20,7 +20,6 @@
#include "net/base/backoff_entry.h"
namespace base {
class SingleThreadTaskRunner;
class TimeDelta;
} // namespace base
......
......@@ -14,14 +14,9 @@
#include "remoting/protocol/audio_stub.h"
#include "remoting/protocol/channel_dispatcher_base.h"
namespace net {
class StreamSocket;
} // namespace net
namespace remoting {
namespace protocol {
class Session;
class SessionConfig;
class AudioWriter : public ChannelDispatcherBase,
......
......@@ -16,8 +16,6 @@ namespace remoting {
namespace protocol {
class ClientStub;
class ControlMessage;
class Session;
// ClientControlDispatcher dispatches incoming messages on the control
// channel to ClientStub, ClipboardStub or CursorShapeStub.
......
......@@ -17,7 +17,6 @@
namespace remoting {
namespace protocol {
class ClientStub;
class VideoStatsStub;
class ClientVideoStatsDispatcher : public ChannelDispatcherBase {
......
......@@ -17,8 +17,6 @@ class DesktopCapturer;
namespace remoting {
class VideoEncoder;
namespace protocol {
class AudioStream;
......
......@@ -20,7 +20,6 @@ namespace remoting {
namespace protocol {
class AudioStub;
class Authenticator;
class ClientStub;
class ClipboardStub;
class HostStub;
......
......@@ -11,16 +11,11 @@
#include "remoting/protocol/clipboard_stub.h"
#include "remoting/protocol/cursor_shape_stub.h"
namespace net {
class StreamSocket;
} // namespace net
namespace remoting {
namespace protocol {
class HostStub;
class PairingResponse;
class Session;
// HostControlDispatcher dispatches incoming messages on the control
// channel to HostStub or ClipboardStub, and also implements ClientStub and
......
......@@ -14,7 +14,6 @@
namespace remoting {
namespace protocol {
class EventMessage;
class InputStub;
// HostEventDispatcher dispatches incoming messages on the event
......
......@@ -18,7 +18,6 @@ class AudioControl;
class Capabilities;
class ClientResolution;
class ExtensionMessage;
class PairingResponse;
class PairingRequest;
class VideoControl;
......
......@@ -26,8 +26,6 @@ class AudioWriter;
class HostControlDispatcher;
class HostEventDispatcher;
class HostVideoDispatcher;
class VideoFeedbackStub;
class VideoFramePump;
// This class represents a remote viewer connection to the chromoting
// host. It sets up all protocol channels and connects them to the
......
......@@ -30,6 +30,7 @@ class TransportChannelImpl;
namespace remoting {
namespace protocol {
class P2PDatagramSocket;
class TransportContext;
class IceTransportChannel : public sigslot::has_slots<> {
......
......@@ -24,7 +24,6 @@ class IqSender;
namespace protocol {
class JingleSession;
class TransportFactory;
// JingleSessionManager and JingleSession implement the subset of the
// Jingle protocol used in Chromoting. JingleSessionManager provides
......
......@@ -34,6 +34,9 @@
#include "third_party/webrtc/libjingle/xmllite/xmlelement.h"
namespace remoting {
class VideoEncoder;
namespace protocol {
class MockAuthenticator : public Authenticator {
......
......@@ -12,17 +12,10 @@
#include "remoting/protocol/session_config.h"
#include "remoting/protocol/transport.h"
namespace buzz {
class XmlElement;
} // namespace buzz
namespace remoting {
namespace protocol {
class Authenicator;
class StreamChannelFactory;
class Transport;
struct TransportRoute;
// Session is responsible for initializing and authenticating both incoming and
// outgoing connections. It uses TransportInfoSink interface to pass
......
......@@ -14,8 +14,6 @@
namespace remoting {
class RsaKeyPair;
namespace protocol {
// The |TokenValidator| encapsulates the parameters to be sent to the client
......
......@@ -18,17 +18,10 @@ namespace buzz {
class XmlElement;
} // namespace buzz
namespace webrtc {
class PeerConnectionInterface;
} // namespace webrtc
namespace remoting {
namespace protocol {
class Authenticator;
class DatagramChannelFactory;
class P2PDatagramSocket;
class StreamChannelFactory;
enum class TransportRole {
SERVER,
......
......@@ -17,8 +17,6 @@ class SingleThreadTaskRunner;
namespace remoting {
namespace protocol {
class AudioStub;
// Audio module passed to WebRTC. It doesn't access actual audio devices, but it
// provides all functionality we need to ensure that audio streaming works
// properly in WebRTC. Particularly it's responsible for calling AudioTransport
......
......@@ -19,8 +19,6 @@ class AudioTrackSinkInterface;
namespace remoting {
class AudioPacket;
namespace protocol {
class AudioSource;
......
......@@ -14,7 +14,6 @@ namespace remoting {
namespace protocol {
struct HostFrameStats;
class VideoChannelStateObserver;
class WebrtcDummyVideoEncoderFactory;
// An abstract interface for frame schedulers, which are responsible for
......
......@@ -30,7 +30,6 @@ namespace protocol {
class MessagePipe;
class VideoRenderer;
class WebrtcTransport;
struct ClientFrameStats;
struct HostFrameStats;
......
......@@ -23,8 +23,6 @@
namespace webrtc {
class MediaStreamInterface;
class PeerConnectionInterface;
class PeerConnectionFactoryInterface;
class VideoTrackInterface;
} // namespace webrtc
namespace remoting {
......@@ -33,7 +31,6 @@ namespace protocol {
class HostVideoStatsDispatcher;
class WebrtcFrameScheduler;
class WebrtcTransport;
class WebrtcVideoCapturerAdapter;
class WebrtcVideoStream : public VideoStream,
public webrtc::DesktopCapturer::Callback,
......
......@@ -17,7 +17,6 @@
namespace base {
class RunLoop;
class Timer;
class Lock;
}
namespace remoting {
......
......@@ -14,9 +14,6 @@
#include "net/url_request/url_fetcher_delegate.h"
#include "remoting/test/app_remoting_service_urls.h"
namespace net {
class UrlFetcher;
}
namespace remoting {
class URLRequestContextGetter;
}
......
......@@ -11,17 +11,11 @@
#include "base/threading/thread_checker.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace base {
class RunLoop;
class Timer;
}
namespace remoting {
namespace test {
class ConnectionTimeObserver;
class TestChromotingClient;
struct HostInfo;
// Provides chromoting connection capabilities for tests to use. Performance
// metrics of the established connection are readily available to calculate
......
......@@ -12,7 +12,6 @@
namespace base {
class TimeDelta;
class Timer;
}
namespace remoting {
......
......@@ -15,9 +15,6 @@
#include "net/url_request/url_fetcher_delegate.h"
#include "remoting/test/host_info.h"
namespace net {
class UrlFetcher;
}
namespace remoting {
class URLRequestContextGetter;
}
......
......@@ -15,9 +15,6 @@
#include "remoting/test/app_remoting_service_urls.h"
#include "remoting/test/remote_host_info.h"
namespace net {
class UrlFetcher;
}
namespace remoting {
class URLRequestContextGetter;
}
......
......@@ -20,7 +20,6 @@
namespace remoting {
class ClientContext;
class XmppSignalStrategy;
namespace protocol {
class ClipboardStub;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment