1. 14 Nov, 2017 1 commit
  2. 13 Nov, 2017 1 commit
  3. 11 Nov, 2017 1 commit
    • Evan Stade's avatar
      Move knowledge of screen lock state out of MessageCenter, confine to · 0798aac5
      Evan Stade authored
      MessageCenterView.
      
      - Update login state notification blocker to hide all notifications in
        message center when screen is locked to maintain the behavior:
            "Don't make notifications read when opening the message 
             center on lock screen"
      - Remove methods/variables/structs related to UnreadCount, which is
        not used anywhere except in tests.
      - It's questionable whether we have any reason to still track is_read
        at all, but it's used for UMA in at least one place.
      
      Bug: 755413
      Change-Id: Ic00a24900992735870338a9544e6af61da744974
      Reviewed-on: https://chromium-review.googlesource.com/757132Reviewed-by: 's avatarJames Cook <jamescook@chromium.org>
      Commit-Queue: Evan Stade <estade@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#515765}
      0798aac5
  4. 07 Nov, 2017 1 commit
  5. 18 Oct, 2017 1 commit
    • Tetsui Ohkubo's avatar
      Close message center on another window activation. · 4c8f4342
      Tetsui Ohkubo authored
      Previously, message center was closed only when
      WebNotificationTray::ClickedOutsideBubble() was called.
      As a result, when a user opens the launcher by Search key,
      message center bubble remained open.
      
      This CL also closes the bubble when another window is activated.
      The implementation is based on SystemTray::ActivationObserver.
      
      TEST=WebNotificationTrayTest.CloseOnActivation
      BUG=757979
      
      Change-Id: Ifea4c2cc56cfe4ca7b0ecfc065426cc30eccc512
      Reviewed-on: https://chromium-review.googlesource.com/716441Reviewed-by: 's avatarMitsuru Oshima <oshima@chromium.org>
      Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#509685}
      4c8f4342
  6. 09 Oct, 2017 1 commit
  7. 02 Oct, 2017 1 commit
  8. 06 Sep, 2017 1 commit
  9. 01 Sep, 2017 1 commit
  10. 18 Aug, 2017 1 commit
  11. 18 Jul, 2017 1 commit
    • minch's avatar
      Touch gestures for System Tray/ IME/ Stylus/ Notifications · d8633937
      minch authored
      Swiping up on the System Tray/ IME/ Stylus/ Notifications buttons in
      status area should open the associated bubble.
      Swiping down on the opened bubble should close the associated bubble.
      
      Changes:
      1.Added the tray_drag_controller to extract the logic of dragging behavior from system_tray.
      2.Added help functions in tray_background_view to get the state of associated tray bubble.
      3.Added one interface ProcessGestureEventForBubble in TrayBubbleView::Delegate
      to help process the dragging that happened on the tray bubble.
      
      BUG=735994,735996
      
      Review-Url: https://codereview.chromium.org/2961313003
      Cr-Commit-Position: refs/heads/master@{#487573}
      d8633937
  12. 27 Jun, 2017 1 commit
  13. 22 Jun, 2017 2 commits
    • vabr's avatar
      Revert of Do not activate TrayBubbleView by default (patchset #15 id:270001 of... · 0cafb5aa
      vabr authored
      Revert of Do not activate TrayBubbleView by default (patchset #15 id:270001 of https://codereview.chromium.org/2897553002/ )
      
      Reason for revert:
      Speculative revert. I suspect this broke the interactive_ui_tests on Linux ChromiumOS MSan Tests (https://build.chromium.org/p/chromium.memory/builders/Linux%20ChromiumOS%20MSan%20Tests/builds/1276). The tests now time out, and the log contains lines with:
      
      Still waiting for the following processes to finish:
      	./interactive_ui_tests --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=TestAsNormalAndGuestUser/SpokenFeedbackTest.NavigateSystemTray/0 --single_process --test-launcher-bot-mode --test-launcher-print-test-stdio=always --test-launcher-summary-output=/b/s/w/ioS9oZeu/output.json --user-data-dir=/b/s/w/it1bN0Em/.org.chromium.Chromium.iOqw8e/dOj481Q
      
      Original issue's description:
      > Do not activate TrayBubbleView by default
      >
      > - Activating a TrayBubbleView brings an Android window to onPause state.
      > - This CL sets can_set_activate to false and makes TrayBubbleView not
      >   activated by default.
      > - If the TrayBubbleView is not activated, it cannot capture key events
      >   for moving focus or closing the view by keyboard. TrayBubbleView tries
      >   to register accelerators at the global level to capture those key
      >   events.
      > - Activates the TrayBubbleView by default if keyboard navigation
      >   accessibility feature (e.g. spoken feedback) is enabled.
      >
      > BUG=726588,731748
      > TEST=Follow steps described in the issue
      >
      > Review-Url: https://codereview.chromium.org/2897553002
      > Cr-Commit-Position: refs/heads/master@{#481421}
      > Committed: https://chromium.googlesource.com/chromium/src/+/c97f341f1a2f6f359ba1a7c8687aa58af6f7033c
      
      TBR=stevenjb@chromium.org,dmazzoni@chromium.org,msw@chromium.org,jamescook@chromium.org,yawano@chromium.org
      # Skipping CQ checks because original CL landed less than 1 days ago.
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      BUG=726588,731748
      
      Review-Url: https://codereview.chromium.org/2948223002
      Cr-Commit-Position: refs/heads/master@{#481485}
      0cafb5aa
    • yawano's avatar
      Do not activate TrayBubbleView by default · c97f341f
      yawano authored
      - Activating a TrayBubbleView brings an Android window to onPause state.
      - This CL sets can_set_activate to false and makes TrayBubbleView not
        activated by default.
      - If the TrayBubbleView is not activated, it cannot capture key events
        for moving focus or closing the view by keyboard. TrayBubbleView tries
        to register accelerators at the global level to capture those key
        events.
      - Activates the TrayBubbleView by default if keyboard navigation
        accessibility feature (e.g. spoken feedback) is enabled.
      
      BUG=726588,731748
      TEST=Follow steps described in the issue
      
      Review-Url: https://codereview.chromium.org/2897553002
      Cr-Commit-Position: refs/heads/master@{#481421}
      c97f341f
  14. 30 May, 2017 1 commit
    • jamescook's avatar
      chromeos: Remove TrayBubbleView::Delegate::OnBeforeBubbleWidgetInit · c3301607
      jamescook authored
      This method was added to let mash set the widget container back when
      mash could not use aura::Window. Now we can set the parent aura::Window
      explicitly.
      
      Eliminate the TrayBubbleView::Create() factory method because its
      signature is identical to the constructor and it doesn't do any
      validation.
      
      Eliminate some GetInitParams / GetDefaultInitParams methods that were
      only used by WebNotificationTray.
      
      This is mostly a manual revert of:
      https://codereview.chromium.org/2092473002/
      
      BUG=671246
      TEST=ash_unittests, views_unittests, manually opening all system tray
      bubbles on primary and secondary monitors
      
      Review-Url: https://codereview.chromium.org/2901273003
      Cr-Commit-Position: refs/heads/master@{#475682}
      c3301607
  15. 25 May, 2017 1 commit
    • James Cook's avatar
      chromeos: Rename ash::WmShelf to Shelf · 840177e7
      James Cook authored
      The "Wm" porting layer is being removed, so it can go back to its
      original name.
      
      No behavior changes, just a mechanical refactor.
      
      tools/git/move_source_file.py for
          wm_shelf.h to shelf.h
          wm_shelf.cc to shelf.cc
          wm_shelf_observer.h to shelf_observer.h
      
      tools/git/mffr.py for
        WmShelfObserver to ShelfObserver
        WmShelf to Shelf
        wm_shelf to shelf
      
      Fix up a couple call sites like "wm_shelf_container" window.
      
      Replace deprecated GetAlignment() with alignment() because it touches
      the same lines as the rest of this change.
      
      BUG=none
      TEST=compiles, ash_unittests, chrome unit_tests
      R=msw@chromium.org, tsepez@chromium.org
      TBR=reveman@chromium.org, xiyuan@chromium.org
      
      Review-Url: https://codereview.chromium.org/2899253002 .
      Cr-Commit-Position: refs/heads/master@{#474526}
      840177e7
  16. 16 May, 2017 1 commit
  17. 20 Apr, 2017 1 commit
    • mohsen's avatar
      Make LogoutButtonTray a regular View · e6704a0c
      mohsen authored
      Currently, LogoutButtonTray is a TrayBackgroundView, however, it does
      not use most of its functionality (e.g., drawing and animating
      background, handling bubbles, drawing separators and focus rings). This
      CL makes LogoutButtonTray directly inherit from View and just adds the
      padding using TrayContainer class.
      
      This CL also removes shelf alignment caching in TrayBackgroundView,
      TrayContainer, and StatusAreaWidgetDelegate and cleaned up some related
      shelf alignment code.
      
      BUG=698134,635963
      TEST=StatusAreaWidgetTest.Basic in ash_unittests
      
      Review-Url: https://codereview.chromium.org/2807693002
      Cr-Commit-Position: refs/heads/master@{#465918}
      e6704a0c
  18. 18 Apr, 2017 1 commit
    • jamescook's avatar
      cros: Use SessionController to enable system tray settings / notifications tray · 341c0454
      jamescook authored
      This eliminates 2 methods from SystemTrayDelegate and makes
      the system tray work better in mustash.
      
      * Rename ShouldShowSettings to ShouldEnableSettings, because
      the settings gear icon is always visible.
      * Cache the booleans from the user flow in ash::mojom::UserSession,
      because these are set once per session
      * Consolidate the session active/locked/etc. logic in SessionController
      * Clean up WebNotificationTray, which uses logged in state and
      should-show state inconsistently.
      
      BUG=648964,665997
      TEST=ash_unittests TrayItemTest.*, manual testing of supervised user flow and adding secondary user flow
      
      Review-Url: https://codereview.chromium.org/2822033002
      Cr-Commit-Position: refs/heads/master@{#465287}
      341c0454
  19. 09 Apr, 2017 1 commit
    • James Cook's avatar
      chromeos: Move //ash/common files into //ash · b0bf8e8e
      James Cook authored
      //ash contains the "Aura Shell" system UI used by Chrome OS. For the
      mustash servicification project we initially started moving files into
      //ash/mus vs. //ash/aura vs. //ash/common. This allowed us to use DEPS
      to ban aura includes. We now support aura on mus all the time, so we
      don't need this directory structure.
      
      BUG=690096
      TEST=compiles, ash_unittests
      TBR=sky@chromium.org
      
      Change-Id: I682586877b6c537d2db613664318bbc0365362c6
      
      CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
      
      Change-Id: I682586877b6c537d2db613664318bbc0365362c6
      Reviewed-on: https://chromium-review.googlesource.com/472548Reviewed-by: 's avatarJames Cook <jamescook@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#463140}
      b0bf8e8e
  20. 05 Mar, 2017 4 commits
  21. 23 Jan, 2017 1 commit
  22. 25 Nov, 2016 1 commit
  23. 16 Nov, 2016 1 commit
    • estade's avatar
      Adjust positioning of cros tray bubbles. · 3acb088d
      estade authored
      This consolidates the anchoring logic of all tray bubbles. In the common
      case (bottom aligned, LTR) this is right bubble edge to right button
      edge, and vertically, flushed to the tray (i.e. the area that turns
      black when you maximize a window).
      
      There are never arrows on tray bubbles these days, so a ton of arrow-
      related logic is removed from TrayBubbleView.
      
      Since all bubbles position themselves the same way (and because
      set_anchor_view_insets is flexible enough to cover any differences),
      there's no need to delegate GetAnchorRect any more. Many other settings
      such as the shadow are also not needed since they're always the same.
      
      Trying to maintain pre-MD behavior and have both coexist would be a
      mess, so the change is not gated on the MD flag. However, it works fine
      in both worlds.
      
      BUG=663016
      
      Review-Url: https://codereview.chromium.org/2491033006
      Cr-Commit-Position: refs/heads/master@{#432567}
      3acb088d
  24. 11 Aug, 2016 1 commit
    • yoshiki's avatar
      Show small notification icons in notification tray (reland) · 79c70981
      yoshiki authored
      This patch is a reland of crrev.com/411019 with fixing the memory leak by moving the place of AddChild(count_label_view).
      
      Original Description:
      
      This patch shows small notification icons (up to 3) of the
      current notifications in the notification tray.
      
      This also makes the counter show the count of all the
      notification excluding the visible small icons (previously
      it was the unread count).
      
      See the issue for screenshots.
      
      BUG=633399
      TEST=manual test (with and without MD mode)
      R=xiyuan@chromuim.org
      TBR=oshima@chromium.org
      
      Review-Url: https://codereview.chromium.org/2243563002
      Cr-Commit-Position: refs/heads/master@{#411418}
      79c70981
  25. 10 Aug, 2016 2 commits
  26. 09 Aug, 2016 1 commit
    • mohsen's avatar
      Simplify WebNotificationTray · d7064c4d
      mohsen authored
      Despite being an ActionableView, WebNotificationTray unnecessarily hosts
      a button and calls its ActionableView::PerformAction() from its
      ButtonListener::ButtonPressed(). We can get rid of the button and let
      the ActionableView handle the clicks on the item.
      
      This is a step forward to enable ink drop ripples on
      WebNotificationTray.
      
      BUG=612579
      TEST=WebNotificaitonTrayTest.*
      
      Review-Url: https://codereview.chromium.org/2221303002
      Cr-Commit-Position: refs/heads/master@{#410756}
      d7064c4d
  27. 25 Jul, 2016 1 commit
    • mgiuca's avatar
      Added default implementations of GetAcceleratorForCommandId. · c3a89655
      mgiuca authored
      Adds the default implementation to SimpleMenuModel and
      ButtonMenuItemModel classes that just returns false, and deletes all
      subclasses' overrides that just return false (over half the overrides;
      39 in total).
      
      Returning false just means you have no accelerators; it is a fine
      default and there is no need to have every single subclass explicitly
      override and return false.
      
      RenderViewContextMenuBase: Remove the spurious override = 0 (which is
      now blocking the default implementation from propagating down).
      
      TBR=derat@chromium.org
      BUG=627344
      
      Review-Url: https://codereview.chromium.org/2140963002
      Cr-Commit-Position: refs/heads/master@{#407416}
      c3a89655
  28. 13 Jul, 2016 1 commit
  29. 28 Jun, 2016 1 commit
    • jamescook's avatar
      mash: Remove StatusAreaWidget references from system tray classes · 4ee304e3
      jamescook authored
      Breaking this dependency will allow individual system tray pieces (e.g. the web
      notification tray) to be created without a StatusAreaWidget. This provides a
      path for ash/mus to instantiate its own status area widget and to add pieces
      one by one.
      
      Rename WebNotificationTray::SetSystemTrayHeight() to SetTrayBubbleHeight() so
      it is more clear what the SystemTray / WebNotificationTray dependency really
      is.
      
      Move //ash/system/web_notifications to //ash/common as this is its last
      non-common dependency.
      
      BUG=619636
      TEST=ash_unittests
      TBR=stevenjb@chromium.org
      
      Review-Url: https://codereview.chromium.org/2103603002
      Cr-Commit-Position: refs/heads/master@{#402395}
      4ee304e3
  30. 24 Jun, 2016 3 commits
    • jamescook's avatar
      Reland: mash: Convert TrayBackgroundView to wm common types · 380fac77
      jamescook authored
      The previous version of this patch, https://codereview.chromium.org/2091933002
      collided during commit with https://codereview.chromium.org/2087703002. This
      is just a rebase.
      
      Also convert StatusAreaWidget usage to WmShelf. This is closer to the long-
      term pattern we want, where StatusAreaWidget is accessed via wm types.
      
      * Eliminate the TrayBackgroundView::status_area_widget() accessors
      * Cache a copy of StatusAreaWidget* in subclasses where needed
      
      Move the following interdependent files:
      move_source_file.py ash/system/tray/tray_background_view.* ash/common/system/tray/
      move_source_file.py ash/system/tray/tray_bubble_wrapper.* ash/common/system/tray/
      move_source_file.py ash/system/tray/tray_event_filter.* ash/common/system/tray/
      move_source_file.py ash/system/tray/system_tray_bubble.* ash/common/system/tray/
      
      BUG=619636
      TEST=ash_unittests
      TBR=msw@chromium.org
      
      Review-Url: https://codereview.chromium.org/2099603002
      Cr-Commit-Position: refs/heads/master@{#401820}
      380fac77
    • piman's avatar
      Revert of mash: Convert TrayBackgroundView to wm common types (patchset #4... · 3c51f5db
      piman authored
      Revert of mash: Convert TrayBackgroundView to wm common types (patchset #4 id:60001 of https://codereview.chromium.org/2091933002/ )
      
      Reason for revert:
      Causing compile errors
      - https://build.chromium.org/p/chromium/builders/Win/builds/44650
      
      FAILED: obj/ash/ash/web_notification_tray.obj
      ninja -t msvc -e environment.x86 -- C:\b\build\slave\cache\cipd\goma/gomacc.exe "C:\b\depot_tools\win_toolchain\vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\VC\bin\amd64_x86/cl.exe" /nologo /showIncludes /FC @obj/ash/ash/web_notification_tray.obj.rsp /c ../../ash/system/web_notification/web_notification_tray.cc /Foobj/ash/ash/web_notification_tray.obj /Fd"obj/ash/ash_cc.pdb"
      c:\b\build\slave\win\build\src\ash\system\web_notification\web_notification_tray.cc(510): error C3861: 'status_area_widget': identifier not found
      c:\b\build\slave\win\build\src\ash\system\web_notification\web_notification_tray.cc(510): error C2227: left of '->system_tray' must point to class/struct/union/generic type
      c:\b\build\slave\win\build\src\ash\system\web_notification\web_notification_tray.cc(510): note: type is 'unknown-type'
      c:\b\build\slave\win\build\src\ash\system\web_notification\web_notification_tray.cc(510): error C2227: left of '->SetNextFocusableView' must point to class/struct/union/generic type
      
      Original issue's description:
      > mash: Convert TrayBackgroundView to wm common types
      >
      > Also convert StatusAreaWidget usage to WmShelf. This is closer to the long-
      > term pattern we want, where StatusAreaWidget is accessed via wm types.
      >
      > * Eliminate the TrayBackgroundView::status_area_widget() accessors
      > * Cache a copy of StatusAreaWidget* in subclasses where needed
      >
      > Move the following interdependent files:
      > move_source_file.py ash/system/tray/tray_background_view.* ash/common/system/tray/
      > move_source_file.py ash/system/tray/tray_bubble_wrapper.* ash/common/system/tray/
      > move_source_file.py ash/system/tray/tray_event_filter.* ash/common/system/tray/
      > move_source_file.py ash/system/tray/system_tray_bubble.* ash/common/system/tray/
      >
      > BUG=619636
      > TEST=ash_unittests
      > TBR=stevenjb@chromium.org for 1 line rename in c/b/ui/chromeos/
      >
      > Committed: https://crrev.com/f6f6340048f0ec9535c310d16dd515133fb04c50
      > Cr-Commit-Position: refs/heads/master@{#401769}
      
      TBR=msw@chromium.org,stevenjb@chromium.org,jamescook@chromium.org
      # Skipping CQ checks because original CL landed less than 1 days ago.
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      BUG=619636
      
      Review-Url: https://codereview.chromium.org/2097733002
      Cr-Commit-Position: refs/heads/master@{#401792}
      3c51f5db
    • jamescook's avatar
      mash: Convert TrayBackgroundView to wm common types · f6f63400
      jamescook authored
      Also convert StatusAreaWidget usage to WmShelf. This is closer to the long-
      term pattern we want, where StatusAreaWidget is accessed via wm types.
      
      * Eliminate the TrayBackgroundView::status_area_widget() accessors
      * Cache a copy of StatusAreaWidget* in subclasses where needed
      
      Move the following interdependent files:
      move_source_file.py ash/system/tray/tray_background_view.* ash/common/system/tray/
      move_source_file.py ash/system/tray/tray_bubble_wrapper.* ash/common/system/tray/
      move_source_file.py ash/system/tray/tray_event_filter.* ash/common/system/tray/
      move_source_file.py ash/system/tray/system_tray_bubble.* ash/common/system/tray/
      
      BUG=619636
      TEST=ash_unittests
      TBR=stevenjb@chromium.org for 1 line rename in c/b/ui/chromeos/
      
      Review-Url: https://codereview.chromium.org/2091933002
      Cr-Commit-Position: refs/heads/master@{#401769}
      f6f63400
  31. 23 Jun, 2016 1 commit
    • jamescook's avatar
      mash: Optionally set bubble widget parent container via delegate · ca6fa1d5
      jamescook authored
      Use the delegate mechanism on ash to support both aura and mus.
      
      This eliminates aura::Window usage in SystemTrayBubble and WebNotificationTray,
      which is step toward converting TrayBubbleView to wm common types.
      
      I didn't eliminate BubbleDialogDelegateView::parent_window_ because that
      mechanism is used in ~30 places inside //chrome.
      
      BUG=619636
      TEST=ash_unittests, views_unittests, manually check that system tray bubbles
      still open/close propertly
      
      Review-Url: https://codereview.chromium.org/2092473002
      Cr-Commit-Position: refs/heads/master@{#401469}
      ca6fa1d5
  32. 20 Jun, 2016 1 commit
    • jamescook's avatar
      mash: Convert WebNotificationTray to wm common types · 21c95c56
      jamescook authored
      This is a dependency of the status area widget which I'm trying to convert to
      wm common types.
      
      Introduce a method to the message center's delegate that allows it to
      compute the parent container for a popup. This cannot be a NativeView, since
      on mus a NativeView is an aura::Window, but the parent container is a mus
      window.
      
      This can't move to //ash/common yet because of system tray dependencies.
      
      BUG=619636
      TEST=ash_unittests
      
      Review-Url: https://codereview.chromium.org/2075953003
      Cr-Commit-Position: refs/heads/master@{#400738}
      21c95c56
  33. 17 Jun, 2016 1 commit
    • jamescook's avatar
      mash: Convert AshPopupAlignmentDelegate to wm common types · 3228109c
      jamescook authored
      This is a dependency of WebNotificationTray, which is a dependency of
      StatusAreaWidget, which I am trying to migrate to wm common types.
      
      * Add auto-hide and work area methods to WmShelf.
      * Access shelf_widget() via shelf_layout_manager() in WmShelfAura, as we need
      to access it before the |Shelf| is created during external monitor init.
      
      BUG=619636
      TEST=ash_unittests
      
      Review-Url: https://codereview.chromium.org/2029323002
      Cr-Commit-Position: refs/heads/master@{#400312}
      3228109c