1. 07 Nov, 2017 2 commits
  2. 20 Oct, 2017 1 commit
  3. 16 Oct, 2017 1 commit
  4. 11 Oct, 2017 1 commit
  5. 04 Oct, 2017 1 commit
  6. 15 Aug, 2017 1 commit
  7. 08 Aug, 2017 1 commit
  8. 22 Jul, 2017 1 commit
  9. 19 Jul, 2017 1 commit
  10. 29 Jun, 2017 1 commit
  11. 28 Jun, 2017 3 commits
  12. 17 Jun, 2017 1 commit
  13. 30 May, 2017 1 commit
    • jamescook's avatar
      chromeos: Tighten DEPS on //ash in //chrome/browser to support mash · 1f91eac1
      jamescook authored
      Under mash the code in //ash runs out of process. Code in //chrome/browser
      must use the mojo interfaces in //ash/public/interfaces to talk to ash.
      We're still in the process of refactoring existing code, but new code
      should use the mojo approach. Tighten DEPS on //ash to limit the number
      of new references.
      Also file bugs to refactor the existing areas.
      Review-Url: https://codereview.chromium.org/2891923003
      Cr-Commit-Position: refs/heads/master@{#475577}
  14. 19 May, 2017 1 commit
    • cco3's avatar
      Suppress WebUSB notifications when appropriate · dca47e28
      cco3 authored
      Currently, a WebUSB notification appears regardless of whether the
      landing page is already open.  This change takes a more refined
      approach to WebUSB notifications, as outlined below.
      Managing the notification:
      - If the active tab is the landing page, don't fire a notification.
      - If the the landing page becomes featured in the active tab and a
        notification exists, remove it.
      When clicking a notification:
      - If a tab exists with the landing page, activate it.
      - If a tab does not exist with the landing page, create a new tab and
        navigate to the landing page.
      Review-Url: https://codereview.chromium.org/2824923002
      Cr-Commit-Position: refs/heads/master@{#473273}
  15. 12 May, 2017 1 commit
    • reillyg's avatar
      Integrate WebUSB with Feature Policy · aee98b5c
      reillyg authored
      This patch uses the new Feature Policy framework to control access to
      WebUSB from embedded frames. When Feature Policy is available WebUSB's
      default policy ["self"] is enforced. When it isn't available WebUSB is
      simply disallowed in embedded frames.
      A follow-up patch will remove the parser for the "allowed origins"
      descriptor as they are no longer used and have been removed from the
      Review-Url: https://codereview.chromium.org/2815003005
      Cr-Commit-Position: refs/heads/master@{#471487}
  16. 04 May, 2017 1 commit
  17. 28 Apr, 2017 1 commit
  18. 19 Apr, 2017 1 commit
    • reillyg's avatar
      Move classes in the device.usb Mojo namespace to device.mojom · c961656d
      reillyg authored
      The USB Mojo service was added before there was clear guidance on what
      namespace Mojo modules should use. The convention is now to use
      The USB Mojo service implementation is still in the device::usb
      namespace which violates the general Chromium style guide recommendation
      to not use nested namespaces. This will be fixed in a later patch.
      Review-Url: https://codereview.chromium.org/2821723002
      Cr-Commit-Position: refs/heads/master@{#465467}
  19. 09 Apr, 2017 1 commit
    • James Cook's avatar
      chromeos: Move //ash/common files into //ash · b0bf8e8e
      James Cook authored
      //ash contains the "Aura Shell" system UI used by Chrome OS. For the
      mustash servicification project we initially started moving files into
      //ash/mus vs. //ash/aura vs. //ash/common. This allowed us to use DEPS
      to ban aura includes. We now support aura on mus all the time, so we
      don't need this directory structure.
      TEST=compiles, ash_unittests
      Change-Id: I682586877b6c537d2db613664318bbc0365362c6
      Change-Id: I682586877b6c537d2db613664318bbc0365362c6
      Reviewed-on: https://chromium-review.googlesource.com/472548Reviewed-by: default avatarJames Cook <jamescook@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#463140}
  20. 28 Mar, 2017 1 commit
  21. 16 Mar, 2017 1 commit
  22. 14 Mar, 2017 1 commit
  23. 08 Mar, 2017 1 commit
    • scottmg's avatar
      Require explicit selection of traits for LazyInstance · 5e65e3a4
      scottmg authored
      This change requires the user of LazyInstance to explicitly select
      either ::DestructorAtExit or ::Leaky. It seems clear that many users of
      LazyInstance have just gone with default and are either unaware or
      didn't consider that the default requires running an AtExit at process
      As a first step, make this choice explicit, and update current users
      to be ::DestructorAtExit to maintain current behaviour. Follow ups can
      then attempt to consider individual switches from DestructorAtExit to
      Leaky including reviewers with domain-specific knowledge.
      i.e. No intended behaviour change from this CL.
      Lots of TBRs for mechanical changes:
      boliu: android_webview/
      danakj: cc/
      dmurph: storage/
      jam: content/ ipc/, mojo/
      jbauman: gpu/
      jochen: gin/
      oshima: chromeos/
      raymes: ppapi/
      rdevlin.cronin: extensions/
      rockot: device/, services/
      rogerta: google_apis/
      rsleevi: net/, crypto/
      sdefresne: components/, ios/
      sergeyu: jingle/
      slan: chromecast/
      thakis: base/, chrome/, third_party/, tools/, ui/
      vitalybuka: printing/
      wez: remoting/
      Review-Url: https://codereview.chromium.org/2733283002
      Cr-Commit-Position: refs/heads/master@{#455405}
  24. 07 Mar, 2017 1 commit
  25. 05 Mar, 2017 2 commits
  26. 18 Jan, 2017 1 commit
  27. 17 Jan, 2017 1 commit
  28. 10 Jan, 2017 1 commit
  29. 07 Jan, 2017 1 commit
  30. 16 Dec, 2016 1 commit
    • reillyg's avatar
      Add infrastructure for a USB device blocklist. · eb1d24d3
      reillyg authored
      This blocklist allows access to particular models of USB device via the
      WebUSB API to be blocked via either a binary push or Finch experiment.
      Manual testing of this is difficult. I added a real device to the
      blocklist and verified that it was not returned by
      navigator.usb.getDevices() and was not listed in the chooser.
      Review-Url: https://codereview.chromium.org/2581543002
      Cr-Commit-Position: refs/heads/master@{#438981}
  31. 29 Nov, 2016 1 commit
    • juncai's avatar
      Fix blank names issue for navigator.usb.requestDevice · 06198969
      juncai authored
      Sometimes UsbDevice::product_string() returns empty string, and the
      current WebUSB chooser uses it as the device name to be displayed.
      This CL fixes the blank name issue by displaying, in decreasing order
      of preference:
      1. UsbDevice::product_string()
      2. UsbIds::GetProductName()
      3. "Unknown device from " + UsbIds::GetVendorName()
      4. "Unknown device [$VID:$PID]"
      Review-Url: https://codereview.chromium.org/2539593002
      Cr-Commit-Position: refs/heads/master@{#435019}
  32. 27 Nov, 2016 1 commit
  33. 23 Nov, 2016 1 commit
  34. 14 Nov, 2016 1 commit
    • reillyg's avatar
      Open link from WebUSB in the last used profile. · da2f47e1
      reillyg authored
      This switches WebUSB notifications from using
      ProfileManager::GetActiveProfile() to
      ProfileManager::GetLastUsedProfileAllowedByPolicy(). This means that
      when a single Chrome instance has multiple profiles configured the one
      with a currently active window will be selected to open the new tab.
      Previously the default profile was always used.
      TEST=Verified new tab is opened in the most recently used Chrome window
      and that new windows are still successfully created on Chrome OS in
      regular and guest mode.
      Review-Url: https://codereview.chromium.org/2505433002
      Cr-Commit-Position: refs/heads/master@{#431969}
  35. 18 Oct, 2016 1 commit
    • reillyg's avatar
      Disable WebUSB detector logic on Windows. · dfd32df7
      reillyg authored
      Initializing the WebUSB device detector logic causes the USB subsystem
      to attempt to fully enumerate the system's USB bus. This has been found
      to cause jank and hangs on Chrome's FILE thread on Windows. Disabling
      this component of WebUSB while the issue is investigated.
      WebUSB will continue to function but this change will prevent the issue
      from impacting users who do not visit sites using it.
      TEST=Verified USB subsystem is not initialized on startup on Windows by
      checking chrome://device-log. Verified still initialized on Linux.
      Review-Url: https://codereview.chromium.org/2422403003
      Cr-Commit-Position: refs/heads/master@{#425867}
  36. 13 Oct, 2016 1 commit