1. 07 Jul, 2017 1 commit
  2. 01 Jun, 2017 1 commit
    • gab's avatar
      Deprecate NonThreadSafe in remoting in favor of SequenceChecker. · bf77513a
      gab authored
      Note to crash team: This CL is a refactor and has no intended behavior change.
      
      This change was scripted by https://crbug.com/676387#c8.
      
      Note-worthy for the reviewer:
       * SequenceChecker enforces thread-safety but not thread-affinity!
         If the classes that were updated are thread-affine (use thread local
         storage or a third-party API that does) they should be migrated to
         ThreadChecker instead.
       * ~NonThreadSafe() used to implcitly check in its destructor
         ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
         no-op, an explicit check was added to the destructor of migrated
         classes.
       * NonThreadSafe used to provide access to subclasses, as such
         the |sequence_checker_| member was made protected rather than
         private where necessary.
      
      BUG=676387
      This CL was uploaded by git cl split.
      
      R=sergeyu@chromium.org
      
      Review-Url: https://codereview.chromium.org/2911893003
      Cr-Commit-Position: refs/heads/master@{#476279}
      bf77513a
  3. 01 Oct, 2016 1 commit
  4. 12 Aug, 2016 1 commit
  5. 11 May, 2016 1 commit
  6. 06 Apr, 2016 1 commit
  7. 30 Jan, 2016 2 commits
    • sergeyu's avatar
      Simplify message parsing. · d8af2cac
      sergeyu authored
      Previously ProtobufMessageParser was used to parse incoming messages.
      Removed it and replaced with ParseMessage() function. This allows to
      simplify MessageReader and makes it possible to remove MessageReader
      dependency in ChannelDispatcherBase, which will be done later.
      
      Review URL: https://codereview.chromium.org/1654513003
      
      Cr-Commit-Position: refs/heads/master@{#372526}
      d8af2cac
    • sergeyu's avatar
      Remove done notifications from incoming message handlers. · e61b68d9
      sergeyu authored
      Previously MessageReader and ProtobufMessageParse were passing done
      callbacks to the messages handlers. These callbacks were necessary to
      pace the reader, particularly when video renderer is slow and cannot
      keep up with the rate of the incoming messages. It's no longer
      necessary because we have explicit ACK messages for video packets.
      
      Review URL: https://codereview.chromium.org/1655433002
      
      Cr-Commit-Position: refs/heads/master@{#372509}
      e61b68d9
  8. 14 Jan, 2016 1 commit
  9. 24 Dec, 2015 1 commit
  10. 22 Dec, 2015 2 commits
  11. 30 Jul, 2015 1 commit
  12. 20 Jul, 2015 1 commit
    • sergeyu's avatar
      Add P2PDatagramSocket and P2PStreamSocket interfaces. · aa22c085
      sergeyu authored
      Previously remoting code was using net::Socket and net::StreamSocket
      for datagram and stream socket. Problem is that net::StreamSocket
      interface contains a lot of methods that are not relevant for
      peer-to-peer connections in remoting. Added P2PDatagramSocket and
      P2PStreamSocket interfaces independent of net::Socket. This allowed to
      remove a lot of the redundant code needed for net::StreamSocket
      implementations. There are two new adapters required in
      SslHmacChannelAuthenticator for the SSL layer, but these won't be
      necessary after we migrate to QUIC.
      
      Review URL: https://codereview.chromium.org/1197853003
      
      Cr-Commit-Position: refs/heads/master@{#339489}
      aa22c085
  13. 15 May, 2015 1 commit
    • ttuttle's avatar
      Collect all ConnectionAttempts from both sockets in TransportConnectJob. · 23fdb7b4
      ttuttle authored
      Before, the TransportConnectJob simply inferred that, if the main socket
      failed to connect, the address it was using was the last address in the
      list. With this change, the TCPClientSocket actually tracks all of the
      connection attempts made (as it tries each address in the list), and the
      TransportConnectJob copies the attempts from both the main and fallback
      sockets and records all of them in the ClientSocketHandle in
      GetAdditionalErrorState.
      
      BUG=480565
      TBR=jam
      
      Review URL: https://codereview.chromium.org/1096203006
      
      Cr-Commit-Position: refs/heads/master@{#330012}
      23fdb7b4
  14. 14 May, 2015 1 commit
  15. 10 Jan, 2015 1 commit
    • sergeyu's avatar
      Cleanup channel dispatchers · 203832d4
      sergeyu authored
      Now ChannelDispatcherBase handles initialization of reader and writer,
      which makes all dispatcher classes simpler. ChannelDispatcherBase now
      can handle writer errors. Also renamed
      ProtobufMessageReader -> ProtobufMessageParser.
      
      Review URL: https://codereview.chromium.org/841773005
      
      Cr-Commit-Position: refs/heads/master@{#310993}
      203832d4
  16. 09 Jan, 2015 1 commit
  17. 21 Oct, 2014 1 commit
  18. 08 Oct, 2014 1 commit
  19. 29 Sep, 2014 1 commit
  20. 12 Sep, 2014 1 commit
    • sergeyu's avatar
      Move PseudoTCP and channel auth out of LibjingleTransportFactory. · 9cb142f0
      sergeyu authored
      Previously TransportFactory interface was responsible for creation
      and initialization of several protocol layers, including PseudoTCP and
      authentication (TLS). Simplified it so now it only creates raw datagram
      transport channel. PseudoTcpChannelFactory is now responsible for
      setting up PseudoTcpAdapter and AuthenticatingChannelFactory takes care
      of channel authentication. Also added DatagramChannelFactory for
      Datagram channels.
      
      This change will make it possible to replace PseudoTcpChannelFactory
      with an object that creates SCTP-based channels.
      
      Also fixed a bug in SslHmacChannelAuthenticator. It wasn't working
      properly when deleted from the callback. (base::Callback objects
      shouldn't be deleted while being called because when deleted they
      also destroy reference parameters values they are holding).
      
      BUG=402993
      
      Review URL: https://codereview.chromium.org/551173004
      
      Cr-Commit-Position: refs/heads/master@{#294653}
      9cb142f0
  21. 11 Sep, 2014 2 commits
    • nasko's avatar
      Revert of Move PseudoTCP and channel auth out of LibjingleTransportFactory.... · 8a450db4
      nasko authored
      Revert of Move PseudoTCP and channel auth out of LibjingleTransportFactory. (patchset #5 id:100001 of https://codereview.chromium.org/551173004/)
      
      Reason for revert:
      Failed to compile on android builder.
      
      http://build.chromium.org/p/chromium.webkit/builders/Android%20Builder/builds/46485
      
      In file included from ../../remoting/protocol/pseudotcp_channel_factory.h:11:0,
                       from ../../remoting/protocol/pseudotcp_channel_factory.cc:5:
      ../../remoting/protocol/stream_channel_factory.h:34:41:error: 'string' in namespace 'std' does not name a type
         virtual void CreateChannel(const std::string& name,
                                               ^
      ../../remoting/protocol/stream_channel_factory.h:40:49:error: 'string' in namespace 'std' does not name a type
         virtual void CancelChannelCreation(const std::string& name) = 0;
      ...
      
      Original issue's description:
      > Move PseudoTCP and channel auth out of LibjingleTransportFactory.
      >
      > Previously TransportFactory interface was responsible for creation
      > and initialization of several protocol layers, including PseudoTCP and
      > authentication (TLS). Simplified it so now it only creates raw datagram
      > transport channel. PseudoTcpChannelFactory is now responsible for
      > setting up PseudoTcpAdapter and AuthenticatingChannelFactory takes care
      > of channel authentication. Also added DatagramChannelFactory for
      > Datagram channels.
      >
      > This change will make it possible to replace PseudoTcpChannelFactory
      > with an object that creates SCTP-based channels.
      >
      > Also fixed a bug in SslHmacChannelAuthenticator. It wasn't working
      > properly when deleted from the callback. (base::Callback objects
      > shouldn't be deleted while being called because when deleted they
      > also destroy reference parameters values they are holding).
      >
      > BUG=402993
      >
      > Committed: https://crrev.com/28d886c967e016a5d5812be43cd5916f577c2e10
      > Cr-Commit-Position: refs/heads/master@{#294474}
      
      TBR=wez@chromium.org,sergeyu@chromium.org
      NOTREECHECKS=true
      NOTRY=true
      BUG=402993
      
      Review URL: https://codereview.chromium.org/570463002
      
      Cr-Commit-Position: refs/heads/master@{#294488}
      8a450db4
    • sergeyu's avatar
      Move PseudoTCP and channel auth out of LibjingleTransportFactory. · 28d886c9
      sergeyu authored
      Previously TransportFactory interface was responsible for creation
      and initialization of several protocol layers, including PseudoTCP and
      authentication (TLS). Simplified it so now it only creates raw datagram
      transport channel. PseudoTcpChannelFactory is now responsible for
      setting up PseudoTcpAdapter and AuthenticatingChannelFactory takes care
      of channel authentication. Also added DatagramChannelFactory for
      Datagram channels.
      
      This change will make it possible to replace PseudoTcpChannelFactory
      with an object that creates SCTP-based channels.
      
      Also fixed a bug in SslHmacChannelAuthenticator. It wasn't working
      properly when deleted from the callback. (base::Callback objects
      shouldn't be deleted while being called because when deleted they
      also destroy reference parameters values they are holding).
      
      BUG=402993
      
      Review URL: https://codereview.chromium.org/551173004
      
      Cr-Commit-Position: refs/heads/master@{#294474}
      28d886c9
  22. 09 Sep, 2014 1 commit
  23. 25 Jul, 2014 1 commit
  24. 10 Apr, 2014 1 commit
  25. 09 Apr, 2014 1 commit
  26. 05 Apr, 2014 2 commits
  27. 01 Jun, 2013 1 commit
  28. 27 Apr, 2013 1 commit
  29. 30 Mar, 2013 1 commit
  30. 06 Feb, 2013 1 commit
  31. 26 Sep, 2012 1 commit
  32. 18 Aug, 2012 1 commit
  33. 08 Aug, 2012 1 commit