- 08 Nov, 2017 1 commit
-
-
Sriram authored
Update argument types from int to double for elementFromPoint() and elementsFromPoint() to match spec [1]. Webkit Patch reference [2] TESTS: external/wpt/cssom-view/elementFromPoint-parameters.html, cssom/elementfrompoint.html [1]: https://drafts.csswg.org/cssom-view/#extensions-to-the-document-interface [2]: https://trac.webkit.org/changeset/213646/ Change-Id: Idc8aa860a70312cb61ceb5a42fd4ad58a7346e1a Reviewed-on: https://chromium-review.googlesource.com/716096Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#514720}
-
- 01 Nov, 2017 1 commit
-
-
Zijie He authored
This looks like a very common issue when using os.rename() on Windows. https://www.google.com/search?q=python+os.rename+cannot+create+a+file+when+that+file+already+exists&oq=python+os.rename+cannot+create+a+file+when&aqs=chrome.0.0j69i57.12521j0j7&sourceid=chrome&ie=UTF-8 Bug: chromium:778370 Change-Id: I7132a2614fe9361c6860ae9598e994d7dbd00c5b Reviewed-on: https://chromium-review.googlesource.com/748306Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Zijie He <zijiehe@chromium.org> Cr-Commit-Position: refs/heads/master@{#513172}
-
- 18 Oct, 2017 1 commit
-
-
Jamie Walch authored
Bug: 775748 Change-Id: Id49b1a54fbcbb4ead1b093822be59753420ef983 Reviewed-on: https://chromium-review.googlesource.com/724293 Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Kelvin Poon <kelvinp@chromium.org> Cr-Commit-Position: refs/heads/master@{#509846}
-
- 17 Oct, 2017 2 commits
-
-
Jamie Walch authored
Bug: 775582 Change-Id: I838b3bedf596f9df38668746f1bc6b8235831a6c Reviewed-on: https://chromium-review.googlesource.com/723750 Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Zijie He <zijiehe@chromium.org> Cr-Commit-Position: refs/heads/master@{#509542}
-
Gurpreet Nanda authored
With the upcoming chrome apps deprecation, we have a new gnubbyd corp extension for !CrOS platforms that uses native messaging instead of the now unavailable chrome.usb/chrome.hid APIs Bug: Change-Id: I630ae0f67a059536326109f619bee0bcdbbb1929 Reviewed-on: https://chromium-review.googlesource.com/721617 Commit-Queue: Gurpreet Nanda <gunand@google.com> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#509268}
-
- 28 Sep, 2017 1 commit
-
-
Dirk Pranke authored
Ideally //build/config/features.gni would be empty (or, at least, would only reference features defined inside of //build). This CL moves the `enable_nacl` flag out of that file, and into its own dedicated file, so that it has a much smaller scope and we can help ensure that it is not referenced or needed by other projects that are using //build but aren't building Chromium. This work will be useful as part of the work we're doing to make NaCl something that can be disabled directly in DEPS (without needing to depend on GYP_DEFINES to do so). TBR=bradnelson@chromium.org R: brettw@chromium.org, bradleynelson@chromium.org, dschuff@chromium.org, phajdan.jr@chromium.org Bug: 756688 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I3af65646803912db67d421d35b4dfe9c2e0b703e Reviewed-on: https://chromium-review.googlesource.com/688314 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Cr-Commit-Position: refs/heads/master@{#505188}
-
- 05 Sep, 2017 1 commit
-
-
Erik Jensen authored
Bug: 752350 Change-Id: I83ba7e8818700e0805346428a3dbb9d19bd0ac23 Reviewed-on: https://chromium-review.googlesource.com/644286 Commit-Queue: Erik Jensen <rkjnsn@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#499793}
-
- 30 Aug, 2017 1 commit
-
-
Jamie Walch authored
Bug: b/64362070 Change-Id: Iaf5f1079d75a140b4fc2aab33eec6336798f8f03 Reviewed-on: https://chromium-review.googlesource.com/614362Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#498309}
-
- 29 Aug, 2017 1 commit
-
-
kelvinp@chromium.org authored
The |event| field should be named as |event_type| to match the log proto definition. Bug: 756674 Change-Id: Ib6375296d5a539e4e88b16659f7aad7460bc6d39 Reviewed-on: https://chromium-review.googlesource.com/641811Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Kelvin Poon <kelvinp@chromium.org> Cr-Commit-Position: refs/heads/master@{#498225}
-
- 23 Aug, 2017 1 commit
-
-
kelvinp@chromium.org authored
Reports the following metrics: 1. The number of times a message is shown for a specific migration phase. 2. The number of times a message is dismissed for a specific migration phase. 3. The number of times the upsell URL is clicked for a specific migration phase. Bug: 756674 Change-Id: I38916dcc66a4cab579eb2314c18b63b27302db04 Reviewed-on: https://chromium-review.googlesource.com/619811 Commit-Queue: Kelvin Poon <kelvinp@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#496865}
-
- 22 Aug, 2017 1 commit
-
-
Jamie Walch authored
Change-Id: I4c423efb148ac3ccf138aa5512d4536445114e79 Reviewed-on: https://chromium-review.googlesource.com/609372Reviewed-by:
Kelvin Poon <kelvinp@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#496365}
-
- 21 Jun, 2017 1 commit
-
-
Sergey Ulanov authored
This is a reland of e8f9d07d Original change's description: > Remove Remoting API Key > > Chromoting host no longer needs API Key, so the key can be removed. > > Change-Id: I0960660ce2ddd5f4352ab691468d7c3881530d8d > Reviewed-on: https://chromium-review.googlesource.com/540035 > Reviewed-by: Roger Tawa <rogerta@chromium.org> > Reviewed-by: Joe Downing <joedow@chromium.org> > Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#480940} TBR=rogerta@chromium.org,pasko@chromium.org Change-Id: Icce0c8512c24ca8f902a9b1941232ab2c42b70b0 Reviewed-on: https://chromium-review.googlesource.com/540985Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#481077}
-
- 20 Jun, 2017 2 commits
-
-
Tommy Martino authored
This reverts commit e8f9d07d. Reason for revert: Causing breakages -- https://build.chromium.org/p/chromium/builders/Android/builds/73527 Original change's description: > Remove Remoting API Key > > Chromoting host no longer needs API Key, so the key can be removed. > > Change-Id: I0960660ce2ddd5f4352ab691468d7c3881530d8d > Reviewed-on: https://chromium-review.googlesource.com/540035 > Reviewed-by: Roger Tawa <rogerta@chromium.org> > Reviewed-by: Joe Downing <joedow@chromium.org> > Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#480940} TBR=rogerta@chromium.org,sergeyu@chromium.org,joedow@chromium.org Change-Id: Ibc4df105f77ad41a859663cbef76b73baa208a63 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/541763Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#480970}
-
Sergey Ulanov authored
Chromoting host no longer needs API Key, so the key can be removed. Change-Id: I0960660ce2ddd5f4352ab691468d7c3881530d8d Reviewed-on: https://chromium-review.googlesource.com/540035Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#480940}
-
- 12 Jun, 2017 1 commit
-
-
Sergey Ulanov authored
After crrev.com/478051 It2Me host expects to get IceConfig from the webapp. The config is used to connect to TURN servers when using WebRTC. This CL updates the webapp to fetch IceConfig from the server and pass it to the host. Change-Id: I194f3602fad9bdd3445d843860a585a739187de2 Reviewed-on: https://chromium-review.googlesource.com/530446 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#478775}
-
- 31 May, 2017 1 commit
-
-
kelvinp authored
This CL also fixes a BUILD file error so that JSCompiler can be run. BUG=727904 Review-Url: https://codereview.chromium.org/2913073002 Cr-Commit-Position: refs/heads/master@{#475753}
-
- 18 May, 2017 1 commit
-
-
jamiewalch authored
Review-Url: https://codereview.chromium.org/2887573002 Cr-Commit-Position: refs/heads/master@{#472851}
-
- 11 May, 2017 1 commit
-
-
jamiewalch authored
BUG=433009 Review-Url: https://codereview.chromium.org/2867223003 Cr-Commit-Position: refs/heads/master@{#470984}
-
- 05 May, 2017 1 commit
-
-
joedow authored
BUG=718143 Review-Url: https://codereview.chromium.org/2860203003 Cr-Commit-Position: refs/heads/master@{#469777}
-
- 01 May, 2017 1 commit
-
-
jamiewalch authored
BUG= Review-Url: https://codereview.chromium.org/2838993002 Cr-Commit-Position: refs/heads/master@{#468380}
-
- 21 Apr, 2017 1 commit
-
-
sergeyu authored
BUG=714244 Review-Url: https://codereview.chromium.org/2830013006 Cr-Commit-Position: refs/heads/master@{#466452}
-
- 04 Apr, 2017 1 commit
-
-
jamiewalch authored
Review-Url: https://codereview.chromium.org/2796683003 Cr-Commit-Position: refs/heads/master@{#461867}
-
- 15 Feb, 2017 1 commit
-
-
agrieve authored
Cronet has a notice file generator as well, but I don't update it here since it is very different from the main licenses.py. BUG=687577 TBR=dpranke Review-Url: https://codereview.chromium.org/2670833004 Cr-Commit-Position: refs/heads/master@{#450744}
-
- 14 Feb, 2017 1 commit
-
-
jamiewalch authored
Previously, the response would be simply {}, which is interpreted as an error by the import code. Review-Url: https://codereview.chromium.org/2689593005 Cr-Commit-Position: refs/heads/master@{#450246}
-
- 07 Feb, 2017 1 commit
-
-
zijiehe authored
Currently the host experiment framework work is still on-going, so before I have finished all client side work, a HostConfigurationSessionPlugin can help to debug the host side changes. And more important, we can have a way to test some host experimental behaviors without private builds. HostConfigurationSessionPlugin is a SessionPlugin, which only sends the host-configuration attachment according to the input of constructor. In WebApp, a new global variable remoting.hostConfiguration has been added. If a user actively set this field, it will be forwarded to ChromotingInstance through connect method, then to ChromotingClient and HostConfigurationSessionPlugin, and finally to host through the session initiate message. Otherwise, the session initiate message won't be impacted. Details can be found @ https://goo.gl/7VYxRV. In host side, after change https://codereview.chromium.org/2586133002/, the host-configuration attachment will be consumed, and impact experimental behaviors. BUG=650926 Review-Url: https://codereview.chromium.org/2617783003 Cr-Commit-Position: refs/heads/master@{#448798}
-
- 04 Feb, 2017 1 commit
-
-
jamiewalch authored
This CL adds support for external messages, asynchronous handlers and a getSettings message. It also tightens the default externally_connectable to deny access to the new API to all origins, including other extensions, for the time being. Review-Url: https://codereview.chromium.org/2671103002 Cr-Commit-Position: refs/heads/master@{#448128}
-
- 12 Jan, 2017 1 commit
-
-
jamiewalch authored
I suspect that host.options was originally a simple dictionary, and so the cast was safe. When it got upgraded to an object with methods on the prototype it broke, but because the window of opportunity for failure is small (you have to connect without a call to HostList.refresh happening in the interim), it was difficult to track down. BUG=680302 Review-Url: https://codereview.chromium.org/2621403004 Cr-Commit-Position: refs/heads/master@{#443072}
-
- 13 Dec, 2016 1 commit
-
-
ericwilligers authored
CSS Transitions no longer need a -webkit prefix. BUG=668650 Review-Url: https://codereview.chromium.org/2536473002 Cr-Commit-Position: refs/heads/master@{#438318}
-
- 09 Nov, 2016 1 commit
-
-
kennetht authored
This replaces 'she' and 'her' with gender neutral alternatives. BUG=542537 Review-Url: https://codereview.chromium.org/2484973002 Cr-Commit-Position: refs/heads/master@{#431033}
-
- 31 Oct, 2016 1 commit
-
-
joedow authored
This change adds a new state to the CRD webapp. This state is sent to the Webapp/client to indicate that the remote user has started the connection process but has not yet completed it. For our purposes, this state will signal that the local user must take action (i.e. click Share on the confirmation dialog) and we can use it to updated the text / UI state on the local machine. The strings and webapp dialog are also updated to inform the user that an action is required on their part to complete the process. BUG=658459 Review-Url: https://codereview.chromium.org/2453193004 Cr-Commit-Position: refs/heads/master@{#428790}
-
- 12 Oct, 2016 2 commits
-
-
brettw authored
There is already a remoting_enable.gni file in the remoting directory. This flag should be contained in there rather than in the global feature flags file. Review-Url: https://codereview.chromium.org/2410973002 Cr-Commit-Position: refs/heads/master@{#424824}
-
jamiewalch authored
BUG=653673 Review-Url: https://codereview.chromium.org/2414453004 Cr-Commit-Position: refs/heads/master@{#424628}
-
- 04 Oct, 2016 1 commit
-
-
jamiewalch authored
BUG=642519 Review-Url: https://codereview.chromium.org/2369013008 Cr-Commit-Position: refs/heads/master@{#422952}
-
- 27 Sep, 2016 1 commit
-
-
brettw authored
Removes annotations of "GYP version" from GN targets. Removes shell.exe.manifest which was used only by the GYP build. TBR=dpranke@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2373683003 Cr-Commit-Position: refs/heads/master@{#421335}
-
- 17 Sep, 2016 1 commit
-
-
elawrence authored
BUG=598338 Review-Url: https://codereview.chromium.org/2347923002 Cr-Commit-Position: refs/heads/master@{#419362}
-
- 16 Sep, 2016 1 commit
-
-
michaelpg authored
In preparation for moving metricsPrivate to //extensions, re-generate the externs file and fix outdated types. BUG=647397 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2346683004 Cr-Commit-Position: refs/heads/master@{#419120}
-
- 02 Aug, 2016 1 commit
-
-
Dan Beam authored
This is used mainly so that the Chrome-specific compiler pass can be enabled and disabled. BUG=619091 R=aberent@chromium.org, jamiewalch@chromium.org Review URL: https://codereview.chromium.org/2117653002 . Cr-Commit-Position: refs/heads/master@{#409336}
-
- 23 Jul, 2016 1 commit
-
-
dpapad authored
Change log: https://github.com/google/closure-compiler/compare/2f95290ea61dd4f1b5a3bf9d0fe3aa8e3244babf...c64418fd5518bb60aeb6a627d2bcc46a3d4be788 chrome_extensions.js: 754b5d249801020f5d71df9b7b576550f56972dc -> 462f6bc6508621ebeb7cf9a51fca7d069d2a7b85 R=dbeam@chromium.org TBR=sergeyu Review URL: https://codereview.chromium.org/2180623002 . Cr-Commit-Position: refs/heads/master@{#407318}
-
- 21 Jun, 2016 1 commit
-
-
brucedawson authored
Windows gn debug builds of remoting_client_plugin_newlib OOM the 32-bit arm-nacl-ld.gold.exe. However we only need to build these in release builds. BUG=584516 Review-Url: https://codereview.chromium.org/2079323003 Cr-Commit-Position: refs/heads/master@{#400890}
-
- 23 May, 2016 1 commit
-
-
yuweih authored
* Initialize remoting.ClientSession.PerfStats with zeros so that caller doesn't need to check the undefined case. * Add check to StatsAccumulator.Add so that initial zeros will not dilute the result. BUG=613317 Review-Url: https://codereview.chromium.org/2004673002 Cr-Commit-Position: refs/heads/master@{#395408}
-