1. 26 Apr, 2017 3 commits
    • kmarshall's avatar
      Simplify ALLOW_UNUSED_LOCAL to use (void)x directly instead of conditionally. · d10bb7f7
      kmarshall authored
      Add ALLOW_UNUSED_LOCAL implementation for path-sensitive analyzers.
      The current definition of ALLOW_UNUSED_LOCAL uses "(void)x" to suppress
      warnings that "x" was never used, but places the expression in a
      never-executed codepath of a ternary expression, forcing this
      statement to be a no-op.
      
      Static analyzers which are codepath sensitive, like Clang's scan-build,
      will only trace along the no-op codepath and therefore will never
      evaluate the voidification clause. The result is a lot of warning noise
      like this:
      
      "warning: Value stored to 'x' during its initialization is never read"
      
      This CL removes the ternary expression from ALLOW_UNUSED_LOCAL so that the voidification statement is evaluated by path sensitive checkers. The build size was not affected by this change, therefore it's reasonable to assume that this won't have an effect on runtime behavior.
      
      R=pkasting@chromium.org
      CC=wez@chromium.org
      BUG=687243
      
      Review-Url: https://codereview.chromium.org/2838713002
      Cr-Commit-Position: refs/heads/master@{#467215}
      d10bb7f7
    • ssid's avatar
      [memory-infra] Remove MemoryDumpManagerDelegate · f91ad00d
      ssid authored
      This CL removes the unnecessary Delegate in MemoryDumpManager and just
      uses a callback to request global dumps.
      
      BUG=703184
      
      Review-Url: https://codereview.chromium.org/2819413002
      Cr-Commit-Position: refs/heads/master@{#467197}
      f91ad00d
    • erikchen's avatar
      Add a field platform_private_footprint_ to ProcessMemoryTotals. · c874a288
      erikchen authored
      The field holds platform-specific data that will be used by the Memory-Infra
      service to compute the private memory footprint.
      
      This CL populates the field on macOS, and leaves TODOs to populate the field for
      other OSes.
      
      BUG=707021
      
      Review-Url: https://codereview.chromium.org/2838803003
      Cr-Commit-Position: refs/heads/master@{#467177}
      c874a288
  2. 25 Apr, 2017 10 commits
  3. 24 Apr, 2017 6 commits
  4. 23 Apr, 2017 1 commit
  5. 21 Apr, 2017 8 commits
  6. 20 Apr, 2017 12 commits