1. 09 Nov, 2017 1 commit
  2. 08 Nov, 2017 2 commits
  3. 07 Nov, 2017 1 commit
  4. 02 Nov, 2017 1 commit
    • Eugene But's avatar
      Made WebUsage enabled by default. · 0a8cfe46
      Eugene But authored
      When Chrome used UIWebView it was safer to have NO as default value for
      webUsageEnabled property. This is because Incognito feature was modal
      and non-active browser state had disabled web usage for all web
      After switching to WKWebView the only case when webUsageEnabled is NO
      is during browsing data clearing. So it makes sense to use YES as the
      default value for webUsageEnabled property.
      Bug: 705819
      Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
      Change-Id: I68d22d92a2a36b07b2f89e329363681addc2f414
      Reviewed-on: https://chromium-review.googlesource.com/750049
      Commit-Queue: Eugene But <eugenebut@chromium.org>
      Reviewed-by: 's avatarSylvain Defresne <sdefresne@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#513580}
  5. 27 Oct, 2017 1 commit
  6. 26 Oct, 2017 1 commit
  7. 24 Oct, 2017 2 commits
    • Jinsuk Kim's avatar
      Enforce CheckDeps on embedder Java files · 5a092677
      Jinsuk Kim authored
      Currently embedders can (and do) import Java sources that are
      not from 'content_public' packages. This CL turns on java_checker.py
      in presubmit script, and enforces basic DEPS rules in chrome/ (and
      android_webview etc.) that allows for only including content_public
      packages. This is to define content layer API boundary clearly on
      Java side.
      There are still exceptions allowed inevitably. But the updated rules
      will still help discourage any more non-public classes from being
      referenced by embedders. All the exceptions will be fixed moving forward,
      and the include rules will be updated to be more intuitive by changing
      the current directory layout in content so that all non_public packages
      move out from content/public/android/java to somewhere else, like
      content/android/java or so.
      Test: python buildtools/checkdeps/checkdeps.py
      Bug: 617324
      Change-Id: Ibb00fdfcd3166f502babc7f424917b8ffa6e5c94
      Reviewed-on: https://chromium-review.googlesource.com/727079Reviewed-by: 's avatarWei-Yin Chen (陳威尹) <wychen@chromium.org>
      Reviewed-by: 's avatarTed Choc <tedchoc@chromium.org>
      Reviewed-by: 's avatarMathieu Perreault <mathp@chromium.org>
      Reviewed-by: 's avatarBrett Wilson <brettw@chromium.org>
      Reviewed-by: 's avatarBo <boliu@chromium.org>
      Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#511288}
    • Ivan Kotenkov's avatar
      Convert 0 and NULL to nullptr in components. · 75b1c3ae
      Ivan Kotenkov authored
      Steps to replicate:
      1. Build clang-tidy and clang-apply-replacements as described here: https://chromium.googlesource.com/chromium/src/+/lkcr/docs/clang_tidy.md
      2. Build targets necessary for the change in out/gn.
      3. Generate the compilation database:
        tools/clang/scripts/generate_compdb.py -p out/gn > compile_commands.json
      4. Run clang-tidy and apply replacements:
        cd out/gn && PATH_TO_RUN_CLANG_TIDY/run-clang-tidy.py -p ../../ -clang-tidy-binary PATH_TO_CLANG_TIDY_BINARY -clang-apply-replacements-binary PATH_TO_CLANG_APPLY_REPLACEMENTS_BINARY -checks=-*,modernize-use-nullptr -fix -j 8 DIR_TO_CONVERT
      Bug: 403854, 776257
      Change-Id: Ifd0c147ac6866beacffbddb0c56b20502cb4f127
      Reviewed-on: https://chromium-review.googlesource.com/732308Reviewed-by: 's avatarJochen Eisinger <jochen@chromium.org>
      Commit-Queue: Ivan Kotenkov <kotenkov@yandex-team.ru>
      Cr-Commit-Position: refs/heads/master@{#511144}
  8. 18 Oct, 2017 1 commit
  9. 17 Oct, 2017 1 commit
  10. 04 Oct, 2017 1 commit
  11. 27 Sep, 2017 1 commit
  12. 21 Sep, 2017 1 commit
  13. 12 Sep, 2017 1 commit
  14. 22 Aug, 2017 1 commit
  15. 18 Aug, 2017 1 commit
  16. 14 Aug, 2017 1 commit
  17. 07 Aug, 2017 1 commit
  18. 02 Aug, 2017 1 commit
  19. 01 Aug, 2017 1 commit
  20. 31 Jul, 2017 1 commit
  21. 24 Jul, 2017 1 commit
  22. 21 Jul, 2017 2 commits
    • Ramin Halavati's avatar
      Updating traffic annotation proto and annotations. · 3b979783
      Ramin Halavati authored
      Three fields in traffic annotation proto are updated and all fomer annotations
      required update.
      In proto3, we cannot specify default value for fields. Enum fields get their
      first choice by default and boolean fields get false by default. This way if
      one does not specify the value for one field, we cannot distinguish it from the
      case that the default value is given as input. To overcome this problem, the
      semantics::destination field and policy::cookies_allowed are updated.
      Also an extra field named comments is added for possible extra required
      human readable comments.
      Bug: 656607
      Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
      Change-Id: Ib6ac74f2abafb16e18283f1b2559f866f0539eea
      Reviewed-on: https://chromium-review.googlesource.com/579188
      Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
      Reviewed-by: 's avatarJochen Eisinger <jochen@chromium.org>
      Reviewed-by: 's avatarDominic Battré <battre@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#488633}
    • Ben Goodger's avatar
      Allow WebContentsObservers to bind InterfaceRequests from frames. · 9e24929e
      Ben Goodger authored
      WebContentsObservers will now be called prior to ContentBrowserClient::BindInterfaceRequestForFrame to see if they can bind requests for a particular RFH.
      This allows us to wean the last few embedder use cases of RenderFrameHost's interface registry off it, to using their own.
      TEST=Contextual search in Clank.
      Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
      Change-Id: I02afe864ead7352d8ef4829300518b9fe2d81e37
      Reviewed-on: https://chromium-review.googlesource.com/544215
      Commit-Queue: Ben Goodger <ben@chromium.org>
      Reviewed-by: 's avatarKen Rockot <rockot@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#488566}
  23. 19 Jul, 2017 1 commit
  24. 17 Jul, 2017 1 commit
  25. 07 Jul, 2017 1 commit
  26. 06 Jul, 2017 1 commit
  27. 16 Jun, 2017 1 commit
    • dschuyler's avatar
      [i18n] components directory to $i18n{} · 9ab6f180
      dschuyler authored
      This CL changes i18n-content and i18n-value (the old way) to
      $i18n{} (the new way). There should be no functionality or UI
      changes apparent to the user.
      Review-Url: https://codereview.chromium.org/2908353003
      Cr-Commit-Position: refs/heads/master@{#479896}
  28. 15 Jun, 2017 1 commit
  29. 13 Jun, 2017 1 commit
  30. 07 Jun, 2017 1 commit
  31. 06 Jun, 2017 1 commit
  32. 02 Jun, 2017 1 commit
  33. 17 May, 2017 1 commit
  34. 12 May, 2017 2 commits
    • gab's avatar
      Add missing IWYU message_loop.h includes. · f64a25e3
      gab authored
      This is a pre-req to removing the dependency from RunLoop->MessageLoop
      as many files only include run_loop.h but instantiate a MessageLoop.
      The following fix script was applied to each file in the codebase
      (plus a few hand fixes for DEPS and for //base):
      def Fix(file_path):
        content = refactor_lib.ReadFile(file_path)
        # Assume fwd-decls are correct in first pass.
        if 'class MessageLoop;' in content:
          return False
        if 'class MessageLoopForUI;' in content:
          return False
        if 'class MessageLoopForIO;' in content:
          return False
        # Using base:: prefix ensures we don't match fwd-decls and other things.
        # Will require a few fixups for missing includes in //base proper.
        # Complex prefix in regex attempts to skip comments.
        matches = re.compile(r'(\n *[^/\n][^/\n][^/\n]*base::MessageLoop(ForUI|ForIO)?\b[^*])', re.DOTALL).findall(content)
        if not matches:
          return False
        # Ignore unique pointers in headers in first pass...
        if os.path.splitext(file_path)[1] == '.h':
          found = False
          for match in matches:
            if not 'std::unique_ptr<base::MessageLoop' in match[0]:
              found = True
          if not found:
            return False
        updated_content = refactor_lib.AddInclude(file_path, content, "base/message_loop/message_loop.h")
        if updated_content == content:
          return False
        # Write updated file
        refactor_lib.WriteFile(file_path, updated_content)
        return True
      Review-Url: https://codereview.chromium.org/2876013002
      Cr-Commit-Position: refs/heads/master@{#471412}
    • fdoray's avatar
      Use TaskScheduler instead of SequencedWorkerPool in content_extractor_browsertest.cc. · f3036291
      fdoray authored
      SequencedWorkerPool is being deprecated in favor of TaskScheduler.
      Review-Url: https://codereview.chromium.org/2881853002
      Cr-Commit-Position: refs/heads/master@{#471387}
  35. 04 May, 2017 1 commit
  36. 03 May, 2017 1 commit