1. 26 Apr, 2017 1 commit
  2. 25 Apr, 2017 2 commits
  3. 24 Apr, 2017 2 commits
  4. 23 Apr, 2017 1 commit
  5. 21 Apr, 2017 5 commits
  6. 20 Apr, 2017 5 commits
  7. 19 Apr, 2017 2 commits
  8. 18 Apr, 2017 2 commits
  9. 13 Apr, 2017 5 commits
    • mattm's avatar
      Add some public_deps for //headless:headless_lib. · d9848157
      mattm authored
      headless/public/util/managed_dispatch_url_request_job.h includes files from //base and //net, so they should be public dependencies.
      
      Example error:
      In file included from ../../headless/public/util/deterministic_dispatcher_test.cc:15:
      In file included from ../../headless/public/util/testing/fake_managed_dispatch_url_request_job.h:13:
      In file included from ../../headless/public/util/managed_dispatch_url_request_job.h:11:
      In file included from ../../net/url_request/url_request.h:26:
      In file included from ../../net/base/net_error_details.h:9:
      In file included from ../../net/http/http_response_info.h:14:
      In file included from ../../net/ssl/ssl_info.h:20:
      In file included from ../../net/ssl/ssl_config.h:12:
      In file included from ../../net/cert/x509_certificate.h:25:
      ../../third_party/boringssl/src/include/openssl/base.h:68:10: fatal error: 'openssl/opensslconf.h' file not found
      
      BUG=none
      
      Review-Url: https://codereview.chromium.org/2816913002
      Cr-Commit-Position: refs/heads/master@{#464473}
      d9848157
    • alexclarke's avatar
      Headless: A better GenericURLRequestJob::Delegate API · a612e798
      alexclarke authored
      The old Delegate API made it rather awkward to get at the full details of
      the request.  This new API fixes that, whilst allowing more flexible
      request modification.
      
      BUG=546953
      
      Review-Url: https://codereview.chromium.org/2815003003
      Cr-Commit-Position: refs/heads/master@{#464382}
      a612e798
    • alexclarke's avatar
      Add HeadlessTabSocket · 8196d431
      alexclarke authored
      This lets a C++ embedder send messages to and from JS on a HeadlessWebContents.
      Note for this to work the headless browser context must have been created with
      AddTabSocketMojoBindings and the headless web contents must have been created
      with CreateTabSocket(true).
      
      This will not affect chrome.exe --headless because only a C++ embedder can set
      the above options.
      
      Note that C++ embedders can already do this and more with the current headless API.
      At a later date we will remove the more general headless mojo interface in favor of
      TabSockets, unless it turns out somebody is actually using them.
      
      BUG=546953
      
      Review-Url: https://codereview.chromium.org/2813953002
      Cr-Commit-Position: refs/heads/master@{#464327}
      8196d431
    • dvallet's avatar
      Revert of Enable crashpad for Mac (patchset #4 id:60001 of... · 84d7dbe5
      dvallet authored
      Revert of Enable crashpad for Mac (patchset #4 id:60001 of https://codereview.chromium.org/2816593006/ )
      
      Reason for revert:
      mac_chromium10.10_rel_ng buildbot failing in browsertests
      
      Original issue's description:
      > Enable crashpad for Mac.
      >
      > This follows the same logic as using breakpad in linux with flags --enable_crash-reporter and --crash-dumps-dir folders.
      >
      > For headless_shell target, we need to include the Helper crashpad_handler in the build. For --headless, this is already available in the framework bundle.
      >
      > BUG=687407
      >
      > Review-Url: https://codereview.chromium.org/2816593006
      > Cr-Commit-Position: refs/heads/master@{#464289}
      > Committed: https://chromium.googlesource.com/chromium/src/+/ecb2ad24952b077e71e56ba9d3edfc83c522f32a
      
      TBR=skyostil@chromium.org,jzfeng@chromium.org
      # Skipping CQ checks because original CL landed less than 1 days ago.
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      BUG=687407
      
      Review-Url: https://codereview.chromium.org/2819503002
      Cr-Commit-Position: refs/heads/master@{#464308}
      84d7dbe5
    • dvallet's avatar
      Enable crashpad for Mac. · ecb2ad24
      dvallet authored
      This follows the same logic as using breakpad in linux with flags --enable_crash-reporter and --crash-dumps-dir folders.
      
      For headless_shell target, we need to include the Helper crashpad_handler in the build. For --headless, this is already available in the framework bundle.
      
      BUG=687407
      
      Review-Url: https://codereview.chromium.org/2816593006
      Cr-Commit-Position: refs/heads/master@{#464289}
      ecb2ad24
  10. 12 Apr, 2017 1 commit
  11. 11 Apr, 2017 3 commits
    • jdoerrie's avatar
      Reland of Change base::Value::ListStorage to std::vector<base::Value> · a5676c60
      jdoerrie authored
      The compilation on ChromeOS failed for the original CL
      (http://crrev.com/2811673002), it is likely that a simple rebase fixes the
      issue.
      
      This patchset is equivalent to issue 2740143002 at patchset 14, simply another
      rebase took place.
      
      Original description follows:
      
      This CL is a first step to inlining base::ListValue. It is proposed to use an
      std::vector<base::Value> as the underlying ListStorage. This CL implements the
      change and updates the code accordingly.
      
      BUG=646113
      TBR=brettw@chromium.org,rdevlin.cronin@chromium.org,flackr@chromium.org,skym@chromium.org,rsesek@chromium.org,bajones@chromium.org,dbeam@chromium.org,stevenjb@chromium.org
      CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
      
      Review-Url: https://codereview.chromium.org/2809023003
      Cr-Commit-Position: refs/heads/master@{#463684}
      a5676c60
    • rouslan's avatar
      Revert of Change base::Value::ListStorage to std::vector<base::Value>... · df600cdc
      rouslan authored
      Revert of Change base::Value::ListStorage to std::vector<base::Value> (patchset #14 id:260001 of https://codereview.chromium.org/2740143002/ )
      
      Reason for revert:
      Appears to have broken compile on ChromeOS. Needs a rebase?
      
      FAILED: obj/extensions/browser/api/networking_private/networking_private/networking_private_chromeos.o
      In file included from ../../extensions/browser/api/networking_private/networking_private_chromeos.cc:21:
      In file included from ../../chromeos/network/network_connection_handler.h:18:
      In file included from ../../chromeos/cert_loader.h:18:
      In file included from ../../net/cert/cert_database.h:13:
      ../../net/cert/x509_certificate.h:22:10: fatal error: 'net/net_features.h' file not found
      #include "net/net_features.h"
               ^~~~~~~~~~~~~~~~~~~~
      1 error generated.
      
      https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20ChromeOS/builds/32152
      
      Original issue's description:
      > Change base::Value::ListStorage to std::vector<base::Value>
      >
      > This CL is a first step to inlining base::ListValue. It is proposed to use an
      > std::vector<base::Value> as the underlying ListStorage. This CL implements the
      > change and updates the code accordingly.
      >
      > TBR=bajones@chromium.org, dbeam@chromium.org, stevenjb@chromium.org
      > BUG=646113
      > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
      >
      > Review-Url: https://codereview.chromium.org/2740143002
      > Cr-Commit-Position: refs/heads/master@{#463618}
      > Committed: https://chromium.googlesource.com/chromium/src/+/ebab0defaea3aed024283a64088ebc0cd352b47f
      
      TBR=brettw@chromium.org,rdevlin.cronin@chromium.org,flackr@chromium.org,skym@chromium.org,rsesek@chromium.org,bajones@chromium.org,dbeam@chromium.org,stevenjb@chromium.org,jdoerrie@chromium.org
      # Skipping CQ checks because original CL landed less than 1 days ago.
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      BUG=646113
      
      Review-Url: https://codereview.chromium.org/2816513002
      Cr-Commit-Position: refs/heads/master@{#463630}
      df600cdc
    • jdoerrie's avatar
      Change base::Value::ListStorage to std::vector<base::Value> · ebab0def
      jdoerrie authored
      This CL is a first step to inlining base::ListValue. It is proposed to use an
      std::vector<base::Value> as the underlying ListStorage. This CL implements the
      change and updates the code accordingly.
      
      TBR=bajones@chromium.org, dbeam@chromium.org, stevenjb@chromium.org
      BUG=646113
      CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
      
      Review-Url: https://codereview.chromium.org/2740143002
      Cr-Commit-Position: refs/heads/master@{#463618}
      ebab0def
  12. 10 Apr, 2017 2 commits
  13. 08 Apr, 2017 1 commit
    • jzfeng's avatar
      Let users to print a webpage into pdf through PrintToPDF devtools command · 0cbec8b3
      jzfeng authored
      under headless chrome.
      
      This patch includes:
      1) adding a new print manager, i.e., HeadlessPrintManager to handle all the
         printing related IPCs for headless.
      2) plumbing through the pdf data from HeadlessPrintManager to
         HeadlessDevToolsManagerDelegate to handle the PrintToPDF command.
      3) adding a new option to PrintWebViewHelper on Mac to return all the printed
         pages in the first PrintHostMsg_DidPrintPage message as a single file.
         This makes it conform to Linux and Windows, which simplify the logic in
         HeadlessPrintManager.
      
      This patch guarantees that HeadlessPrintManager is the only IPC entry point.
      In the future, if there are requirements to support the same devtools command
      in regular chrome, we may consider a framework to ensure multiple print managers
      to work properly under a content embedder.
      
      BUG=603559
      
      Review-Url: https://codereview.chromium.org/2780433002
      Cr-Commit-Position: refs/heads/master@{#463105}
      0cbec8b3
  14. 07 Apr, 2017 1 commit
    • jdoerrie's avatar
      Remove base::Value::CreateNullValue · e067999a
      jdoerrie authored
      This change removes base::Value::CreateNullValue in favor of Value's default constructor. In particular, this change
      
      - Replaces |Value::CreateNullValue()| with |MakeUnique<Value>()|.
        - Adds #includes of base/memory/ptr_util.h where needed.
        - Replaces |std::unique_ptr<Value>| with |auto| where appropriate.
      - Replaces |*Value::CreateNullValue()| with |Value()|.
      - Replaces |Value::CreateNullValue().release()| with |new Value()|.
      
      BUG=646113
      CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
      
      Review-Url: https://codereview.chromium.org/2792573002
      Cr-Commit-Position: refs/heads/master@{#462794}
      e067999a
  15. 05 Apr, 2017 1 commit
  16. 03 Apr, 2017 4 commits
  17. 31 Mar, 2017 2 commits