1. 15 Mar, 2017 1 commit
    • dbeam's avatar
      Make .clang-format files smaller after clang-format roll · 8d9c69e2
      dbeam authored
      -style=Chromium now enables include sorting implicitly, so no need to
      turn that on explicitly anymore. Likewise,
      AllowShortFunctionsOnASingleLine now defaults to Empty.
      
      Finally, all grit instructions in .js files are now in comments (when
      they can be), so `JavaScriptQuotes: Leave` is no longer needed either.
      
      No intended behavior change.
      
      Based on https://crrev.com/2729033002/ by Nico <thakis@chromium.org>
      
      BUG=567770
      CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
      
      Review-Url: https://codereview.chromium.org/2745303002
      Cr-Commit-Position: refs/heads/master@{#457024}
      8d9c69e2
  2. 02 Feb, 2017 1 commit
    • thakis's avatar
      Let clang-format sort includes. · 6b08b5d1
      thakis authored
      After this, `git cl format` will reorder includes in blocks of #includes
      that are not separated by newlines.
      
      This works in almost all cases, but it can break some code e.g.
      
        #include <windows.h>
        #include <shellapi.h>
      
      clang-format will reorder these now, but shellapi.h only compiles if
      windows.h was included first. Relying on this is brittle, so replace
      code like this with
      
        #include <windows.h>
      
        // Must be after windows.h:
        #include <shellapi.h>
      
      Since clang-format doesn't reorder across blocks, this will do the right
      thing.
      
      This also means you're still on the hook of putting blocks with user headers,
      C++ headers, and C headers in the right order.
      
      This will hopefully replace src/tools/sort-headers.py which contains
      some hacky heuristics -- but just inserting newlines between includes
      when needed (with a comment) seems like a better tradeoff anyhow.
      And the automatic integration with `git cl format` is nice.
      
      (clang-format has IncludeIsMainRegex and IncludeCategories for adding
      heuristics, but we shouldn't use these, they're too complicated.)
      
      BUG=688155
      TBR=brettw
      
      Review-Url: https://codereview.chromium.org/2669263003
      Cr-Commit-Position: refs/heads/master@{#447875}
      6b08b5d1
  3. 17 Jul, 2015 1 commit
  4. 16 Jul, 2015 1 commit
  5. 01 Dec, 2014 1 commit
  6. 26 Nov, 2014 1 commit
  7. 25 Nov, 2014 1 commit
  8. 19 Nov, 2014 1 commit
  9. 14 Nov, 2014 1 commit
  10. 02 Nov, 2014 1 commit
  11. 31 Oct, 2014 2 commits
  12. 25 Sep, 2014 1 commit
  13. 01 Nov, 2013 1 commit