GitLab

CL [1] has prevented gin from recreating wrappers after GC,
so doesn't fire timer if its wrapper is empty otherwise it will
be crashed.

[1] https://chromium-review.googlesource.com/475077

BUG=707689

Review-Url: https://codereview.chromium.org/2830723003
Cr-Commit-Position: refs/heads/master@{#466314}

I'll extend the file to talk about how to use gin without the rest of
chromium, and add examples of how to startup V8, and how to wrap C++
objects.

BUG=v8:5866
TBR=tsepez@chromium.org

Review-Url: https://codereview.chromium.org/2830793006
Cr-Commit-Position: refs/heads/master@{#465970}

Add an Arguments::GetAll() function that returns all arguments as a
std::vector<v8::Local<v8::Value>>. This is more clear, concise, and
slightly more performant than the alternative of using
Arguments::GetRemaining() since it doesn't require trying to convert
and avoids unnecessary calls.

Add a test for the new method.

Reverted due to a compile error, now fixed.

BUG=None

Review-Url: https://codereview.chromium.org/2822373002
Cr-Commit-Position: refs/heads/master@{#465627}

Revert of [gin] Add Arguments::GetAll() (patchset #1 id:1 of https://codereview.chromium.org/2824883002/ )

Reason for revert:
Broke Win64 Compile: https://build.chromium.org/p/chromium/builders/Win%20x64/builds/10538

Original issue's description:
> [gin] Add Arguments::GetAll()
>
> Add an Arguments::GetAll() function that returns all arguments as a
> std::vector<v8::Local<v8::Value>>. This is more clear, concise, and
> slightly more performant than the alternative of using
> Arguments::GetRemaining() since it doesn't require trying to convert
> and avoids unnecessary calls.
>
> Add a test for the new method.
>
> BUG=None
>
> Review-Url: https://codereview.chromium.org/2824883002
> Cr-Commit-Position: refs/heads/master@{#465253}
> Committed: https://chromium.googlesource.com/chromium/src/+/3853b0bd67adec1b98b222196b89aca2468b9fe2

TBR=jochen@chromium.org,rdevlin.cronin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=None

Review-Url: https://codereview.chromium.org/2820113004
Cr-Commit-Position: refs/heads/master@{#465268}

Add an Arguments::GetAll() function that returns all arguments as a
std::vector<v8::Local<v8::Value>>. This is more clear, concise, and
slightly more performant than the alternative of using
Arguments::GetRemaining() since it doesn't require trying to convert
and avoids unnecessary calls.

Add a test for the new method.

BUG=None

Review-Url: https://codereview.chromium.org/2824883002
Cr-Commit-Position: refs/heads/master@{#465253}

This changes gin::Wrappable to track its cleanup
state in order to prevent async operations from
recreating a wrapper between first and second weak
callbacks.

GetWrapper is changed to return a MaybeLocal,
and callers are updated accordingly; checking
in some cases and failing gracefully in others.

Mojo JS's WaitingCallback is changed to silently
ignore handle notifications if its wrapper is
no longer alive.

BUG=707689

Change-Id: I3fc11a24209f0ef35bfa18556f5734c4b18ae229
Reviewed-on: https://chromium-review.googlesource.com/475077
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#464134}

features::kV8NoTurbo is defined in //gin:gin_features. Since this is a
global and this build target has dependencies from multiple other
targets it must be a component instead of a source_set to avoid multiple
definitions. As a component it must then also have its own _export.h
header.

BUG=None

Review-Url: https://codereview.chromium.org/2799103004
Cr-Commit-Position: refs/heads/master@{#462494}

Removes the V8 Future experiment since it conflicts with the V8NoTurbo
experiment and adds confusion as to how to enable / disable Ignition+
TurboFan.

Also make the description for the V8NoTurbo about://flags entry clearer.

BUG=chromium:703569,chromium:705476

Review-Url: https://codereview.chromium.org/2786633002
Cr-Commit-Position: refs/heads/master@{#460380}

Currently, in order to get at the creation context of the holder, one
has to do the following:
v8::Local<v8::Object> holder;
arguments->GetHolder(&holder);
v8::Local<v8::Context> context = holder->CreationContext();

This isn't terrible, but it's a little verbose when all we really want
is FunctionCallbackInfo::Holder::CreationContext(). Add a method to get
at it directly.

BUG=None

Review-Url: https://codereview.chromium.org/2765853004
Cr-Commit-Position: refs/heads/master@{#459251}

If anyone still needs them, please tell me about your use case
(and feel free to revert).

Ran `git ls-files -- '*.isolate' | xargs git rm`

BUG=703799
NOTRY=true
TBR=jochen,davidben

Review-Url: https://codereview.chromium.org/2766673003
Cr-Commit-Position: refs/heads/master@{#458595}

BUG=none
R=yangguo@chromium.org

Review-Url: https://codereview.chromium.org/2756673004
Cr-Commit-Position: refs/heads/master@{#458029}

This change requires the user of LazyInstance to explicitly select
either ::DestructorAtExit or ::Leaky. It seems clear that many users of
LazyInstance have just gone with default and are either unaware or
didn't consider that the default requires running an AtExit at process
shutdown.

As a first step, make this choice explicit, and update current users
to be ::DestructorAtExit to maintain current behaviour. Follow ups can
then attempt to consider individual switches from DestructorAtExit to
Leaky including reviewers with domain-specific knowledge.

i.e. No intended behaviour change from this CL.

R=thakis@chromium.org

Lots of TBRs for mechanical changes:
boliu: android_webview/
danakj: cc/
dmurph: storage/
jam: content/ ipc/, mojo/
jbauman: gpu/
jochen: gin/
oshima: chromeos/
raymes: ppapi/
rdevlin.cronin: extensions/
rockot: device/, services/
rogerta: google_apis/
rsleevi: net/, crypto/
sdefresne: components/, ios/
sergeyu: jingle/
slan: chromecast/
thakis: base/, chrome/, third_party/, tools/, ui/
vitalybuka: printing/
wez: remoting/

TBR=above
BUG=698982
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_site_isolation;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2733283002
Cr-Commit-Position: refs/heads/master@{#455405}

Adds a V8NoTurbo experiment to disable the new Ignition + TurboFan
compiler pipeline. Also changes the description of V8Future to refer to
future V8 execution features rather than the new compilation pipeline
which will soon be enabled by default.

BUG=chromium:692409

Review-Url: https://codereview.chromium.org/2740543002
Cr-Commit-Position: refs/heads/master@{#455259}

This patch fixes all of the places where the auto raw
pointer deduction is happening on linux

R=danakj@chromium.org
BUG=554600

Review-Url: https://codereview.chromium.org/2691393002
Cr-Commit-Position: refs/heads/master@{#452312}

Revert of Use TaskScheduler instead of WorkerPool in v8_platform.cc. (patchset #18 id:340001 of https://codereview.chromium.org/2610473002/ )

Reason for revert:
Causing extensions_unittests to hang and take 15 minutes.

BUG=694828

Original issue's description:
> Use TaskScheduler instead of WorkerPool in v8_platform.cc.
>
> The following traits are used:
>
> Priority: Inherited (default)
>   The priority is inherited from the calling context (i.e. TaskTraits
>   are initialized with the priority of the current task).
>
> Shutdown behavior: CONTINUE_ON_SHUTDOWN
>   Tasks posted with this mode which have not started executing before
>   shutdown is initiated will never run. Tasks with this mode running at
>   shutdown will be ignored (the worker will not be joined).
>
>   Note: Tasks that were previously posted to base::WorkerPool should
>   use this shutdown behavior because this is how base::WorkerPool
>   handles all its tasks.
>
> MayBlock():
>   The task may block.
>
> BUG=659191
>
> Review-Url: https://codereview.chromium.org/2610473002
> Cr-Commit-Position: refs/heads/master@{#449976}
> Committed: https://chromium.googlesource.com/chromium/src/+/b83be4ca0e00b50b17619adf7f7de275455e9852

TBR=jochen@chromium.org,fdoray@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=659191

Review-Url: https://codereview.chromium.org/2711703002
Cr-Commit-Position: refs/heads/master@{#452058}

gin::IsolateHolder has 3 types of constructors, and one of them
igored an argument.
This CL makes it to use |access_mode| in the argument.

BUG=None

Review-Url: https://codereview.chromium.org/2709473002
Cr-Commit-Position: refs/heads/master@{#451583}

The following traits are used:

Priority: Inherited (default)
  The priority is inherited from the calling context (i.e. TaskTraits
  are initialized with the priority of the current task).

Shutdown behavior: CONTINUE_ON_SHUTDOWN
  Tasks posted with this mode which have not started executing before
  shutdown is initiated will never run. Tasks with this mode running at
  shutdown will be ignored (the worker will not be joined).

  Note: Tasks that were previously posted to base::WorkerPool should
  use this shutdown behavior because this is how base::WorkerPool
  handles all its tasks.

MayBlock():
  The task may block.

BUG=659191

Review-Url: https://codereview.chromium.org/2610473002
Cr-Commit-Position: refs/heads/master@{#449976}

Removes extra v8 snapshot and natives validation on Windows. This was
added a while ago to track down a bug with corrupted v8 files.
This is a relanding of:
https://codereview.chromium.org/2103903002/

BUG=501799

Review-Url: https://codereview.chromium.org/2680653002
Cr-Commit-Position: refs/heads/master@{#448646}

BUG=686604
R=jochen@chromium.org

Review-Url: https://codereview.chromium.org/2660423003
Cr-Commit-Position: refs/heads/master@{#447639}

When run benchmarks on Android, we don't get runtime statistics result because
we register an observer to trigger a flag to enable it, however, tracing is
started before observers are added to observer list in this case, thus we force
to fire observer when we register an observer through platform API when
recording is in progress.

BUG=682167

Review-Url: https://codereview.chromium.org/2650943008
Cr-Commit-Position: refs/heads/master@{#446713}

This severs some of the remaining ties between browser dll and gin-proper.

R=jochen@chromium.org
BUG=581766

Review-Url: https://codereview.chromium.org/2621143007
Cr-Commit-Position: refs/heads/master@{#445133}

Changes the current V8 Ignition Experiment to instead test Ignition and
Turbofan, the future compiler configuration of V8.

BUG=v8:5870

Review-Url: https://codereview.chromium.org/2643923004
Cr-Commit-Position: refs/heads/master@{#444881}

Some utility processes need to initailize Blink and V8, and V8
initialization now assumes the main thread provides a scheduler; but
a utility process' main thread does not in fact provide one.

This eliminates the recently introduced assumption of a non-null scheduler,
defaulting to the previous behavior (using the current ThreadTaskRunnerHandle)
when no scheduler is provided.

BUG=679911
R=jochen@chromium.org

Review-Url: https://codereview.chromium.org/2624033002
Cr-Commit-Position: refs/heads/master@{#442901}

Per the effort of getting rid of default task queue in scheduler, post per-isolate
tasks to renderer-wide timer task queue.

BUG=676805

Review-Url: https://codereview.chromium.org/2589363003
Cr-Commit-Position: refs/heads/master@{#441114}

Remove remaining useless class and struct forward declarations from
Chromium (excluding third_party directory) using a homemade script
available in bug 662195 comments. An up-and-running presubmit check
is now available and should prevent new useless forward declarations
to come up.

BUG=662195
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_nacl_sdk

Review-Url: https://codereview.chromium.org/2554863002
Cr-Commit-Position: refs/heads/master@{#436883}

BUG=655635
R=ulan@chromium.org

Review-Url: https://codereview.chromium.org/2478813002
Cr-Commit-Position: refs/heads/master@{#430547}

Revert of [Tracing] Create TracingCategoryObserver in gin/. (patchset #2 id:20001 of https://codereview.chromium.org/2456073004/ )

Reason for revert:
Revert this patch because clusterfuzz complains about bad casting.

Original issue's description:
> [Tracing] Create TracingCategoryObserver in gin/.
>
> Previously we implemented TracingCategoryObserver in V8 in order to do fast
> category check when we enable V8 specific tracing feature in a unified way.
> This patch calls the the creation of TracingCategoryObserver from chrome and
> adds it to observer list.
>
> BUG=v8:5590
>
> Committed: https://crrev.com/f3b25db89a2dfaad59a90573fe355bc60db0a899
> Cr-Commit-Position: refs/heads/master@{#428756}

TBR=jochen@chromium.org,fmeawad@chromium.org,alph@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=v8:5590

Review-Url: https://codereview.chromium.org/2471563003
Cr-Commit-Position: refs/heads/master@{#429160}

Previously we implemented TracingCategoryObserver in V8 in order to do fast
category check when we enable V8 specific tracing feature in a unified way.
This patch calls the the creation of TracingCategoryObserver from chrome and
adds it to observer list.

BUG=v8:5590

Review-Url: https://codereview.chromium.org/2456073004
Cr-Commit-Position: refs/heads/master@{#428756}

Observer lists now support range-based for loops.

BUG=655021

Review-Url: https://codereview.chromium.org/2417423002
Cr-Commit-Position: refs/heads/master@{#425657}

Do the conversion between v8::ConvertableToTraceFormat to
base::trace_event::ConvertableToTraceFormat

BUG=406277

Review-Url: https://codereview.chromium.org/2368483002
Cr-Commit-Position: refs/heads/master@{#421485}

BUG=406277

Review-Url: https://codereview.chromium.org/2347033002
Cr-Commit-Position: refs/heads/master@{#420539}

BUG=406277

Review-Url: https://codereview.chromium.org/2349563002
Cr-Commit-Position: refs/heads/master@{#419903}

This removes all .gyp files not called "compiled_resources" in the main Chromium repository.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng

Review-Url: https://codereview.chromium.org/2332843004
Cr-Commit-Position: refs/heads/master@{#418654}

The runtime dependencies data was successfully transitioned to GN.

Keep non-testing isolate as some projects (v8, webrtc) still need some. They
will be curated incrementally.

Ran:
  $ git rm $(git ls-files -- "*.isolate" | grep -i test | grep -v testserver)
  $ git ls-files -- "*.isolate" | wc -l
  14

TBR=dpranke@chromium.org
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2257893002
Cr-Commit-Position: refs/heads/master@{#415954}

R=jochen@chromium.org
BUG=chromium:630217

Review-Url: https://codereview.chromium.org/2236443002
Cr-Commit-Position: refs/heads/master@{#415651}

This is another pass of migration of includes for users of histogram
macros. This doesn't fully complete the migration, but gets us closer
to the end result.

A few files needed to include both headers as they use both
macros and the raw API.

BUG=416479
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=jam@chromium.org

Review-Url: https://codereview.chromium.org/2293583002
Cr-Commit-Position: refs/heads/master@{#415067}

Adds CodeAndMetadata measurements to the v8_browsing telemetry benchmarks.
Modifes the memory dumper to dump these stats on light dumps, if requested.
Also adds an Ignition variant for v8_browsing benchmarks.

BUG=v8:4280,v8:5019
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;

Review-Url: https://codereview.chromium.org/2257173003
Cr-Commit-Position: refs/heads/master@{#414439}

Updates the Ignition experiment to pass --ignition-staging (the intended
shipping configuration). Also remove lazy and eager variants since we aren't
interested in these any longer.

BUG=v8:5280,v8:4868

Review-Url: https://codereview.chromium.org/2264093002
Cr-Commit-Position: refs/heads/master@{#414053}

Remove chromium defaults for v8_optimized_debug and
v8_use_external_startup_data.

This is not needed after v8 provides these defaults:
https://codereview.chromium.org/2025803003/
https://codereview.chromium.org/2024833002/

It also interferes if somebody tries to override the gn args
with a different value.

BUG=chromium:616034
TBR=alokp@chromium.org, brettw@chromium.org

Committed: https://crrev.com/0fffeb2adaa3c284b760922c1aecce1516b998ce
Review-Url: https://codereview.chromium.org/2058033002
Cr-Original-Commit-Position: refs/heads/master@{#406067}
Cr-Commit-Position: refs/heads/master@{#407106}

R=primiano@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2156043002
Cr-Commit-Position: refs/heads/master@{#406345}