1. 21 Apr, 2017 1 commit
  2. 20 Apr, 2017 1 commit
  3. 19 Apr, 2017 1 commit
    • rdevlin.cronin's avatar
      [Reland][gin] Add Arguments::GetAll() · cd675450
      rdevlin.cronin authored
      Add an Arguments::GetAll() function that returns all arguments as a
      std::vector<v8::Local<v8::Value>>. This is more clear, concise, and
      slightly more performant than the alternative of using
      Arguments::GetRemaining() since it doesn't require trying to convert
      and avoids unnecessary calls.
      
      Add a test for the new method.
      
      Reverted due to a compile error, now fixed.
      
      BUG=None
      
      Review-Url: https://codereview.chromium.org/2822373002
      Cr-Commit-Position: refs/heads/master@{#465627}
      cd675450
  4. 18 Apr, 2017 2 commits
  5. 12 Apr, 2017 1 commit
    • Ken Rockot's avatar
      Prevent gin from recreating wrappers after GC · 2b0f0765
      Ken Rockot authored
      This changes gin::Wrappable to track its cleanup
      state in order to prevent async operations from
      recreating a wrapper between first and second weak
      callbacks.
      
      GetWrapper is changed to return a MaybeLocal,
      and callers are updated accordingly; checking
      in some cases and failing gracefully in others.
      
      Mojo JS's WaitingCallback is changed to silently
      ignore handle notifications if its wrapper is
      no longer alive.
      
      BUG=707689
      
      Change-Id: I3fc11a24209f0ef35bfa18556f5734c4b18ae229
      Reviewed-on: https://chromium-review.googlesource.com/475077
      Commit-Queue: Ken Rockot <rockot@chromium.org>
      Reviewed-by: default avatarJochen Eisinger <jochen@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#464134}
      2b0f0765
  6. 06 Apr, 2017 1 commit
  7. 29 Mar, 2017 1 commit
  8. 23 Mar, 2017 1 commit
    • rdevlin.cronin's avatar
      [Gin] Add Arguments::GetHolderCreationContext() · d982fdfe
      rdevlin.cronin authored
      Currently, in order to get at the creation context of the holder, one
      has to do the following:
      v8::Local<v8::Object> holder;
      arguments->GetHolder(&holder);
      v8::Local<v8::Context> context = holder->CreationContext();
      
      This isn't terrible, but it's a little verbose when all we really want
      is FunctionCallbackInfo::Holder::CreationContext(). Add a method to get
      at it directly.
      
      BUG=None
      
      Review-Url: https://codereview.chromium.org/2765853004
      Cr-Commit-Position: refs/heads/master@{#459251}
      d982fdfe
  9. 21 Mar, 2017 1 commit
  10. 20 Mar, 2017 1 commit
  11. 08 Mar, 2017 1 commit
    • scottmg's avatar
      Require explicit selection of traits for LazyInstance · 5e65e3a4
      scottmg authored
      This change requires the user of LazyInstance to explicitly select
      either ::DestructorAtExit or ::Leaky. It seems clear that many users of
      LazyInstance have just gone with default and are either unaware or
      didn't consider that the default requires running an AtExit at process
      shutdown.
      
      As a first step, make this choice explicit, and update current users
      to be ::DestructorAtExit to maintain current behaviour. Follow ups can
      then attempt to consider individual switches from DestructorAtExit to
      Leaky including reviewers with domain-specific knowledge.
      
      i.e. No intended behaviour change from this CL.
      
      R=thakis@chromium.org
      
      Lots of TBRs for mechanical changes:
      boliu: android_webview/
      danakj: cc/
      dmurph: storage/
      jam: content/ ipc/, mojo/
      jbauman: gpu/
      jochen: gin/
      oshima: chromeos/
      raymes: ppapi/
      rdevlin.cronin: extensions/
      rockot: device/, services/
      rogerta: google_apis/
      rsleevi: net/, crypto/
      sdefresne: components/, ios/
      sergeyu: jingle/
      slan: chromecast/
      thakis: base/, chrome/, third_party/, tools/, ui/
      vitalybuka: printing/
      wez: remoting/
      
      TBR=above
      BUG=698982
      CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_site_isolation;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
      
      Review-Url: https://codereview.chromium.org/2733283002
      Cr-Commit-Position: refs/heads/master@{#455405}
      5e65e3a4
  12. 07 Mar, 2017 1 commit
  13. 23 Feb, 2017 1 commit
  14. 22 Feb, 2017 1 commit
    • jam's avatar
      Revert of Use TaskScheduler instead of WorkerPool in v8_platform.cc. (patchset... · 4df731b9
      jam authored
      Revert of Use TaskScheduler instead of WorkerPool in v8_platform.cc. (patchset #18 id:340001 of https://codereview.chromium.org/2610473002/ )
      
      Reason for revert:
      Causing extensions_unittests to hang and take 15 minutes.
      
      BUG=694828
      
      Original issue's description:
      > Use TaskScheduler instead of WorkerPool in v8_platform.cc.
      >
      > The following traits are used:
      >
      > Priority: Inherited (default)
      >   The priority is inherited from the calling context (i.e. TaskTraits
      >   are initialized with the priority of the current task).
      >
      > Shutdown behavior: CONTINUE_ON_SHUTDOWN
      >   Tasks posted with this mode which have not started executing before
      >   shutdown is initiated will never run. Tasks with this mode running at
      >   shutdown will be ignored (the worker will not be joined).
      >
      >   Note: Tasks that were previously posted to base::WorkerPool should
      >   use this shutdown behavior because this is how base::WorkerPool
      >   handles all its tasks.
      >
      > MayBlock():
      >   The task may block.
      >
      > BUG=659191
      >
      > Review-Url: https://codereview.chromium.org/2610473002
      > Cr-Commit-Position: refs/heads/master@{#449976}
      > Committed: https://chromium.googlesource.com/chromium/src/+/b83be4ca0e00b50b17619adf7f7de275455e9852
      
      TBR=jochen@chromium.org,fdoray@chromium.org
      # Not skipping CQ checks because original CL landed more than 1 days ago.
      BUG=659191
      
      Review-Url: https://codereview.chromium.org/2711703002
      Cr-Commit-Position: refs/heads/master@{#452058}
      4df731b9
  15. 20 Feb, 2017 1 commit
  16. 13 Feb, 2017 1 commit
    • fdoray's avatar
      Use TaskScheduler instead of WorkerPool in v8_platform.cc. · b83be4ca
      fdoray authored
      The following traits are used:
      
      Priority: Inherited (default)
        The priority is inherited from the calling context (i.e. TaskTraits
        are initialized with the priority of the current task).
      
      Shutdown behavior: CONTINUE_ON_SHUTDOWN
        Tasks posted with this mode which have not started executing before
        shutdown is initiated will never run. Tasks with this mode running at
        shutdown will be ignored (the worker will not be joined).
      
        Note: Tasks that were previously posted to base::WorkerPool should
        use this shutdown behavior because this is how base::WorkerPool
        handles all its tasks.
      
      MayBlock():
        The task may block.
      
      BUG=659191
      
      Review-Url: https://codereview.chromium.org/2610473002
      Cr-Commit-Position: refs/heads/master@{#449976}
      b83be4ca
  17. 07 Feb, 2017 1 commit
  18. 01 Feb, 2017 1 commit
  19. 27 Jan, 2017 1 commit
    • lpy's avatar
      [gin] Fire observer after added when recording is in progress. · 48e4c328
      lpy authored
      When run benchmarks on Android, we don't get runtime statistics result because
      we register an observer to trigger a flag to enable it, however, tracing is
      started before observers are added to observer list in this case, thus we force
      to fire observer when we register an observer through platform API when
      recording is in progress.
      
      BUG=682167
      
      Review-Url: https://codereview.chromium.org/2650943008
      Cr-Commit-Position: refs/heads/master@{#446713}
      48e4c328
  20. 20 Jan, 2017 1 commit
  21. 19 Jan, 2017 1 commit
  22. 11 Jan, 2017 1 commit
    • rockot's avatar
      Tolerate a null scheduler in V8 initialization · 7b9e6bc4
      rockot authored
      Some utility processes need to initailize Blink and V8, and V8
      initialization now assumes the main thread provides a scheduler; but
      a utility process' main thread does not in fact provide one.
      
      This eliminates the recently introduced assumption of a non-null scheduler,
      defaulting to the previous behavior (using the current ThreadTaskRunnerHandle)
      when no scheduler is provided.
      
      BUG=679911
      R=jochen@chromium.org
      
      Review-Url: https://codereview.chromium.org/2624033002
      Cr-Commit-Position: refs/heads/master@{#442901}
      7b9e6bc4
  23. 03 Jan, 2017 1 commit
  24. 07 Dec, 2016 1 commit
    • jbriance's avatar
      Cleanup remaining class/struct fwd declarations · db24b9e6
      jbriance authored
      Remove remaining useless class and struct forward declarations from
      Chromium (excluding third_party directory) using a homemade script
      available in bug 662195 comments. An up-and-running presubmit check
      is now available and should prevent new useless forward declarations
      to come up.
      
      BUG=662195
      CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_nacl_sdk
      
      Review-Url: https://codereview.chromium.org/2554863002
      Cr-Commit-Position: refs/heads/master@{#436883}
      db24b9e6
  25. 08 Nov, 2016 1 commit
  26. 02 Nov, 2016 1 commit
  27. 31 Oct, 2016 1 commit
  28. 17 Oct, 2016 1 commit
  29. 28 Sep, 2016 1 commit
  30. 23 Sep, 2016 1 commit
  31. 21 Sep, 2016 1 commit
  32. 14 Sep, 2016 1 commit
    • brettw's avatar
      Remove GYP files. · 315e4cfd
      brettw authored
      This removes all .gyp files not called "compiled_resources" in the main Chromium repository.
      CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
      
      Review-Url: https://codereview.chromium.org/2332843004
      Cr-Commit-Position: refs/heads/master@{#418654}
      315e4cfd
  33. 01 Sep, 2016 1 commit
    • maruel's avatar
      Delete all test isolate file now that M54 was branched. · 95b6282d
      maruel authored
      The runtime dependencies data was successfully transitioned to GN.
      
      Keep non-testing isolate as some projects (v8, webrtc) still need some. They
      will be curated incrementally.
      
      Ran:
        $ git rm $(git ls-files -- "*.isolate" | grep -i test | grep -v testserver)
        $ git ls-files -- "*.isolate" | wc -l
        14
      
      TBR=dpranke@chromium.org
      BUG=
      CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
      
      Review-Url: https://codereview.chromium.org/2257893002
      Cr-Commit-Position: refs/heads/master@{#415954}
      95b6282d
  34. 31 Aug, 2016 1 commit
  35. 30 Aug, 2016 1 commit
    • asvitkine's avatar
      Change includes of histogram.h to histogram_macros.h. · 3033081a
      asvitkine authored
      This is another pass of migration of includes for users of histogram
      macros. This doesn't fully complete the migration, but gets us closer
      to the end result.
      
      A few files needed to include both headers as they use both
      macros and the raw API.
      
      BUG=416479
      CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
      TBR=jam@chromium.org
      
      Review-Url: https://codereview.chromium.org/2293583002
      Cr-Commit-Position: refs/heads/master@{#415067}
      3033081a
  36. 25 Aug, 2016 1 commit
  37. 24 Aug, 2016 1 commit
  38. 22 Jul, 2016 1 commit
  39. 19 Jul, 2016 1 commit