- 26 Apr, 2017 40 commits
-
-
machenbach authored
This partially reverts: https://codereview.chromium.org/2828143007 to fix broken GPU Linux builder. BUG=714976,714336 TBR=dpranke@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2842963003 Cr-Commit-Position: refs/heads/master@{#467318}
-
fdoray authored
The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=sadrul@chromium.org Review-Url: https://codereview.chromium.org/2839793002 Cr-Commit-Position: refs/heads/master@{#467317}
-
miguelg authored
Right now we have specific ifdefs for android as opposed to just relying on ENABLE_NATIVE_NOTIFICATIONS + features::kNativeNotifications like all other platforms. BUG= Review-Url: https://codereview.chromium.org/2836093002 Cr-Commit-Position: refs/heads/master@{#467316}
-
skyostil authored
This patch adds support for the --log-net-log command line flag to headless to help diagnosing issues with networking. BUG=706355 Review-Url: https://codereview.chromium.org/2841953002 Review-Url: https://codereview.chromium.org/2841953002 Cr-Commit-Position: refs/heads/master@{#467315}
-
fdoray authored
The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=asanka@chromium.org Review-Url: https://codereview.chromium.org/2839643003 Cr-Commit-Position: refs/heads/master@{#467314}
-
yukishiino authored
https://crbug.com/252482 demonstrates that a) V8HTMLDocument's locationAttributeGetter is NOT using a private property to keep the location's wrapper alive. b) Location.idl does NOT specify [DependentLifetime]. c) V8 minor GC can collect a wrapper object of document.location if author script has no reference to it. d) V8Window::locationAttributeGetterCustom is using a private property to keep it alive, but it may be too late. At c), V8 may have already collected the location's wrapper object, and expandos may have been gone. The direct cause is that 1) There are two paths to create a Location's wrapper object; window.location and document.location. 2) document.location doesn't use a private property (keep_alive) though window.location uses it. This CL makes the following changes. i) Uses the wrapper tracing in order to make Location's wrapper objects alive. ii) Makes Location [DependentLifetime] so that the wrapper tracing works. BUG=252482 Review-Url: https://codereview.chromium.org/2826393004 Cr-Commit-Position: refs/heads/master@{#467313}
-
fdoray authored
The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=asanka@chromium.org Review-Url: https://codereview.chromium.org/2841713002 Cr-Commit-Position: refs/heads/master@{#467312}
-
altimin authored
CC=skyostil@chromium.org BUG=710063 Review-Url: https://codereview.chromium.org/2836203003 Cr-Commit-Position: refs/heads/master@{#467311}
-
pmeenan authored
Revert of Don't lower priority for scripts inserted by doc.write (patchset #5 id:70001 of https://codereview.chromium.org/2826213003/ ) Reason for revert: The layout test was broken and racy (http://crbug.com/715528). SHould be trivial to fix (use the same query param for the preloaded and real image) but best to revert, fix and re-land separately. Original issue's description: > Don't lower priority for scripts inserted by doc.write > > HTML Chunks inserted by document.write() are run through a separate > instance of the preload scanner from the main document. If the main > document scanner has already discovered an image then all scripts > discovered by any preload scanner regardless of where they came from > would be considered late-body. > > This behavior causes a regression where a document.write() in the head > that includes multiple script tags will discover them but treat them as > late-body scripts and only load them one at a time. > > BUG=713727,712338 > > Review-Url: https://codereview.chromium.org/2826213003 > Cr-Commit-Position: refs/heads/master@{#467029} > Committed: https://chromium.googlesource.com/chromium/src/+/1e0d3cbbf60c67ba9856eadcb9e829b3c4bec6c7 TBR=yoav@yoav.ws,kinuko@chromium.org,csharrison@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=713727,712338 Review-Url: https://codereview.chromium.org/2843013002 Cr-Commit-Position: refs/heads/master@{#467310}
-
drcrash authored
BUG=none Review-Url: https://codereview.chromium.org/2836423003 Cr-Commit-Position: refs/heads/master@{#467309}
-
maxmorin authored
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/9cdb538..ce4e632 $ git log 9cdb538..ce4e632 --date=short --no-merges --format=%ad %ae %s 2017-04-26 mbonadei@webrtc.org Reland of Creating webrtc/modules:module_api (patchset #1 id:1 of https://codereview.webrtc.org/2839963005/ ) 2017-04-26 ilnik@webrtc.org Fix default extension id for video content type extension 2017-04-26 magjed@webrtc.org ObjC: Split out I420 texture uploading into separate class 2017-04-26 mbonadei@webrtc.org Revert of Creating webrtc/modules:module_api (patchset #5 id:80001 of https://codereview.webrtc.org/2838873002/ ) 2017-04-26 mbonadei@webrtc.org Creating webrtc/modules:module_api 2017-04-26 nisse@webrtc.org Move autowrap from ThreadManager constructor to Thread::Current. 2017-04-26 mbonadei@webrtc.org Revert of Enable GN check for webrtc/base (patchset #9 id:350001 of https://codereview.webrtc.org/2840453004/ ) 2017-04-26 mbonadei@webrtc.org Reland of Enable GN check for webrtc/base (patchset #3 id:230001 of https://codereview.webrtc.org/2838683002/ ) 2017-04-26 brandtr@webrtc.org Use field_trial::IsEnabled for FlexFEC. 2017-04-25 mbonadei@webrtc.org Creating webrtc:video_stream_api 2017-04-25 philipp.hancke@googlemail.com Fix comment about remote restart being requested in createOffer 2017-04-25 kwiberg@webrtc.org Add SafeMin() and SafeMax(), which accept args of different types 2017-04-25 ilnik@webrtc.org Remove deprecated headers 2017-04-25 magjed@webrtc.org Android: Move EglBase10/EglBase14 from to API to src TBR= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG= Review-Url: https://codereview.chromium.org/2842993002 Cr-Commit-Position: refs/heads/master@{#467308}
-
kinuko authored
BUG=695279 Review-Url: https://codereview.chromium.org/2838153002 Cr-Commit-Position: refs/heads/master@{#467307}
-
foolip authored
Fixes https://github.com/w3c/web-platform-tests/issues/4822 BUG=673664 R=lunalu@chromium.org,kojii@chromium.org,ksakamoto@chromium.org Review-Url: https://codereview.chromium.org/2841903002 Cr-Commit-Position: refs/heads/master@{#467306}
-
jdoerrie authored
This change implements dropping the SiteBoundCredential interface in favor of the CredentialUserData mixin. This change was introduced in the Credential Manager API specification with commit a43865bd8aa9842dbc8d8e688d5668c087677eac (https://github.com/w3c/webappsec-credential-management/commit/a43865bd8aa9842dbc8d8e688d5668c087677eac). Intent to Deprecate and Remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/X-5zjSOzLC4 R=vasilii@chromium.org,mkwst@chromium.org,jochen@chromium.org BUG=714615 Review-Url: https://codereview.chromium.org/2832813002 Cr-Commit-Position: refs/heads/master@{#467305}
-
jinho.bang authored
Remove the stored payment instrument in associated service worker registration. Related Spec Link: https://w3c.github.io/webpayments-payment-handler/#paymentinstruments-interface BUG=661608 TEST=payment_manager_unittest.cc, payment-instruments.html Review-Url: https://codereview.chromium.org/2844463002 Cr-Commit-Position: refs/heads/master@{#467304}
-
joelhockey authored
Remove FrameViewBase.cpp file. This CL is in preparation to move core/paint/ScrollbarManager to platform/scroll and use it as replacement for FrameViewBase. BUG=637460 Review-Url: https://codereview.chromium.org/2843693003 Cr-Commit-Position: refs/heads/master@{#467303}
-
alemate authored
BUG=647411 Review-Url: https://codereview.chromium.org/2843723004 Cr-Commit-Position: refs/heads/master@{#467302}
-
perezju authored
Revert of
🏠 Polish bottom sheet content transitions (patchset #1 id:1 of https://codereview.chromium.org/2839673002/ ) Reason for revert: Appears to be causing multiple chrome_public_test_apk failures on Marshmallow 64 bit Tester. crbug.com/715336 Original issue's description: > [Home] Polish bottom sheet content transitions > > This change adds animation when transitioning between bottom sheet > content. The existing view is faded out completely before the new > view is faded in. The animation is applied to both the sheet content > and the toolbar view. > > Notably, the onContentChanged() event is now called when the > transition animation has finished instead of immediately when > showContent(...) is called. > > BUG=702717 > > Review-Url: https://codereview.chromium.org/2839673002 > Cr-Commit-Position: refs/heads/master@{#466780} > Committed: https://chromium.googlesource.com/chromium/src/+/419509cbf0ac3a8a8595b3ce9e56daf75e5c2f0c TBR=twellington@chromium.org,mdjones@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=702717 Review-Url: https://codereview.chromium.org/2838313003 Cr-Commit-Position: refs/heads/master@{#467301} -
nhiroki authored
This is split from https://codereview.chromium.org/2840523002/ Worklet::Initialize() is called when addModule() is called for the first time, and expected to initialize a messaging proxy and a worklet thread. This is used only for threaded worklets, and not necessary for main thread worklets. Therefore, this CL moved it from Worklet to ThreadedWorklet. Motivation of this change: MainThreadWorklet will have a separate initialization logic after the above CL and the similar initialization function will be an obstacle. BUG=627945 Review-Url: https://codereview.chromium.org/2845533002 Cr-Commit-Position: refs/heads/master@{#467300}
-
hiroshige authored
Because the things in ClassicPendingScript::DisposeInternal() except for ScriptStreamer::Cancel() doesn't have to be called as a prefinalizer, this CL introduces ClassicPendingScript::Prefinalize() that only calls ScriptStreamer::Cancel() and thus makes Dispose() not to be called there. This CL simplified the prefinalization of ClassicPendingScript, especially order dependencies between ClassicPendingScript's prefinalizer and the prefinalizer of its parent class (ResourceOwner). Leaving ClassicPendingScript in a not-Dispose()d state is not observable if the related classes obeys the rule of Oilpan, and https://codereview.chromium.org/2837413002/ checks that in case there were a bug. BUG=715309 Review-Url: https://codereview.chromium.org/2844583002 Cr-Commit-Position: refs/heads/master@{#467299}
-
Daniel Cheng authored
Bug: 709815 Change-Id: I8f35864239dc5a606b473cdd82add2e68a76cb08 Reviewed-on: https://chromium-review.googlesource.com/487861Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#467298}
-
findit-for-me authored
Revert of headless: Add support for net logging (patchset #2 id:20001 of https://codereview.chromium.org/2841953002/ ) Reason for revert: Findit(https://goo.gl/kROfz5) identified CL at revision 467289 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2I5YTQyYWI2ZjA3M2IwNTdjOGMwNWQyYmZjNzk5ZGNjODA4MmUyYTYM Sheriff's note: See crbug.com/715513 for details. Original issue's description: > headless: Add support for net logging > > This patch adds support for the --log-net-log command line flag to > headless to help diagnosing issues with networking. > > BUG=706355 > > Review-Url: https://codereview.chromium.org/2841953002 > Cr-Commit-Position: refs/heads/master@{#467289} > Committed: https://chromium.googlesource.com/chromium/src/+/b9a42ab6f073b057c8c05d2bfc799dcc8082e2a6 TBR=eseckler@chromium.org,skyostil@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=706355,715513 Review-Url: https://codereview.chromium.org/2839153002 Cr-Commit-Position: refs/heads/master@{#467297}
-
avallee authored
+ Correctly focus the inner WebContents when the attachment frame is focused. + Enable Enable WebViewFocusInteractiveTest.Focus_FocusBeforeNavigation. + Prevent BrowserPluginGuest from unfocusing the guest in oopif mode. BUG=672947 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2715213009 Cr-Commit-Position: refs/heads/master@{#467296}
-
Daniel Cheng authored
This is web-exposed via Document and other interfaces. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Bug: 713843 Change-Id: Idff897e4f3177a0ff67ecfda413b8fae9d51f556 Reviewed-on: https://chromium-review.googlesource.com/487882 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#467295}
-
mastiz authored
This new parameter intends to replace or complement the version override param to distinguish various published versions of Popular Sites. BUG=715039 Review-Url: https://codereview.chromium.org/2841643005 Cr-Commit-Position: refs/heads/master@{#467294}
-
Daniel Cheng authored
Bug: 709815 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I6e5a2665f2b82b993a4544a8cbd052fadc35d987 Change-Id: I6e5a2665f2b82b993a4544a8cbd052fadc35d987 Reviewed-on: https://chromium-review.googlesource.com/487901 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#467293}
-
machenbach authored
Work-around as browser_tests are erroneously not rebuilt properly on gpu bots. BUG=chromium:714976 TBR=kbr@chromium.org,fjhenigman@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel NOTRY=true Review-Url: https://codereview.chromium.org/2841833003 Cr-Commit-Position: refs/heads/master@{#467292}
-
foolip authored
The ServiceWorkerMessageEvent.* files were already removed from BUILD.gn: https://codereview.chromium.org/2466513002 This inlines the templatized helpers in V8ServiceWorkerMessageEventInternal.h into non-templated code in V8ExtendableMessageEventCustom.cpp, which is now the only place the helpers are used. BUG=659074 Review-Url: https://codereview.chromium.org/2837353003 Cr-Commit-Position: refs/heads/master@{#467291}
-
treib authored
This enables birthday doodles. BUG=715154 Review-Url: https://codereview.chromium.org/2838713003 Cr-Commit-Position: refs/heads/master@{#467290}
-
skyostil authored
This patch adds support for the --log-net-log command line flag to headless to help diagnosing issues with networking. BUG=706355 Review-Url: https://codereview.chromium.org/2841953002 Cr-Commit-Position: refs/heads/master@{#467289}
-
dpranke authored
This CL adds some debugging code to try and figure out why Xvfb is dying on the Site Isolation Linux bot. R=tansell@chromium.org BUG=708681 Review-Url: https://codereview.chromium.org/2836403003 Cr-Commit-Position: refs/heads/master@{#467288}
-
mastiz authored
Follow-up to https://codereview.chromium.org/2796643002 where the metrics were added but an inconsistency was introduced between the C++ enum and the Javascript counterpart. This caused the wrong buckets being counted for NewTabPage.TileType (ThumbnailLocal instead Thumbnail; ThumbnailServer instead of ThumbnailFailed). The affected buckets were already deprecated (DeprecatedThumbnailLocal and DeprecatedThumbnailServer) and hence, luckily, there are no conflated buckets. Besides, histograms.xml was missing the new suffixes for NewTabPageIconTypes, used to provide desktop-specific breakdowns for NewTabPage.MostVisited and NewTabPage.SuggestionsImpression. BUG=714095,703165 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2832173002 Cr-Commit-Position: refs/heads/master@{#467287}
-
treib authored
BUG=583292 Review-Url: https://codereview.chromium.org/2811353002 Cr-Commit-Position: refs/heads/master@{#467286}
-
pastarmovj authored
https://codereview.chromium.org/2518493002 removed the code to reenable plugins but this doesn't reset the state and end up overwriting the new pdf/flash setting each time the old prefs are read again. After the CL the flag was not added to new Preferences files this code only applies to existing legacy settings. BUG=705979 Review-Url: https://codereview.chromium.org/2841843002 Cr-Commit-Position: refs/heads/master@{#467285}
-
hayato authored
BUG=715440 Review-Url: https://codereview.chromium.org/2838013005 Cr-Commit-Position: refs/heads/master@{#467284}
-
fdoray authored
This CL allows tasks to be posted via base/task_scheduler/post_task.h as soon as BrowserMainLoop is instantiated. Tasks don't run until TaskScheduler::Start() is called in BrowserMainLoop::CreateThreads(). BUG=690706 Review-Url: https://codereview.chromium.org/2835933004 Cr-Commit-Position: refs/heads/master@{#467283}
-
chrome://settings/passwordsvasilii authored
This is a follow-up to https://codereview.chromium.org/2805683002/ BUG=706310 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2837793003 Cr-Commit-Position: refs/heads/master@{#467282}
-
mattcary authored
Adds the CCTBackgroundTab (ChromeFeatureList::CCT_BACKGROUND_TAB) feature which is enabled by default. BUG=708173 Review-Url: https://codereview.chromium.org/2837873002 Cr-Commit-Position: refs/heads/master@{#467281}
-
rhalavati authored
Following discussion in https://codereview.chromium.org/2800653002, cookies are disabled for network request of: components/policy/core/common/cloud/device_management_service.cc BUG= Review-Url: https://codereview.chromium.org/2837123005 Cr-Commit-Position: refs/heads/master@{#467280}
-
tansell authored
Revert of Decrease swarming shards for Linux RandomOrder bots from 18 to 6. (patchset #1 id:1 of https://codereview.chromium.org/2835903002/ ) Reason for revert: Want to go back to 18 shards to increase likelihood of single shard failure issues. Original issue's description: > Decrease swarming shards for Linux RandomOrder bots from 18 to 6. > > Review-Url: https://codereview.chromium.org/2835903002 > Cr-Commit-Position: refs/heads/master@{#466599} > Committed: https://chromium.googlesource.com/chromium/src/+/e510777b49ba34c52aebc3613552cf2f4acbc2dc TBR=mcgreevy@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Review-Url: https://codereview.chromium.org/2842973002 Cr-Commit-Position: refs/heads/master@{#467279}
-