• Nicolas Dossou-gbete's avatar
    🏡 Look up the logo type to request before each fetch · 17ec2b04
    Nicolas Dossou-gbete authored
    Initialise LogoService with a callback to get the type of logo to
    request from the server rather than hardcoding it at construction
    This will allow showing the right type of Doodle in the NewTabPage
    or bottom sheet when ChromeHome is turned on or off at runtime.
    This patch also refactors the logo URL building logic, adding the
    parameters to the base URL in 2 steps: one for the ones that do not
    change across calls and are part of the endpoint API configuration
    (e.g. whether to use gray doodles), and the ones that can change
    across calls (e.g. logo fingerprint)
    Bug: 776725
    Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Ibaba09431e2c24fdb518511c8e14b1c7a198944f
    Reviewed-on: https://chromium-review.googlesource.com/743964
    Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org>
    Reviewed-by: default avatarMarc Treib <treib@chromium.org>
    Reviewed-by: default avatarEric Noyau <noyau@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#515140}
Last commit
Last update
OWNERS Loading commit data...
logo_service_factory.cc Loading commit data...
logo_service_factory.h Loading commit data...