• rdevlin.cronin's avatar
    [Extensions Bindings] Add an end-to-end test for the fileSystem API · 577b8f36
    rdevlin.cronin authored
    Add an end-to-end test for the fileSystem API, which exercises a few
    different niche properties:
    a) It has an unusual isInstanceOf property (Entry)
    b) It hacks up the arguments with a setUpdateArgumentsPostValidate hook
    c) It uses some craziness to bind file entries to the background page
    
    a) is already implemented, but this adds an end-to-end test for it.
    b) required updating logic to no longer parse and validate arguments
    after a post-update hook. This is unfortunate (see comments for why),
    but a number of APIs do this, so for now, we have to support it. Add
    a few comments lamenting the state, and a test to ensure it doesn't
    break.
    c) required updating the util js module to not require the method from
    the API module's custom bindings, since an API instantiated through a
    require() won't have the apiBridge passed in. APIs should be instatiated
    through the lazy get; utils should be require()d.
    
    BUG=653596
    
    Review-Url: https://codereview.chromium.org/2793033002
    Cr-Commit-Position: refs/heads/master@{#461976}
    577b8f36
Name
Last commit
Last update
..
browser Loading commit data...
common Loading commit data...
components Loading commit data...
docs Loading commit data...
features Loading commit data...
renderer Loading commit data...
shell Loading commit data...
strings Loading commit data...
test Loading commit data...
utility Loading commit data...
BUILD.gn Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...
README.md Loading commit data...
extensions_resources.grd Loading commit data...