• Mikel Astiz's avatar
    Adopt enum class for favicon_base::IconType · a5ea255f
    Mikel Astiz authored
    Semi-automated patch composed almost entirely of renames, with the goal
    to provide stronger type safety via enum class and most notably prevent
    the enum from being used as bitmask (IconTypeSet should be used for
    this).
    
    The only non-trivial changes are in thumbnail_database.* where the enum
    needs to be casted to/from int. We introduce helper functions and the
    corresponding unit tests in preparation for future patches that will
    modify the enum values.
    
    Bug: 778551
    Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Ide9a110a4d33ac5e94c6d113219631f24ef1ee1a
    Reviewed-on: https://chromium-review.googlesource.com/753361Reviewed-by: 's avatarDaniel Cheng <dcheng@chromium.org>
    Reviewed-by: 's avatarBrett Wilson <brettw@chromium.org>
    Commit-Queue: Mikel Astiz <mastiz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#514270}
    a5ea255f
Name
Last commit
Last update
..
revisit Loading commit data...
BUILD.gn Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
fake_sync_sessions_client.cc Loading commit data...
fake_sync_sessions_client.h Loading commit data...
favicon_cache.cc Loading commit data...
favicon_cache.h Loading commit data...
favicon_cache_unittest.cc Loading commit data...
local_session_event_router.h Loading commit data...
lost_navigations_recorder.cc Loading commit data...
lost_navigations_recorder.h Loading commit data...
lost_navigations_recorder_unittest.cc Loading commit data...
open_tabs_ui_delegate.cc Loading commit data...
open_tabs_ui_delegate.h Loading commit data...
session_data_type_controller.cc Loading commit data...
session_data_type_controller.h Loading commit data...
session_data_type_controller_unittest.cc Loading commit data...
session_sync_test_helper.cc Loading commit data...
session_sync_test_helper.h Loading commit data...
sessions_sync_manager.cc Loading commit data...
sessions_sync_manager.h Loading commit data...
sessions_sync_manager_unittest.cc Loading commit data...
sync_sessions_client.cc Loading commit data...
sync_sessions_client.h Loading commit data...
sync_sessions_metrics.cc Loading commit data...
sync_sessions_metrics.h Loading commit data...
sync_sessions_metrics_unittest.cc Loading commit data...
synced_session.cc Loading commit data...
synced_session.h Loading commit data...
synced_session_tracker.cc Loading commit data...
synced_session_tracker.h Loading commit data...
synced_session_tracker_unittest.cc Loading commit data...
synced_tab_delegate.cc Loading commit data...
synced_tab_delegate.h Loading commit data...
synced_window_delegate.h Loading commit data...
synced_window_delegates_getter.cc Loading commit data...
synced_window_delegates_getter.h Loading commit data...
tab_node_pool.cc Loading commit data...
tab_node_pool.h Loading commit data...
tab_node_pool_unittest.cc Loading commit data...
task_tracker.cc Loading commit data...
task_tracker.h Loading commit data...
task_tracker_unittest.cc Loading commit data...