• hiroshige's avatar
    Do not call Dispose() as ClassicPendingScript's prefinalizer · faa05510
    hiroshige authored
    Because the things in ClassicPendingScript::DisposeInternal() except for
    ScriptStreamer::Cancel() doesn't have to be called as a prefinalizer,
    this CL introduces ClassicPendingScript::Prefinalize() that only calls
    ScriptStreamer::Cancel() and thus makes Dispose() not to be called there.
    
    This CL simplified the prefinalization of ClassicPendingScript, especially
    order dependencies between ClassicPendingScript's prefinalizer and the
    prefinalizer of its parent class (ResourceOwner).
    Leaving ClassicPendingScript in a not-Dispose()d state is not observable
    if the related classes obeys the rule of Oilpan, and
    https://codereview.chromium.org/2837413002/ checks that in case there were
    a bug.
    
    BUG=715309
    
    Review-Url: https://codereview.chromium.org/2844583002
    Cr-Commit-Position: refs/heads/master@{#467299}
    faa05510
Name
Last commit
Last update
android_webview Loading commit data...
apps Loading commit data...
ash Loading commit data...
base Loading commit data...
blink Loading commit data...
breakpad Loading commit data...
build Loading commit data...
build_overrides Loading commit data...
cc Loading commit data...
chrome Loading commit data...
chrome_elf Loading commit data...
chromecast Loading commit data...
chromeos Loading commit data...
cloud_print Loading commit data...
components Loading commit data...
content Loading commit data...
courgette Loading commit data...
crypto Loading commit data...
dbus Loading commit data...
device Loading commit data...
docs Loading commit data...
extensions Loading commit data...
gin Loading commit data...
google_apis Loading commit data...
google_update Loading commit data...
gpu Loading commit data...
headless Loading commit data...
infra Loading commit data...
ios Loading commit data...
ipc Loading commit data...
jingle Loading commit data...
mash Loading commit data...
media Loading commit data...
mojo Loading commit data...
native_client_sdk Loading commit data...
net Loading commit data...
pdf Loading commit data...
ppapi Loading commit data...
printing Loading commit data...
remoting Loading commit data...
rlz Loading commit data...
sandbox Loading commit data...
sdch Loading commit data...
services Loading commit data...
skia Loading commit data...
sql Loading commit data...
storage Loading commit data...
styleguide Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
ui Loading commit data...
url Loading commit data...
.clang-format Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.chromium_os Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
PRESUBMIT_test.py Loading commit data...
PRESUBMIT_test_mocks.py Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...