Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • W wine
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • Alexandros Frantzis
  • wine
  • Merge requests
  • !28

Draft: Add level of indirection to formats list in the tranches to avoid list corruption.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Sergio Gómez Del Real requested to merge sergiogdr89/wine-wayland:dmabuf_formats_list_crash into wayland Jul 01, 2022
  • Overview 1
  • Commits 171
  • Changes 52

The problem is in using (static) lists in the tranches array; when adding a tranche to the array through wl_array_add(), the memory reallocation in libwayland messes up the lists.

Adding a level of indirection to the lists solves the problem, the tradeoff being a bit more of memory management.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: dmabuf_formats_list_crash