Skip to content
  • epriestley's avatar
    In Ferret, allow documents with no title to match query terms by using LEFT... · cb4add31
    epriestley authored
    In Ferret, allow documents with no title to match query terms by using LEFT JOIN on the "title" ranking field
    
    Summary:
    Fixes T13345. See D20650. Currently, `PhabricatorCursorPagedPolicyAwareQuery` does a JOIN against the "title" field so it can apply additional ranking/ordering conditions to the query.
    
    This means that documents with no title (which don't have this field) are always excluded from the result set.
    
    We'd prefer to include them, just not give them any bonus ranking/relevance boost. Use a LEFT JOIN so they get included.
    
    Test Plan:
      - Applied D20650 (diff 1), made it use raw `getTitle()` as the document title, indexed a paste with no title.
      - Searched for a term in the paste body.
      - Before change: no results.
      - After change: found result.
    
    {F6601159}
    
    Reviewers: amckinley
    
    Reviewed By: amckinley
    
    Maniphest Tasks: T13345
    
    Differential Revision: https://secure.phabricator.com/D20660
    cb4add31