1. 19 Jul, 2019 2 commits
  2. 03 Jul, 2019 6 commits
  3. 02 Jul, 2019 1 commit
  4. 01 Jul, 2019 3 commits
  5. 28 Jun, 2019 1 commit
    • Marek Vasut's avatar
      etnaviv: Fix double-free in etna_bo_cache_free() · cecedcb8
      Marek Vasut authored
      The following situation can happen in a multithreaded OpenGL application.
      A BO is submitted from etna_cmd_stream #1 with flags set for read.
      A BO is submitted from etna_cmd_stream #2 with flags set for write.
      This triggers a flush on stream #1 and clears the BO's current_stream
      pointer. If at this point, stream #2 attempts to queue BO again, which
      does happen, the BO will be added to the submit list twice. The Linux
      kernel driver correctly detects this and warns about it with "BO at
      index %u already on submit list" kernel message.
      However, when cleaning the BO cache in etna_bo_cache_free(), the BO
      which was submitted twice will also be free()d twice, this triggering
      a glibc double free detector.
      The fix is easy, even if the BO does not have current_stream set,
      iterate over current streams' list of BOs before adding the BO to it
      and verify that the BO is not yet there.
      Signed-off-by: default avatarMarek Vasut <marex@denx.de>
      Cc: Christian Gmeiner <christian.gmeiner@gmail.com>
      Cc: Lucas Stach <l.stach@pengutronix.de>
      Reviewed-by: default avatarChristian Gmeiner <christian.gmeiner@gmail.com>
      Reviewed-by: default avatarWladimir J. van der Laan <laanwj@gmail.com>
  6. 25 Jun, 2019 2 commits
  7. 24 Jun, 2019 1 commit
  8. 22 Jun, 2019 11 commits
  9. 21 Jun, 2019 4 commits
  10. 11 Jun, 2019 2 commits
  11. 16 May, 2019 7 commits