- Jul 13, 2022
-
-
Bob Beckett authored
refactor stolen memory region to use ttm. this necessitates using ttm resources to track reserved stolen regions instead of drm_mm_nodes. Signed-off-by:
Robert Beckett <bob.beckett@collabora.com>
-
Bob Beckett authored
Commit "bcb9aa45 Revert "drm/i915: Hold reference to intel_context over life of i915_request"" Stopped requests from maintaining a ref on the context. This caused the contexts to be freed, releasing stolen memory while under test, leading to false positive detection of stolen corruption. Fix this by maintaining a ref on the contexts until testing is complete. Signed-off-by:
Robert Beckett <bob.beckett@collabora.com>
-
Bob Beckett authored
igt_reset_engines_stolen tries to reset engines without checking if it is possible. Engines using GuC submission are not able to be reset from the host. In this scenario, the reset exits early, then on the next iteration of the each engine loop, the async teardown of the spinner request context's ring occurs while the next engine is under test. This is seen as a stolen memory corruption as the ring buffer was busy initially, but free during the confirmation check and had been poisoned during cleanup. Fix this by not testing GuC submission using engines. Signed-off-by:
Robert Beckett <bob.beckett@collabora.com>
-
Bob Beckett authored
For situations where allocations need to fail on alloc instead of delayed get_pages, add a new alloc flag to pin the ttm bo. This makes sure that the resource has been allocated during buffer creation, allowing it to fail with an error if the placement is exhausted. This allows existing fallback options for stolen backend allocation like create_ring_vma to work as expected. Signed-off-by:
Robert Beckett <bob.beckett@collabora.com>
-
Bob Beckett authored
ttm managed buffers start off with system resource definitions and ttm_tt tracking structures allocated (though unpopulated). currently this prevents clearing of buffers on first move to desired placements. The desired behaviour is to clear user allocated buffers and any kernel buffers that specifically requests it only. Make the logic match the desired behaviour. Signed-off-by:
Robert Beckett <bob.beckett@collabora.com> Reviewed-by:
Thomas Hellström <thomas.hellstrom@linux.intel.com>
-
Bob Beckett authored
Stolen regions are not page backed or considered iomem. Prevent flags indicating such. This correctly prevents stolen buffers from attempting to directly map them. See i915_gem_object_has_struct_page() and i915_gem_object_has_iomem() usage for where it would break otherwise. Signed-off-by:
Robert Beckett <bob.beckett@collabora.com> Reviewed-by:
Thomas Hellström <thomas.hellstrom@linux.intel.com>
-
Bob Beckett authored
prepare for ttm based stolen region by using ttm range manager as the resource manager for stolen region. Signed-off-by:
Robert Beckett <bob.beckett@collabora.com> Reviewed-by:
Thomas Hellström <thomas.hellstrom@linux.intel.com>
-
- Jul 11, 2022
-
-
Bob Beckett authored
By default i915_ttm_cache_level() decides I915_CACHE_LLC if HAS_SNOOP. This is divergent from existing backends code which only considers HAS_LLC. Testing shows that trusting snooping on gen5- is unreliable and bsw via ggtt mappings, so limit DGFX for now and maintain previous behaviour. Signed-off-by:
Robert Beckett <bob.beckett@collabora.com> Reviewed-by:
Thomas Hellström <thomas.hellstrom@linux.intel.com>
-
Bob Beckett authored
i965G[M] cannot relocate objects above 4GiB. Ensure ttm uses dma32 on these systems. Signed-off-by:
Robert Beckett <bob.beckett@collabora.com> Reviewed-by:
Thomas Hellström <thomas.hellstrom@linux.intel.com>
-
Bob Beckett authored
Various places within the driver override the default chosen cache_level. Before ttm, these overrides were permanent until explicitly changed again or for the lifetime of the buffer. TTM movement code came along and decided that it could make that decision at that time, which is usually well after object creation, so overrode the cache_level decision and reverted it back to its default decision. Add logic to indicate whether the caching mode has been set by anything other than the move logic. If so, assume that the code that overrode the defaults knows best and keep it. Signed-off-by:
Robert Beckett <bob.beckett@collabora.com> Reviewed-by:
Thomas Hellström <thomas.hellstrom@linux.intel.com>
-
Javier Martinez Canillas authored
-
Javier Martinez Canillas authored
# Conflicts: # drivers/acpi/sleep.c # kernel/locking/lockdep.c # kernel/time/timer.c
-
Javier Martinez Canillas authored
-
Javier Martinez Canillas authored
-
Javier Martinez Canillas authored
-
Javier Martinez Canillas authored
-
Javier Martinez Canillas authored
# Conflicts: # drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c # drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.h # drivers/gpu/drm/drm_aperture.c # drivers/gpu/drm/i915/display/intel_dp.c # drivers/gpu/drm/vc4/vc4_drv.c
-
Javier Martinez Canillas authored
-
Javier Martinez Canillas authored
-
Andrzej Hajda authored
On some machines hole_end can be small enough to cause subtraction overflow. On the other side (addr + 2 * min_alignment) can overflow in case of mock tests. This patch should handle both cases. Fixes: e1c5f754 ("drm/i915: Avoid overflow in computing pot_hole loop termination") Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/3674 Signed-off-by:
Andrzej Hajda <andrzej.hajda@intel.com> Reviewed-by:
Andi Shyti <andi.shyti@linux.intel.com> Signed-off-by:
Andi Shyti <andi.shyti@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20220624113528.2159210-1-andrzej.hajda@intel.com
-
Matthew Auld authored
If we encounter some monster sized local-memory page that exceeds the maximum sg length (UINT32_MAX), ensure that don't end up with some misaligned address in the entry that follows, leading to fireworks later. Also ensure we have some coverage of this in the selftests. v2(Chris): - Use round_down consistently to avoid udiv errors v3(Nirmoy): - Also update the max_segment in the selftest Fixes: f701b16d ("drm/i915/ttm: add i915_sg_from_buddy_resource") Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/6379 Signed-off-by:
Matthew Auld <matthew.auld@intel.com> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com> Cc: Nirmoy Das <nirmoy.das@linux.intel.com> Reviewed-by:
Nirmoy Das <nirmoy.das@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20220711085859.24198-1-matthew.auld@intel.com
-
Arthur Grillo authored
Considering the current adoption of the KUnit framework, convert the DRM mm selftest to the KUnit API. Signed-off-by:
Arthur Grillo <arthur.grillo@usp.br> Tested-by:
David Gow <davidgow@google.com> Acked-by:
Daniel Latypov <dlatypov@google.com> Reviewed-by:
Javier Martinez Canillas <javierm@redhat.com> Signed-off-by:
Maíra Canal <maira.canal@usp.br> Signed-off-by:
Javier Martinez Canillas <javierm@redhat.com> Link: https://patchwork.freedesktop.org/patch/msgid/20220708203052.236290-10-maira.canal@usp.br
-
Maíra Canal authored
Considering the current adoption of the KUnit framework, convert the DRM buddy selftest to the KUnit API. Tested-by:
David Gow <davidgow@google.com> Acked-by:
Daniel Latypov <dlatypov@google.com> Reviewed-by:
Javier Martinez Canillas <javierm@redhat.com> Signed-off-by:
Maíra Canal <maira.canal@usp.br> Signed-off-by:
Javier Martinez Canillas <javierm@redhat.com> Link: https://patchwork.freedesktop.org/patch/msgid/20220708203052.236290-9-maira.canal@usp.br
-
Maíra Canal authored
Considering the current adoption of the KUnit framework, convert the DRM framebuffer selftest to the KUnit API. Tested-by:
David Gow <davidgow@google.com> Acked-by:
Daniel Latypov <dlatypov@google.com> Reviewed-by:
Javier Martinez Canillas <javierm@redhat.com> Signed-off-by:
Maíra Canal <maira.canal@usp.br> Signed-off-by:
Javier Martinez Canillas <javierm@redhat.com> Link: https://patchwork.freedesktop.org/patch/msgid/20220708203052.236290-8-maira.canal@usp.br
-
Maíra Canal authored
Considering the current adoption of the KUnit framework, convert the DRM DP MST helper selftest to the KUnit API. Co-developed-by:
Rubens Gomes Neto <rubens.gomes.neto@usp.br> Signed-off-by:
Rubens Gomes Neto <rubens.gomes.neto@usp.br> Tested-by:
David Gow <davidgow@google.com> Acked-by:
Daniel Latypov <dlatypov@google.com> Reviewed-by:
Javier Martinez Canillas <javierm@redhat.com> Signed-off-by:
Maíra Canal <maira.canal@usp.br> Signed-off-by:
Javier Martinez Canillas <javierm@redhat.com> Link: https://patchwork.freedesktop.org/patch/msgid/20220708203052.236290-7-maira.canal@usp.br
-
Maíra Canal authored
Considering the current adoption of the KUnit framework, convert the DRM plane helper selftest to the KUnit API. Co-developed-by:
Djakson C. G. Filho <djakson.filho@gmail.com> Signed-off-by:
Djakson C. G. Filho <djakson.filho@gmail.com> Co-developed-by:
Anderson Fraga <aaafraga@gmail.com> Signed-off-by:
Anderson Fraga <aaafraga@gmail.com> Tested-by:
David Gow <davidgow@google.com> Acked-by:
Daniel Latypov <dlatypov@google.com> Reviewed-by:
Javier Martinez Canillas <javierm@redhat.com> Signed-off-by:
Maíra Canal <maira.canal@usp.br> Signed-off-by:
Javier Martinez Canillas <javierm@redhat.com> Link: https://patchwork.freedesktop.org/patch/msgid/20220708203052.236290-6-maira.canal@usp.br
-
Maíra Canal authored
Considering the current adoption of the KUnit framework, convert the DRM format selftest to the KUnit API. Tested-by:
David Gow <davidgow@google.com> Acked-by:
Daniel Latypov <dlatypov@google.com> Reviewed-by:
Javier Martinez Canillas <javierm@redhat.com> Signed-off-by:
Maíra Canal <maira.canal@usp.br> Signed-off-by:
Javier Martinez Canillas <javierm@redhat.com> Link: https://patchwork.freedesktop.org/patch/msgid/20220708203052.236290-5-maira.canal@usp.br
-
Maíra Canal authored
Considering the current adoption of the KUnit framework, convert the DRM rect selftest to the KUnit API. Co-developed-by:
Carlos Veras <carlos.craveiro@usp.br> Signed-off-by:
Carlos Veras <carlos.craveiro@usp.br> Co-developed-by:
Matheus Vieira <matheus.vieira.g@usp.br> Signed-off-by:
Matheus Vieira <matheus.vieira.g@usp.br> Tested-by:
David Gow <davidgow@google.com> Acked-by:
Daniel Latypov <dlatypov@google.com> Reviewed-by:
Javier Martinez Canillas <javierm@redhat.com> Signed-off-by:
Maíra Canal <maira.canal@usp.br> Signed-off-by:
Javier Martinez Canillas <javierm@redhat.com> Link: https://patchwork.freedesktop.org/patch/msgid/20220708203052.236290-4-maira.canal@usp.br
-
Maíra Canal authored
Considering the current adoption of the KUnit framework, convert the DRM cmdline parser selftest to the KUnit API. Co-developed-by:
Arthur Grillo <arthur.grillo@usp.br> Signed-off-by:
Arthur Grillo <arthur.grillo@usp.br> Tested-by:
David Gow <davidgow@google.com> Acked-by:
Daniel Latypov <dlatypov@google.com> Reviewed-by:
Javier Martinez Canillas <javierm@redhat.com> Signed-off-by:
Maíra Canal <maira.canal@usp.br> Signed-off-by:
Javier Martinez Canillas <javierm@redhat.com> Link: https://patchwork.freedesktop.org/patch/msgid/20220708203052.236290-3-maira.canal@usp.br
-
Maíra Canal authored
Considering the current adoption of the KUnit framework, convert the DRM damage helper selftest to the KUnit API. Co-developed-by:
Arthur Grillo <arthur.grillo@usp.br> Signed-off-by:
Arthur Grillo <arthur.grillo@usp.br> Tested-by:
David Gow <davidgow@google.com> Acked-by:
Daniel Latypov <dlatypov@google.com> Reviewed-by:
Javier Martinez Canillas <javierm@redhat.com> Signed-off-by:
Maíra Canal <maira.canal@usp.br> Signed-off-by:
Javier Martinez Canillas <javierm@redhat.com> Link: https://patchwork.freedesktop.org/patch/msgid/20220708203052.236290-2-maira.canal@usp.br
-
Dan Carpenter authored
The shmem_pin_map() function doesn't return error pointers, it returns NULL. Fixes: be1cb55a ("drm/i915/gt: Keep a no-frills swappable copy of the default context state") Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by:
Matthew Auld <matthew.auld@intel.com> Signed-off-by:
Matthew Auld <matthew.auld@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20220708094104.GL2316@kadam
-
Christian König authored
Allow BOs to exist without backing store. v2: handle ttm_bo_move_memcpy as well. Signed-off-by:
Christian König <christian.koenig@amd.com> Reviewed-by:
Michael J. Ruhl <michael.j.ruhl@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20220707102453.3633-5-christian.koenig@amd.com
-
Christian König authored
Make sure we can at least move and release BOs without backing store. Signed-off-by:
Christian König <christian.koenig@amd.com> Reviewed-by:
Michael J. Ruhl <michael.j.ruhl@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20220707102453.3633-4-christian.koenig@amd.com
-
Christian König authored
Make sure we can at least move and release BOs without backing store. Signed-off-by:
Christian König <christian.koenig@amd.com> Reviewed-by:
Michael J. Ruhl <michael.j.ruhl@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20220707102453.3633-3-christian.koenig@amd.com
-
Christian König authored
Rename ttm_bo_init to ttm_bo_init_validate since that better matches what the function is actually doing. Remove the unused size parameter, move the function's kerneldoc to the implementation and cleanup the whole error handling. Signed-off-by:
Christian König <christian.koenig@amd.com> Link: https://patchwork.freedesktop.org/patch/msgid/20220707102453.3633-2-christian.koenig@amd.com Reviewed-by:
Michael J. Ruhl <michael.j.ruhl@intel.com>
-
Arunpravin Paneer Selvam authored
This reverts commit 5e3f1e77. This is part of a revert of the following commits: commit 708d19d9 ("drm/amdgpu: move internal vram_mgr function into the C file") commit 5e3f1e77 ("drm/amdgpu: fix start calculation in amdgpu_vram_mgr_new") commit c9cad937 ("drm/amdgpu: add drm buddy support to amdgpu") [WHY] Few users reported garbaged graphics as soon as x starts, reverting until this can be resolved. Signed-off-by:
Arunpravin Paneer Selvam <Arunpravin.PaneerSelvam@amd.com> Reviewed-by:
Christian König <christian.koenig@amd.com> Signed-off-by:
Christian König <christian.koenig@amd.com> Link: https://patchwork.freedesktop.org/patch/msgid/20220708093047.492662-2-Arunpravin.PaneerSelvam@amd.com
-
Arunpravin Paneer Selvam authored
This reverts commit 708d19d9. This is part of a revert of the following commits: commit 708d19d9 ("drm/amdgpu: move internal vram_mgr function into the C file") commit 5e3f1e77 ("drm/amdgpu: fix start calculation in amdgpu_vram_mgr_new") commit c9cad937 ("drm/amdgpu: add drm buddy support to amdgpu") [WHY] Few users reported garbaged graphics as soon as x starts, reverting until this can be resolved. Signed-off-by:
Arunpravin Paneer Selvam <Arunpravin.PaneerSelvam@amd.com> Reviewed-by:
Christian König <christian.koenig@amd.com> Signed-off-by:
Christian König <christian.koenig@amd.com> Link: https://patchwork.freedesktop.org/patch/msgid/20220708093047.492662-1-Arunpravin.PaneerSelvam@amd.com
-
- Jul 09, 2022
-
-
Paul Cercueil authored
- Use DEFINE_SIMPLE_DEV_PM_OPS() instead of the SIMPLE_DEV_PM_OPS() macro. This makes it possible to remove the __maybe_unused flags on the callback functions. - Since we only have callbacks for suspend/resume, we can conditionally compile the dev_pm_ops structure for when CONFIG_PM_SLEEP is enabled; so use the pm_sleep_ptr() macro instead of pm_ptr(). Signed-off-by:
Paul Cercueil <paul@crapouillou.net> Acked-by:
Sam Ravnborg <sam@ravnborg.org> Link: https://patchwork.freedesktop.org/patch/msgid/20220708205406.96473-7-paul@crapouillou.net
-
Paul Cercueil authored
Avoid requesting a full modeset if the sharpness property is not modified, because then we don't actually need it. Signed-off-by:
Paul Cercueil <paul@crapouillou.net> Acked-by:
Sam Ravnborg <sam@ravnborg.org> Link: https://patchwork.freedesktop.org/patch/msgid/20220708205406.96473-5-paul@crapouillou.net
-
Paul Cercueil authored
Add support for the JZ4760 and JZ4760B SoCs to the ingenic-drm display driver. Signed-off-by:
Paul Cercueil <paul@crapouillou.net> Acked-by:
Sam Ravnborg <sam@ravnborg.org> Link: https://patchwork.freedesktop.org/patch/msgid/20220708205406.96473-4-paul@crapouillou.net
-